bookieio / bookie-firefox Goto Github PK

Currently working on this.

Every single time the bookmark sync (downloading URL hashes) is performed, the local storage cache must be purged before iterating the list.

Keeping in mind the limited storage quota, it is crucial to delete the invalid hashes.

This applies to the chrome extension as well.
@mitechie @widox

When adding a new bmark with the Browser Console open, it shows errors saying "cb.failure is not a function".

Looks like calling failure() is a recent addition, but not every call defines one. We ought to define a default handler so we don't throw errors willy nilly.

This error appears in the server log when trying to create a bookmark using the extension.

StatementError: invalid literal for int() with base 10: 'false' (original cause: ValueError: invalid literal for int() with base 10: 'false') u'INSERT INTO bmarks (hash_id, description, extended, stored, updated, clicks, is_private, inserted_by, username, tag_str) VALUES (%s, %s, %s, %s, %s, %s, %s, %s, %s, %s)' [{'username': u'jerome', 'updated': None, 'extended': u'', 'description': u'XIA', 'inserted_by': u'firefox_ext', 'tag_str': u'', 'is_private': u'false', 'hash_id': u'3ab797ff5caba6'}]

Instead of having to click the icon, I want to be able to use a kb shortcut.

When submitting an update we get review feedback on things that should be done to become a completely approved and searchable extension:

Comments:
Your preliminary review request has been approved.

Please note the following for the next update:

1. Your add-on prints debugging information to the Error Console, which is generally not allowed in production add-ons.

2. Due to both security and performance reasons, innerHTML (or similar method) should not be set using dynamic values. This can lead to security issues or fairly serious performance degradation.

For inserting text, textContent or createTextNode() should be used instead of innerHTML.
For inserting HTML, the safer method is to use createElement(), textContent, appendChild() instead of innerHTML.
Removing the innerHTML will improve add-on's prospect of approval.

Thank you.

Your add-on will now appear in search results and categories with some limitations. After 10 days you may request full review to remove these limitations and enable additional features. To learn more about the review process, please visit https://addons.mozilla.org/developers/docs/policies/reviews#selection

Otherwise, Bookie would not appear in search results of web browser.
https://addons.mozilla.org/en-US/faq#preliminary

As far as I am concerned, this whole process is probably a way to extort money from extension authors. bookieio/Bookie#577

This extension doesn't work at all in Firefox anymore.

console.error: bookie:
Message: Module sdk/widget is not found at resource://gre/modules/commonjs/sdk/widget.js
Stack:
CuddlefishLoader/options<.load@resource://gre/modules/commonjs/sdk/loader/cuddlefish.js:79:18

sdk/widget was Deprecated in Firefox 29 and removed in Firefox 38.
https://developer.mozilla.org/en-US/Add-ons/SDK/High-Level_APIs/widget

Well, title says it all.

I deleted my whole profile (it was a bit corrupted anyway) and added all my add-ons one by one to finally realise that it's that &?&(* setting's fault.

To me it's a deal breaker. I won't use Bookie until this is fixed. But keep up the good job :D

Anyway we could automate this process? rather than manually adding API key ?
Looking into it.

Say, I select a paragraph before I open the extension, I think it would be handy if that text populated the extended field.
There are instances when I'm adding a bookmark and the dialog blocks a portion of text that I want to include, I have no other option then to select the text (which closes the dialog) and then paste the text in there.

In the recent #8 PR, it added some duplicate code for managing preferences. One bit is that it opens this page on install & update (options.html), but it doesn't pull the existing prefs that are already saved.

It should be in sync with existing preferences so I can just hit "Save" as it opens this page everytime now.

1. click icon
2. enter stuff in the larger text box
3. click save

then

1. visit https://bmark.us
2. click edit link for newly saved bmark
3. notice empty "Extended" box

See description.

Doing a bit of digging, this appears because of the domain move causing an SSL cert error. The first request it makes returns with

bmark.us:443 uses an invalid security certificate.

The certificate is only valid for the following names:
  *.bookie.io, bookie.io  

(Error code: ssl_error_bad_cert_domain)

changing the "Bookie url" config to 'bookie.io' fixes the issue.

This is just to bring into attention that the latest version available at https://addons.mozilla.org/en-US/firefox/addon/bookie/
is not working properly.
But when i tried using :
make all
cd sdk
source bin/activate
cd ../
make run

from the clone in my system, it worked properly.
The version 0.5.0 was released on September 8, 2014 and I can see some fixes here after that.

So this is just a reminder to update the version at the mozilla site.
Thanks.