bonusly / gemojione Goto Github PK

For example, the banana emoji is an "object" when it should be in the category "foods". As is apple, bread, cake, candy, etc.

index.json for the latest commit: https://raw.githubusercontent.com/jonathanwiesel/gemojione/b922391b0a85cb6c35483eabbfeecb399246385c/config/index.json

Many definitions in the index.json have their moji property missing.

For example:

"airplane_arriving": {
  "unicode": "1F6EC",
  "unicode_alternates": [],
  "name": "airplane arriving",
  "shortname": ":airplane_arriving:",
  "category": "travel_places",
  "aliases": [],
  "aliases_ascii": [],
  "keywords": [
    "flight",
    "transportation",
    "vehicle",
    "plane",
    "airport",
    "travel",
    "airlines",
    "fly",
    "jet",
    "jumbo",
    "boeing",
    "airbus"
  ]
}

Should have a property "moji": 🛬.

It seems the png's in this gem are from the 4.5 distribution of emojione, which is not under a CC license, but can only be used for personal use unless an enterprise license is purchased. Please consider reverting to the 2.3 version.

I noticed this on the Readme:

Travis still points to the old URL.

• Gemnasium is shut down.
• Code coverage badge is missing.

Not sure if this is intentional, but these 39 emoji( all from regional category ) are missing.

["0023", "002a", "0030", "0031", "0032", "0033", "0034", "0035", "0036", "0037", "0038", "0039", "1f1e6", "1f1e7", "1f1e8", "1f1e9", "1f1ea", "1f1eb", "1f1ec", "1f1ed", "1f1ee", "1f1ef", "1f1f0", "1f1f1", "1f1f2", "1f1f3", "1f1f4", "1f1f5", "1f1f6", "1f1f7", "1f1f8", "1f1f9", "1f1fa", "1f1fb", "1f1fc", "1f1fd", "1f1fe", "1f1ff", "1f5e8"]

The punctuation of ' will be translated into it's character number： '
e.g. Gemojione.replace_unicode_moji_with_images "what's your name" will be translated into:
"what's your name"

"desert" keyword is returning emoji for the "dessert"

At the moment, gemojione provides a regex for matching all possible emoji short names. However, there is not a find_by_shortname method in the index. Could this be added?

I can file a pull request if asked, I've done it locally.

https://github.com/jonathanwiesel/gemojione/blob/ad4286531fb92cc44399b743ff51688115f7cb9f/config/index.json#L4026

Hey,

just saw that quite a lot emojis are missing in the index.json file. (Seems 162 are missing, unless I'm totally wrong. I compared with this file)

A few examples:

• zany_face
• hot_face
• cold_face

Is there a way to generate these, or do we have to add each emoji manually?

RubyGems says the SHA256 sum should be 7c2c938d64ced0ebed9e1ea842e3982bb88137530c38b2057bb69c752e1bde9f, but a gem fetch gemojione -v '3.0.1' will download a file with 6ab088a5dae3a04196d1059f067ea874aec124431b0dc05c262bfd5ef990685c checksum, which seems to be corrupted when installed, producing the following error:

Bundler::GemspecError: Could not read gem at
/usr/local/lib/ruby/gems/2.3.0/cache/gemojione-3.0.1.gem. It may be corrupted.
An error occurred while installing gemojione (3.0.1), and Bundler cannot
continue.
Make sure that `gem install gemojione -v '3.0.1' --source 'https://rubygems.org/'`
succeeds before bundling.

Unicode 9 definitions presented in #18 have no keywords (most of them).

We need to add keywords to them once source repo (Ranks/emojione) add them

Hi there,

Thanks for an awesome product.
Just wondering if there's plans to update to the latest version of Emojione / Unicode 10?

Thanks!

As mentioned in #18, adding this feature will improve emoji sorting inside each category.

As mentioned in joypixels/emojione#302 there seems to be an issue with the non-modifier image for this asset, its glasses shouldn't have reflexions.

Source repo has updated the png asset but not the svg, waiting to happen to update here.

Identified the following duplicates for the same unicode:

{
  "1F3D7": [
    "construction_site",
    "contruction_site"
  ],
  "1F51F": [
    "keycap_ten",
    "ten"
  ]
}

Some CDNs name the emoji image files with the downcased version of the emoji code, for example "1f61b" instead of "1F61B". Cloudflare is an example.

Even jsdelivr, which I was using, is failing for some uppercase codes, but working for the downcase version. Example: I get this url for :clown:: https://cdn.jsdelivr.net/emojione/assets/svg/1F921.svg, which gives me an "Access Denied" error, but the downcase version works normally: https://cdn.jsdelivr.net/emojione/assets/svg/1f921.svg.

Is this a problem with the CDNs or would it make sense to be able to downcase the codes in this gem?

Emoji One 2.2.4 was released the other day with the Unicode 9 emoji! Can we get an update with them?

http://emojione.com/releases/#2.2.4

The README currently states that the following lines should be added to serve the SVG image versions directly from the gem instead of having to add them to the application:

# config/application.rb
config.assets.paths << Gemojione.images_path
config.assets.precompile << "emoji/*.svg"

Gemojione.images_path returns the correct path within the gem (assets/svg), but it does not contain another directory named "emoji" - leading to the images not being precompiled / available in development.

Currently, this can be solved by removing the emoji directory name, but this of course leads to all assets being in the main assets namespace:

# config/application.rb
config.assets.precompile << "*.svg"

# config/initializers/gemojione.rb
Gemojione.asset_path = '/assets'

I'd like to load the images from the gem as I don't really want to add another 7MB to the application, but I'd prefer to still have them in their own namespace (as described in the README).

Did I simply do something wrong, is this a bug or the intended behaviour and the README just wasn't updated?

Thanks in advance and in general for this great gem!

Mojis added on a66c397 related to #8.

Would be useful to have a method to obtain an array of emoji definitions per keyword

When doing the unicode9 joining process, I identified a new definition:

{
  "gay_pride_flag": {
    "unicode": "1F3F3-1F308",
    "unicode_alternates": [],
    "name": "gay_pride_flag",
    "shortname": ":gay_pride_flag:",
    "category": "extras",
    "aliases": [
      ":rainbow_flag:"
    ],
    "aliases_ascii": [],
    "keywords": []
  }
}

However this asset is not present yet in the source repo.
See joypixels/emojione#274

When added, will add here

• heart_tip: https://gitlab.com/gitlab-org/gitlab-ce/issues/18343#note_12637818
• light_check_mark: https://gitlab.com/gitlab-org/gitlab-ce/issues/17575#note_12626947

Probably others, I'll update if I see any more.

what is the version of emojione in this repo?
I cannot find it.

I'm not sure if this is intended, but I was expecting that replace_named_moji_with_images would work with aliases too. My specific case is :robot_face:: its actual name is :robot: and :robot_face: is an alias. But when I call Gemojione.replace_named_moji_with_images(":robot_face:"), it returns ":robot_face:".

Looking at the source, I suppose it's because the regex used in this method (shortname_moji_regex) is generated from the Index's @emoji_by_code, and aliases are added to @emoji_by_name. Would it be acceptable if aliases were added to @emoji_by_code too? If so, I could make a pull request for that.

Thanks in advance 😄