bokeh / slickgrid Goto Github PK

Hi, I installed bokehjs module on vuejs:

• Installed BokehJS 2.4.3 using npm install @bokeh/[email protected]

• In the module where I want to embed the Bokeh plot: import { embed } from '@bokeh/bokehjs';

• To embed the plot after receiving a response from an Axios get request: embed.embed_item(response.data, 'myplot'); and include the JSX

  at the desired location.

However, I am getting this error on the browser:

ReferenceError: jQuery is not defined
    at node_modules/@bokeh/bokehjs/node_modules/@bokeh/slickgrid/slick.grid.js (slick.grid.js:19:11)
    at __require (chunk-HUBM7RA2.js?v=0bead79f:8:50)
    at node_modules/@bokeh/bokehjs/node_modules/@bokeh/slickgrid/index.js (index.js:4:20)
    at __require (chunk-HUBM7RA2.js?v=0bead79f:8:50)
    at data_table.js:5:35

Seems to be missing a comma here?

https://github.com/bokeh/SlickGrid/blob/bokeh%402.4.27/slick.core.js#L660

With current bokehjs version:

@bokeh/bokehjs 2.1.1

the slickgrid dependency is:

"@bokeh/slickgrid": "^2.3.23"

which is causing some problem with build

cc @mattpap

I've tried looking around for the historical reasoning behind forking SlickGrid since I've completely forgotten the discussion here. The 6pac fork of SlickGrid that this fork is based on is still actively maintained and has introduced a range of new features and bug fixes. More specifically this was forked at 2.3.7 but there have now been 2.3.7-2.3.23 and 2.4.0-2.4.27 releases on the original fork, i.e. this fork is 53 releases behind.

Since I'm missing context I have a few questions:

1. Why did we have to fork it in the first place?
2. Are there major obstacles to merging in all the changes from the original fork?
3. Are there any obstacles to switching back to the evidently quite well maintained original fork?

The main feature out of the original fork I'd like to see here are frozen rows/columns.

Cc: @mattpap @bryevdv