Git Product home page Git Product logo

Comments (6)

jamescummings avatar jamescummings commented on July 27, 2024

Ooops that should only be happening when there is a single persName inside the name element.

@holfordm: Is it the case that these attributes are always on the surrounding name rather than the persName? Or is there a chance they might be on both? i.e. is it ok if I just get rid of any attributes that might be on the existing persName when I turn the name into a persName? Or do I need to figure out how to merge the two sets of attributes?

from medieval-mss.

jamescummings avatar jamescummings commented on July 27, 2024

@holfordm It turns out there are only two originals where there is more than one element in a name with type='person'. These are:

  • Buchanan/Buchanan0002TEI_c1.xml
  • Canon_Class_Lat/Canon_Class_Lat_0109.xml

And I find no attributes on persNames that are inside names.

Hence, I'm going to not change those two above to persName (leave them as name with type=person) and assume I can move any name attributes to persName. Changing in script.

from medieval-mss.

holfordm avatar holfordm commented on July 27, 2024

from medieval-mss.

jamescummings avatar jamescummings commented on July 27, 2024

Just to note there is another side effect that will happen. There are cases where there is text separate from the persName elements such as:

<name type="person">Queen <persName>Elizabeth II</persName></name>

Which I'm proposing just becomes:

<persName>Queen Elizabeth II</persName>

I could, of course, leave persName embedded inside persName if you thought that better.

from medieval-mss.

holfordm avatar holfordm commented on July 27, 2024

from medieval-mss.

jamescummings avatar jamescummings commented on July 27, 2024

I believe this is done, so I'm closing it. re-open if it is still a problem.

from medieval-mss.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.