Git Product home page Git Product logo

Comments (4)

andrew-morrison avatar andrew-morrison commented on June 30, 2024 1

I've made changes to the logic for whether to display the numbering, and re-indexed the QA server. Now it will display numbers on works when there are different values for @n attribute on msItems at the same level (i.e. depth in the XML hierarchy.) So it won't display "1" for every work in a composite manuscript where each part has one work numbered "1". But it will display work numbers if the sequence continues across parts in all parts, or if any one part contains multiple numbered works.

Please take a look and close this issue if you're happy. It affects 488 records in Medieval. Attached is a list:

diff.txt

It does reveal some possibly incorrect numbering schemes that have previously been hidden. For example:

  • MS_Bodl_50.xml contains three msItem, numbered 1, 2, 1, in three parts.
  • MS_Bodl_514.xml contains nine msItem, numbered 1, 2a, 2b, 2c, 2d, 3, 4, 5, 1, in seven parts.
  • MS_Ashmole_794.xml contains five msItem, numbered 1, 2, 1, 1, 1, in five parts

from medieval-mss.

andrew-morrison avatar andrew-morrison commented on June 30, 2024

Have you had a chance to look at this change to numbering? If so, should I re-index PRD later today with changes to the XSLT, or the old version?

from medieval-mss.

adunning avatar adunning commented on June 30, 2024

I almost wonder whether we could simply do away with item numbers: do they serve any purpose when there are folio references? Sometimes people accidentally cite them, mistakenly thinking that they are a stable identifier, since earlier print catalogues sometimes used them this way.

from medieval-mss.

holfordm avatar holfordm commented on June 30, 2024

@andrew-morrison I'm afraid I didn't get a chance to look at it (apologies) and I'm currently without access to the QA site. I shall look at it early next week.

from medieval-mss.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.