Comments (24)
from imctools.
Hi there,
Sorry for the inconvenience!
I just updated the example notebook in https://github.com/BodenmillerGroup/ImcSegmentationPipeline/tree/development/scripts to not silently ignore errors but print the error message instead. Could you run this updated notebook and report the error that gets produced?
Thanks!
from imctools.
Thanks for the prompt responses @smaffiol @votti ,
I am using the ImcSegmentationPipeline-development,
I am running on a windows 10 system,
I setup imctools using the steps provided in the jupyter notebook under the cell the IMC preprocessing pipeline for multiplexed image analysis
The error occurs converting the zipped IMC acquisitions to input format,
I suspect something is wrong with the affiliated .txt files but I tried exporting a fresh batch from MCDViewer and checked hat they were similarly formatted to the example datasets
Here is the error,
ERROR:root:Error in ../../IMPx4/Human\1197344-13-2.zip
Traceback (most recent call last):
File "", line 11, in
File "C:\Users\dzamler\AppData\Local\Continuum\anaconda2\envs\imctools\lib\site-packages\imctools\scripts\convertfolder2imcfolder.py", line 57, in convert_folder2imcfolder
imc_fol.write_imc_folder(zipfolder=dozip)
File "C:\Users\dzamler\AppData\Local\Continuum\anaconda2\envs\imctools\lib\site-packages\imctools\io\imcfolderwriter.py", line 68, in write_imc_folder
self.mcd.save_slideimage(sid, out_folder)
File "C:\Users\dzamler\AppData\Local\Continuum\anaconda2\envs\imctools\lib\site-packages\imctools\io\mcdparserbase.py", line 284, in save_slideimage
with open(os.path.join(out_folder, fn_out), 'wb') as f:
OSError: [Errno 22] Invalid argument: '/Users/dzamler/Documents/OMEtiffsLogs\ometiff\1197344-13\1197344-13_s1_slide""'
Please don't hesitate to let me know if you need anything else,
Cheers,
from imctools.
Cool! That helps a lot.
@.txt files: in the end they are just used as a backup in vase if the mcd is corrupted - something that would happen often back in the days. They are optional nowadays - I will try to reflect thia better in the description.
It seems like an issue with how a file path is constructed in a non Windows conform way - I will need to investigate a bit more and et you know if I need more infos.
from imctools.
Were any files generated in the folder: /Users/dzamler/Documents/OMEtiffsLogs\ometiff\1197344-13
at all?
from imctools.
@votti I thought that might be a problem originally as well, but it works with the example dataset, unless zipping the files on windows caused some sort of difference
here is the contents of the folder
Directory of C:\Users\dzamler\Documents\OMEtiffsLogs\ometiff\1197344-13
12/20/2018 11:01 AM
.12/20/2018 11:01 AM ..
12/20/2018 11:03 AM 1,868 1197344-13_AcquisitionChannel_meta.csv
12/20/2018 11:03 AM 78 1197344-13_AcquisitionROI_meta.csv
12/20/2018 11:03 AM 1,337 1197344-13_Acquisition_meta.csv
12/20/2018 11:03 AM 808 1197344-13_Panorama_meta.csv
12/20/2018 11:03 AM 763 1197344-13_ROIPoint_meta.csv
12/20/2018 11:03 AM 289,397,586 1197344-13_s1_p1_r1_a1_ac.ome.tiff
12/20/2018 11:03 AM 292,097,970 1197344-13_s1_p2_r2_a2_ac.ome.tiff
12/20/2018 11:03 AM 292,579,506 1197344-13_s1_p3_r3_a3_ac.ome.tiff
12/20/2018 11:03 AM 35,301 1197344-13_schema.xml
12/20/2018 11:03 AM 260 1197344-13_Slide_meta.csv
10 File(s) 874,115,477 bytes
2 Dir(s) 342,671,175,680 bytes free
from imctools.
from imctools.
Ah I think I see what the problem is:
Somehow the file ending of the encoded slide image filename is parsed wrongly to be ""
.
To better understand why this is: could you copy-paste what the entry ImageFile
in the 1197344-13_Slide_meta.csv
file is? (in the C:\Users\dzamler\Documents\OMEtiffsLogs\ometiff\1197344-13
folder)
from imctools.
Some of the ome.tiff files channels look okay but some appear to be inverted as far as black and white.
ImageFile =
""
from imctools.
@Imagefile: I think that is the reasons for the SlideImage
failing - the instead of having a real empty filename the Mcd contains a ""
as the filename - this can be easily fixed.
Some of the ome.tiff files channels look okay but some appear to be inverted as far as black and white.
If true that would be quite worrisome - what kind of image viewer do you use to check if they are valid?
I really would recommend using ImageJ/Fiji to look at the images.
If somehow possible at this point it would be likely easiest you could give me access to an example zipped .mcd file, such that I could check if there is something unusual there.
from imctools.
should I just change the name in the meta .csv? I have no problem providing access what would be the best way?
from imctools.
Changing the name in the 'meta.csv' would not change anything. It really needs a quick fix in the code.
But as said, in the all the relevant parts of the data are already parsed at the time of the error, so this does anyway only affect some metadata images that are likely not so relevant for analysis.
For sharing, please share the zipped .mcd data as well as a zipped version of your ometiff
output folder by uploading them to something like Dropbox/Google Drive and send me the link per email. I can also provide you a link to a secure platform from our University to upload if you prefer that.
My email is [email protected]
Cheers!
from imctools.
from imctools.
from imctools.
Hi!
It is important that all the channels that are in the pannel.csv
and selected for a analysis stack (e.g. either full
or ilastik
) were actually present in your acquisition. According to the error, some of your acquisitions do not contain measurements for Ru100
or Nd148
, which causes these errors. Thus you need to adapt your pannel.csv
to fit the actual acquisitions that you did. Does that make sense?
I will note down that these error messages should be improved.
from imctools.
from imctools.
Hey there!
I reallized that currently there is no real expaination of the pannel.csv
- I thus updated the example scripts with comments (in the section where the pannel.csv is first used):
https://github.com/BodenmillerGroup/ImcSegmentationPipeline/blob/development/scripts/imc_preprocessing.ipynb
I hope that helps!
In the end the pannel.csv should really reflect the channels/antibodies that were used for the acquisition - thus I would rather remove channels you did actually not measure.
from imctools.
from imctools.
I assume everything worked?
from imctools.
from imctools.
Hi @votti
I'm having a similar problem using our own data with the panel.csv file. Even after adjusting the panel file for our own antibody panel we encounter the below error. I'm not sure why we would be getting the 'Ru102' and 'Ru100' key errors occuring after these were deleted from your base panel. I did verify that we included all the appropriate channels associated with the MCD file.
Thanks
from imctools.
Hi @veenstje,
could you check please imctools
version that is installed?
Best regards,
Anton
from imctools.
from imctools.
Thank you both Anton and Vito for your quick responses. After further investigation I found that I was adjusting the wrong panel.csv file (the one in the cpout folder instead of the correct file in the config folder). I am now able to complete the pipleline. Thank you!
Have a wonderful day
Jesse
from imctools.
Related Issues (20)
- extract panorama HOT 4
- Make exceptions discoverable in API HOT 3
- Extra 161 bytes extracted on all image buffers HOT 1
- TxtParser and McdParser should share a common base class
- Wrong ROI coordinates for new Fluidigm software versions HOT 4
- Create imctools.data.Acquisition object without loading image data when using TxtParser
- Feature request: option to export additional columns in omefile_2_analysisfolder HOT 4
- KeyError: 'Name' HOT 11
- ValueError: invalid literal for int() with base 10: HOT 1
- Broken assertion HOT 3
- ome2histocat stripps .tiff file ending from masks HOT 2
- Value Error: No session JSON files available HOT 3
- Error while running IMCtools HOT 4
- Generated OME-XML in OME-TIFF files is not schema compliant due to out-of-order AcquisitionDate element HOT 3
- broken link to xml namespace HOT 1
- imctools.scripts HOT 2
- Typo in method omexml.py HOT 2
- Inquiry about omexml.py related to schema location HOT 2
- NotADirectoryError: [Errno 20] Not a directory: '../../data/ometiff/.DS_Store/.DS_Store_Acquisition_meta.csv' HOT 4
- Adding clear specification of the 'ome' folder HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from imctools.