Git Product home page Git Product logo

learn-css-variables's Introduction

Learn CSS Variables

A short intro to using CSS variables to control colour.

a GIF screengrab showing night mode being toggled on and off on a webpage

The Challenge

The aim of this challenge is to learn how to use CSS variables to control colour in websites/web apps.

We'll be implementing the default colour palette using CSS variables.

Getting Started

Clone this repo and open style.css. Your task is to:

  • Declare CSS variables that will apply the default light colour palette show in the screengrab above to index.html.

Stretch Goal

Open index.html and look for the switchTheme function inside the <script></script> tags. Add logic to the if and else blocks that will:

  1. Select the CSS variables you've defined in the style.css file, and...
  2. ...change their values to make a dark mode colour palette!

Try to make sure your text and background colour contrast remain accessible. There are contrast checking tools that can help.

learn-css-variables's People

Contributors

bobbysebolao avatar

Watchers

avatar avatar

Forkers

clickmcr karyum sbhatti534602210 elenamarinaki cerealenjoyer

learn-css-variables's Issues

Toggle CSS class instead of each individual property

learn-css-variables/solution/index.html

Lines 70 to 73 in 099a053

document.documentElement.style.setProperty(
"--primary-colour",
"#9a97f3"
);

It's quite a lot of work to define and toggle every single variable in the JS. It also requires duplicating every variable in both the CSS and JS (adding new ones later would get annoying to manage)

I think it would be more future-proof to get them to toggle a className on the root and then define all the darkmode variables in the CSS.

E.g.

:root {
  --text: #000;
}

.dark {
--text: #fff;
}
function switchTheme(e) {
  document.documentElement.classList.toggle("dark"); // this would work on document.body too
}

Add an empty selector placeholder

It might be clearer for people who haven't written any CSS variables before to give them an empty placeholder selector that they're supposed to write into

:root {
  /* variables go here */
}
...

<body class="dark"> in index.html

The base index.html contains <body class="dark">, is this intentional?

It was confusing and the class had be removed from the body for the code to work correctly (as per your gif). i.e the page loads in light mode, the switch is toggled and it turns dark.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.