Git Product home page Git Product logo

Comments (4)

bobbingwide avatar bobbingwide commented on June 20, 2024

I'll tabulate the usage of _sc_classes() so we can see what the id= parameter is for each shortcode.

plugin shortcode usage
oik-shortcodes apis id parameter ignored
oik-shortcodes blocks id parameter ignored
oik-shortcodes classes id parameter ignored
oik-shortcodes codes id parameter ignored
oik-shortcodes files id parameter ignored
oik-shortcodes hooks id parameter ignored
oik-user bw_contact_user Is this shortcode ever used? id parameter ignored
oik div for id= parameter to div tag
oik sdiv for id= parameter to div tag
oik stag for id= parameter to chosen tag
oik bw_attachments uses ID to identify posts
oik bw_pdf uses ID to identify posts
oik bw_portfolio uses ID to identify posts
oik bw_images uses ID to identify posts
oik bw_contact_form id parameter ignored
oik bw_iframe id= parameter on iframe tag
oik bw_link post ID
oik bw_pages post ID should take priority - syntax wrong therefore
oik bw_posts post ID should take priority - syntax wrong therefore
oik bw_table post ID should take priority - syntax wrong therefore
oik bw_thumbs uses ID to identify posts

Some code uses ( e.g. oik-attachments.php )

$syntax += _sc_classes();

other code ( e.g. oik-pages.php ) uses

$syntax = array_merge( $syntax, _sc_classes() );

from oik.

bobbingwide avatar bobbingwide commented on June 20, 2024

proposed solution. change calls using array_merge to the concat version.

add parm to _sc_classes to not add id when false

from oik.

bobbingwide avatar bobbingwide commented on June 20, 2024

Note: The [bw_cycle] and [bw_popup] shortcodes are affected by changes to bw_pages__syntax

from oik.

bobbingwide avatar bobbingwide commented on June 20, 2024

Oik v4.0.0 has been released. The shortcode syntax documentation should reflect the changes. There may still be orphaned shortcode parameter posts. To properly close this off I should update oik-shortcodes and check the status of bw_contact_user.

from oik.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.