Git Product home page Git Product logo

Comments (7)

bobbingwide avatar bobbingwide commented on June 23, 2024

Couple of other things:

  1. Remove the texticon logic for LinkedIn dashicon. It seems to work now.
  2. Change the [github] shortcode to use the GitHub SVG icon instead of the dashicon.
  3. Find the best way to use the functions that were originally implemented in oik-bob-bing-wide.

from oik.

bobbingwide avatar bobbingwide commented on June 23, 2024

Change the [github] shortcode to use the GitHub SVG icon instead of the dashicon.

This shortcode's part of oik-bob-bing-wide

from oik.

bobbingwide avatar bobbingwide commented on June 23, 2024

Find the best way to use the functions that were originally implemented in oik-bob-bing-wide.

Implement as a shared library class OIK_SVG_icons in libs/class-oik-svg-icons.php

from oik.

bobbingwide avatar bobbingwide commented on June 23, 2024

Update the logic so that [bw_twitter @something] or [bw_twitter #something] defaults to using theme=svg.
Also support displaying the target parameter when the value for theme is not dash, gener or svg. ie. for the icon.

from oik.

bobbingwide avatar bobbingwide commented on June 23, 2024

I've added the SVG option to the Theme drop down for the Follow me block but when it's set to SVG and you go away and come back to the block the value reverts to None. Why's that?

from oik.

bobbingwide avatar bobbingwide commented on June 23, 2024

When [bw_follow_me] is used with theme=svg for SVG icons the inline CSS is only enqueued when the [bw_post] or [bw_page] shortcode has also been used.
The logic for [bw_follow_me] doesn't call bw_dash() so bw_dash_inline_style_svg() isn't run.

Proposed solution

copy bw_dash_inline_style_svg() to OIK_SVG_icons::inline_style_svg()

from oik.

bobbingwide avatar bobbingwide commented on June 23, 2024

Fixed in 4.8.0, released in 4.8.1

from oik.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.