Comments (7)
Couple of other things:
- Remove the texticon logic for LinkedIn dashicon. It seems to work now.
- Change the
[github]
shortcode to use the GitHub SVG icon instead of the dashicon. - Find the best way to use the functions that were originally implemented in oik-bob-bing-wide.
from oik.
Change the [github] shortcode to use the GitHub SVG icon instead of the dashicon.
This shortcode's part of oik-bob-bing-wide
from oik.
Find the best way to use the functions that were originally implemented in oik-bob-bing-wide.
Implement as a shared library class OIK_SVG_icons
in libs/class-oik-svg-icons.php
from oik.
Update the logic so that [bw_twitter @something]
or [bw_twitter #something]
defaults to using theme=svg
.
Also support displaying the target parameter when the value for theme is not dash
, gener
or svg
. ie. for the icon.
from oik.
I've added the SVG option to the Theme drop down for the Follow me block but when it's set to SVG and you go away and come back to the block the value reverts to None. Why's that?
from oik.
When [bw_follow_me]
is used with theme=svg
for SVG icons the inline CSS is only enqueued when the [bw_post]
or [bw_page]
shortcode has also been used.
The logic for [bw_follow_me]
doesn't call bw_dash()
so bw_dash_inline_style_svg()
isn't run.
Proposed solution
copy bw_dash_inline_style_svg()
to OIK_SVG_icons::inline_style_svg()
from oik.
Fixed in 4.8.0, released in 4.8.1
from oik.
Related Issues (20)
- Shortcodes not expanded in `term_description` HOT 5
- Default `show_in_nav_menus` to false if not set HOT 1
- Warning on oik options > plugins Add new HOT 1
- bw_get_posts() - Add support for post_name attr HOT 2
- [bw_pages] - dynamic blocks not being rendered HOT 1
- Update to the latest @wordpress/scripts package and rework as required HOT 5
- Warning: Invalid DOM property `fill-rule`. Did you mean `fillRule` ? HOT 2
- Contact form: add additional fields such as telephone HOT 25
- Blocks not registered in oik downloaded from WordPress.org HOT 1
- Memory exhausted while running PHPUnit tests for oik on s.b/wordpress HOT 1
- Consider making [bw_accordion] front end more accessible HOT 1
- Test compatibility with WordPress 6.3 HOT 4
- Update to the latest @wordpress/scripts package HOT 7
- Add translators comments to shared library files HOT 1
- Support PHP 8.1, PHP 8.2 and PHP 8.3 HOT 6
- Spammers submitted hundreds of forms recently HOT 3
- Update PHPUnit tests for WordPress 6.4 HOT 3
- Cater for phone shortcodes when Mobile phone entered but not Home phone?
- Update retlink() to prevent JavaScript in URLs HOT 1
- Fatal error attempting to view bw_plug link parameter in s.b/oikcom HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oik.