Comments (7)
Yeah, agree 💯. I recently implemented this kind of thing over in entrofy, so it wouldn't be hard to do.
from muda.
so thoughts on the PipelineFactory and Pipeline objects? PipelineFactory is the iterator that yields a Pipeline, which can then be passed a data object to deform. or do you see a simpler approach?
from muda.
Well, if you're reconstructing a deformation pipeline from a muda output, it only has to generate a single example. Parameterizing each element of the pipeline according to its seed (and state number) ought to suffice, so we shouldn't need to generate multiple pipeline objects.
from muda.
I'm thinking of the scenario where I generate one pipeline and want to apply it to different audio-jams objects ... to do this currently, I have to keep making new Pipelines with n_samples=1
. Intentionally having singleton iterators seems like a design smell, no?
from muda.
I'm thinking of the scenario where I generate one pipeline and want to apply it to different audio-jams objects
Different meaning totally different content? If that's the case, why would you care about porting over random parameters?
If you want to reinstantiate a pipeline, random seeds and all, that can be done with the current serialization code (properly extended to include seeds).
from muda.
Coming off of the discussion in #62, it seems like the more useful version of this idea is to reconstruct a specific deformation sequence from a previous run of muda. This is useful when you have the original audio, deformed jams, and want to rebuild the corresponding deformed audio.
I'm having a hard time thinking of any other reproducibility use cases that can/should be powered by the deformation history of individual outputs.
I specifically don't see the utility in reconstructing a muda pipeline from an output's deformation history. Given the interactions between union, bypass, and pipeline, I'm not sure this is even possible: you'll only get the deformers that actually executed to form this output, not the actual deformation stack. I think encouraging folks to try to abstract up from an instance to the pipeline is an anti-pattern; instead, we should encourage folks to save their pipeline objects alongside the outputs if they want to run further deformations on new data.
So I suggest this issue be consolidated into two enhancements:
- Implement the audio re-deformer, as described in #62. This is a minor-revision change.
- Add rng seeds to all randomized deformer objects so that serialized pipelines can reproduce exactly. This is a major-revision change.
These two enhancements are independent. Because the deformation history never records randomized objects (only their deterministic parent class), and all state is preserved in the history, you can get reproducibility of randomized deformations for free even without storing the seed. (This, of course, is just for audio re-deformation, not for re-running a deformation sweep on a dataset.)
@ejhumphrey @justinsalamon what do yall think?
from muda.
+💯 for re-deformer, indeed it appears #62 surfaced precisely because I shared MUDA jams files (https://github.com/justinsalamon/UrbanSound8K-JAMS) to avoid having to distribute the augmented version of US8K we were using in our paper for reproducibility.
Happy to put together a PR, but no cycles in the near horizon :'(
from muda.
Related Issues (20)
- Add explicit int cast in pitch.py HOT 1
- Switch from nose to py.test HOT 1
- Drop sklearn dependency
- Deformation union HOT 1
- OSError: [Errno 2] No such file or directory HOT 6
- Errors in tests HOT 1
- Support passing jams kwargs to muda's load/save functions HOT 2
- Remove in-place annotation modification HOT 3
- BackgroundNoise fails if len(soundf)==n_target HOT 4
- How to apply deformations from annotated jams file? HOT 7
- Can I load a wav file without JAMS? HOT 4
- Running Error on Spyder in windows 10 HOT 2
- External dependency I/O overhead for out-of-core pipelines HOT 5
- Getting TypeError: expected string or buffer HOT 1
- Cannot save jams with random seeds
- Future-proofing against deprectations
- Old jams BackgroundNoise lacking start and stop HOT 3
- Modernization
- ColoredNoise deformer bug HOT 1
- Tapdancing (use pedalboard as backend)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from muda.