BackgroundNoise fails if len(soundf)==n_target about muda HOT 4 CLOSED

Yes, I will write a PR later today.

from muda.

Yup, that makes sense, thanks for catching it! We recently hit almost the same issue over in pumpp, so it's not too surprising. Do you have any interest in doing a PR for this?

from muda.

On second thought, this looks more like an off-by-one error.
The fix would then be:

start = np.random.randint(0, 1 + len(soundf) - n_target)

That would be a breaking change, though.

from muda.

That would be a breaking change, though.

That's fine -- it's broken as is. I bumped the milestone for this to 0.2, so it's okay to not be backward-compatible with the 0.1 series.

from muda.