Comments (4)
Currently, JAMS objects are being used via the top-level sandbox to ferry data through deformation pipelines. This is a little clunky for a few reasons, some more obvious than others. For my part, a big one is transforming JAMS without audio / transforming audio without JAMS.
Transforming jams without audio is technically no problem, though I forget if it actually works. (I think it should.)
Transforming audio without JAMS is also possible, in that you can have the jams pipe construct a dummy jams object.
I'd be keen to encapsulate audio and annotation data as separate attributes of a Payload object (or what have you) that can pass through the deformer pipeline agnostically. Putting some smarts into the different containers will also make it easier to introduce other audio deformations later, like stereo / spatialization, and keep good records on applied deformations.
This will need some thought, but I'm not totally opposed to it in principle.
And, as another win (in my book at least), it could allow us to leverage different audio reading/writing backends, which can be justifiable in different scenarios.
Ehhhhh i think we should just use pysoundfile for everything. Given everything else that it offers, I'm content to drop mp3 support.
from muda.
Transforming audio without JAMS is also possible, in that you can have the jams pipe construct a dummy jams object.
yes, but you have to make sure you set jam.file_metadata.duration
or things go to hell for time-stretching.
Ehhhhh i think we should just use pysoundfile for everything. Given everything else that it offers, I'm content to drop mp3 support.
At the risk of sparking a holy war, some scenarios justify using a sox
or ffmpeg
backend. If we're encapsulating things properly, I don't think it has to be gross.
from muda.
yes, but you have to make sure you set jam.file_metadata.duration or things go to hell for time-stretching.
That's easy enough.
At the risk of sparking a holy war, some scenarios justify using a sox or ffmpeg backend.
I'm curious what those scenarios are. If we're writing audio, I feel okay forcing people to use ogg, flac, or wav, which don't require ffmpeg. The big win here comes down to dependency management -- I want to absolutely limit the number of non-python dependencies we have to deal with. Zero would be ideal.
Reading audio is another story, and if we want to support mp3, we're kinda stuck with the pile of hack that audioread abstracts away from us. We shouldn't reinvent that functionality. If we don't care so much about mp3, then pysoundfile all the way.
(I'm totally baffled as to why you would want to output to sox though.)
If we're encapsulating things properly, I don't think it has to be gross.
The implementation could be totally pristine, but the dependency management will bite us every time. I'm more than happy to let audioread and/or libsndfile handle codec business.
from muda.
Closing this out, as I think the current containers are here to stay.
from muda.
Related Issues (20)
- Add explicit int cast in pitch.py HOT 1
- Switch from nose to py.test HOT 1
- Drop sklearn dependency
- Deformation union HOT 1
- OSError: [Errno 2] No such file or directory HOT 6
- Errors in tests HOT 1
- Support passing jams kwargs to muda's load/save functions HOT 2
- Remove in-place annotation modification HOT 3
- BackgroundNoise fails if len(soundf)==n_target HOT 4
- How to apply deformations from annotated jams file? HOT 7
- Can I load a wav file without JAMS? HOT 4
- Running Error on Spyder in windows 10 HOT 2
- External dependency I/O overhead for out-of-core pipelines HOT 5
- Getting TypeError: expected string or buffer HOT 1
- Cannot save jams with random seeds
- Future-proofing against deprectations
- Old jams BackgroundNoise lacking start and stop HOT 3
- Modernization
- ColoredNoise deformer bug HOT 1
- Tapdancing (use pedalboard as backend)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from muda.