Git Product home page Git Product logo

Comments (11)

bluwy avatar bluwy commented on June 16, 2024 2

0012a81 should implement this and will release the site later tonight. Closing this for now.

from publint.

bluwy avatar bluwy commented on June 16, 2024 1

Awesome. Yeah I tried with select first too, but unfortunately when we lazily fetch the options, Safari doesn't update the list automatically. It was also hard to style it, so I went with the manual select implementation.

from publint.

btea avatar btea commented on June 16, 2024 1

The new site style looks so cool! 👍

from publint.

bluwy avatar bluwy commented on June 16, 2024

Hi, do you mean the publint version, or the package version? Changing the publint version is a little tricky since there are code shipped to specifically handle a version of publint, e.g. converting the results to human-readable messages.

If you mean the package version, that's definitely a welcome change! I actually experimented that a bit last week, but it's hard to get the design right. I could also push the wip branch up for reference.

from publint.

btea avatar btea commented on June 16, 2024

Yeah, I mean the package version. My current idea is to get all the versions directly through the jsdelivr API.

For example, get the vite version, https://data.jsdelivr.com/v1/package/npm/vite

from publint.

bluwy avatar bluwy commented on June 16, 2024

Sounds great, feel free to send a PR if you'd like. I can also push my branch later when I get to my laptop, but it's a bit outdated now.

I'm currently working on some design touch ups to the site locally that's no published yet, in case you're seeing some things different.

from publint.

bluwy avatar bluwy commented on June 16, 2024

Here it is: https://github.com/bluwy/publint/tree/switch-version. It's actually kinda almost there I think, but needs a little polishing.

from publint.

btea avatar btea commented on June 16, 2024

I tried it and it looks amazing! 👍

However, there is a little problem, when the version is switched, there will be page switching flashing, which does not look so smooth.

publint

from publint.

bluwy avatar bluwy commented on June 16, 2024

Yeah I noticed that too. I don't know why it's doing that and hopefully doesn't happen much in prod. That could use some polishing.

Feel free to work on top of the branch if you'd like, but if not no worries too. I'm working on a whole site improvement and will also take on that feature in a couple days if not.

from publint.

btea avatar btea commented on June 16, 2024

I'm relatively new to Sevelte. I tried a similar effect directly using the select tag locally, and the above situation does not occur when switching. I found that you added a new component PackageVersion.svelte, perhaps because of it?

Since my local logic is written directly in the Package.svelte component, there is this guess. 🤔

You're making overall improvements to the site, and I think it's better to keep your rhythm, so I'm not going to make changes, but I'll keep looking at the code.

from publint.

btea avatar btea commented on June 16, 2024

The compatibility handling of native select is a real headache. 🤦‍♂️

from publint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.