Comments (8)
Is there a reason you publish tests?
from publint.
Yes, because since time immemorial, npm explore foo && npm install && npm test
is supposed to work, so that you don't need an internet connection to run your deps' tests. That it's become fashionable not to publish tests doesn't change that.
Either way, that's the way all 450+ of my packages are built, and I'd love to use this tool without having to wade through these "suggestions".
from publint.
Thanks for the explanation. I've not quite used this workflow before, but it still feels like a rare thing to do these days, and I'm not sure if it's fair for users to pay the bandwidth price upfront for this.
At most they'd only patch a certain piece of code regardless of tests to get it work. And if they're considering submitting a fix, they'd need to clone it down anyways.
Also wouldn't npm install
still require a network connection?
from publint.
Nope, npm install
works from cache.
Regardless, I'm not asking to change the default, I'm asking for a command line option so i can skip it.
from publint.
You can use --level warning
to only log warnings and errors.
from publint.
I don't want to hide all suggestions, just this specific one.
from publint.
At the moment I don't have plans to support ignoring certain messages yet.
from publint.
Closing this for now as I'd like the library to be more opinionated on certain practices, but I might revisit a more fine-grain ignore option once I figure a plugin implementation for the library, which then ignoring certain "rules" like eslint could be more useful.
from publint.
Related Issues (20)
- Suggest avoiding UMD for CJS only packages HOT 1
- Warning message displays error HOT 2
- "module": true -- crash
- "module": "" -- "All good!" from publint HOT 4
- Incorrect pkg.main ESM detection
- [bug] .cjsx is not okay. Error message says it should be renamed to .cjsx HOT 5
- Suggest using pkg.files HOT 2
- Suggest "internal resolution error" for types wrongly declared from a TS point-of-view (node native esm) HOT 1
- wrong error for "main" HOT 6
- suggest "npmignore or files" instead of just files HOT 4
- Suggest adding `"type"` field to all packages HOT 3
- Monorepo support HOT 1
- Check if root is exported through mainFields but not exports
- API endpoint to analyse remote packages HOT 2
- Warn on the usage of fallback arrays in the `exports`/`imports` field
- feature requerst: badges like shields.io HOT 1
- Upgrade warning to error HOT 1
- File existence checks does not work on exports of non-js files HOT 5
- [NEW RULE] Check "repository.url" value HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from publint.