blue-santa / komodo-docs-vuepress Goto Github PK

In https://github.com/siddhartha-komodo/komodo-docs-vuepress/blob/master/docs/basic-docs/installations/basic-instructions.md there is a <aside class="notice"> being called, but I think class="notice" is not defined.

taddr, prefix, prefix2, and deposit are all potentially inaccurate.

https://siddhartha-komodo.github.io/komodo-docs-vuepress/basic-docs/cryptoconditions/cc-gateways.html#gatewaysinfo

So, we need to edit it around 14th December.
Also API related to Z-txns will need changes after sapling update. They are in wallet.md, util.md

Opening an issue how was proposed in discord discussion:

I've tested all non-CC komodo-cli calls from komodo-cli help https://docs.google.com/spreadsheets/d/167KG3kRQi1ZaVXqkHv_wKClxq4z-sZoI7MCArpWROMA/edit?usp=sharing
Some of the calls seem to be very new and non-persists at all (even with "Coming soon" status) in API documentation https://docs.komodoplatform.com/komodo/komodo-API.html which I've used as help for this test. I've marked such calls in "Comments" column - maybe will be helpful for documentation updating

Once we have all these issues resolved and deployed to master and gh-pages, we'll then move everything to https://github.com/KomodoPlatform/resources

After this, we're going to set up a new subdomain, developer.komodoplatform.com, that will allow us to use full urls for our docs.

So far so good, gcharang.

I've found a workaround for making changes locally, so that helps a lot.

Here's one question:

number |(numeric) |the transactions before this one (by 1-based index in "transactions" list) that must be present in the final block, if this one is

The description is a little unclear, and it also has parantheses in the middle of the thought.

Can you try rewriting this so that the meaning is more clear and any side information is given afterwards, and preferrably in a proper sentence instead of parens?
Here is another such case, also in the mining.md file. Can you please work on the phrasing and remove the need for parentheses?

|the priority to add or subtract (the transaction selection algorithm assigns the tx a higher priority; (transaction priority calculation: coinage * value_in_satoshis / txsize))
Another case:

only the algorithm for selecting transactions into a block considers the transaction as it paid a higher (or lower) fee.
siddhartha-komodoToday at 2:16 PM
The gettransaction method in the wallet.md file has a few arrays that need a bit more description in the type column. Can you please take a look at that?
siddhartha-komodoToday at 2:24 PM
Another thing to address.

In this sentence here:

They all form a cluster with the same N value where the base tokens in all the chains in that cluster are fungible via the burn protocol.

Who is "they"? Is it the notary nodes? The pubkeys? The asset chains? Need to be specific.

I rewrote to this:

All asset chains that has the same ac_cc value form a cluster, where the base tokens of all the chains in the cluster are fungible via the burn protocol.
I'm putting all of these notes in an issue so they're easier to track.