Hey, I'm new to C# and to coding so be kind if my question is not pertinent.
I know that Riot Games request limit is 20 requests per second.
I'm getting sometimes a "TooManyRequestsException, and my program is only getting matchlist (very small program).
I'm having this issue while using the ListIdsByPuuidAsync while working with League of Legends API.


I think that the issue is caused by the Count parameter because when there are only 5 or 10 matches to retrieve, there is no problem, but when I ask up to 100 matches, the issue happens
I don't have yet the C# skills to see the source code on my own deeply so idk but this issue don't happen with other Api's packages (like in Python), so I just wanted to know if it's just a normal behavior, and the Riot request limit is normal.
Thanks a lot for your great work 🙌👍

Legends of Runeterra

• ➖ Lor-Deck-v1
• ➖ Lor-Inventory-v1
• ➖ Lor-Match-v1
• ➖ Lor-Ranked-v1
• ➖ Lor-Status-v1

Would be totes nice to have for the library. 💜

Teamfight Tactics

• ➖ Tft-League-v1
• ➖ Tft-Match-v1
• ➖ Tft-Status-v1
• ➖ Tft-Summoner-v1

Would be nice to have this added to the library. 💚

Riot has announced a new ranked tier for League of Legos that will be introduced in the next split.
https://www.leagueoflegends.com/en-us/news/game-updates/what-s-next-for-ranked/

This should probably be added before July 18-ish.

Valorant

• ➖ Val-Content-v1
• ➖ Val-Match-v1
• ➖ Val-Ranked-v1
• ➖ Val-Status-v1

Unsure of how to go about adding these without testing.

This includes:

• Account-v1
• Summoner-v4
• Tft-Summoner-v1
• Lor-Deck-v1
• Lor-Inventory-v1

Almost there to being feature complete!

This should make it possible to use the RSO endpoints manually~* :D

Looks like I made an oversight when creating these methods...

Just like GetAsync for the Riot interface but for CommunityDragon~

So something like this, wah!

byte[] challengeIcon = await client.CommunityDragon
    .GetAsync<byte[]>("/latest/game/assets/challenges/config/00_crystals/challengecrystal_platinum.png");

I think the current spread limiting strategy for AlgorithmicLimiter can be improved upon. With how it works currently, it is set to be overly safe for the delay coefficient (3 * Math.Pow(progress, 2)). Unfortunately, a small percentage of requests (~0-5%) for a given limit is left unused. u.u

It works for now but it can probably be changed for the better. Setting the delay coefficient any lower will just trigger the WarningLimiterException (for smaller or larger rate limits I don't remember...), not what we wantsies.

See lines of code.

I think it may be time to use inheritance for current/future non-behavior features anyways... ⁄(⁄ ⁄•⁄-⁄•⁄ ⁄)⁄

All record objects under the Dto namespace currently use the compiler-generated ToString method. So this is what it currently looks like dayo~

The current ToString can print nested objects but not if the object is from the System.Collections namespace. There is also no indenting so it can be quite fugly. ( ´•̥ו̥` )

I think the ToString override should pretty much print all nested objects with some indentation. Maybe also provide a helper method the user can use to generate a pretty string? This would cover the challenge percentiles dictionary shown above (the last printed object)!

I have recently been rereading how Java enums work and inspecting the orianna library. Would be totes spectacular to increase the usability of enums and types like Platform, Region, etc. by making them easier and more powerful to use with the C# toolset.

Examples

Soon:

// => "na1"
Platform.NorthAmerica.GetId();
// => "en_US"
Platform.NorthAmerica.GetDefaultLocale();
// => "americas"
Platform.NorthAmerica.GetRegionId();

Now:

// => "na1"
PlatformMapper.GetId(Platform.NorthAmerica);
// no current equivalent

// => "americas"  this is totes ugly :c
RegionMapper.GetId(PlatformToRegionConverter.ToRegion(Platform.NorthAmerica));

Quickstart

• Add some data fetching walkthroughs for Teamfight Tactics and Legends of Runeterra (I can't really make one for VALORANT without access)

API Interfaces

• Include the sub-interfaces for IRiotApi

Using for ASP.NET Core

• Provide an example setup when using RiotBlossom with an ASP.NET Core project

I want to at least improve and expand on the current documentation before releasing 1.1.0! _{^{lol it is just a README why are you doing this, silly girl}}

I really don't know how to go about adding API documentation without generating...

For the Riot APIs, it is close to 1-to-1 with the official Riot Developer Portal but aaaaaaaa.

I can't decide if I should add more Markdown documentation files under this repository or just make static GitHub pages.

It looks like Mister Riot Games recently changed teamId to queueId for the schema. I'm going to wait and see if this is intended or not before proceeding with a change. u.u

MingweiSamuel/riotapi-schema@44f7b94#diff-33a82c6fdb2653a6f2b66c9aa83f88db5dfa2eee8d2bf97521797a168f6a3387R14342

This library currently only supports rate-limiting requests via burst (see Middleware.BurstShaper). It would be nice to have a functional class that is able to spread out requests while respecting the parsed rate limits.

This is the Middleware.SpreadShaper class currently:

namespace BlossomiShymae.RiotBlossom.Middleware
{
    internal class SpreadShaper : IShaper
    {
        public Task UseRequestAsync(ExecuteInfo info, HttpRequestMessage req, Action next, Action<byte[]> hit)
        {
            throw new NotImplementedException();
        }

        public Task UseResponseAsync(ExecuteInfo info, HttpResponseMessage res, Action next)
        {
            throw new NotImplementedException();
        }
    }
}

My brain is on fire from trying to come up with a solution that isn't scuffed...

I originally wanted to support the Meraki CDN for 1.0.0 but didn't.

I'll see if I'm able to add it this time, maybe...

Maybe store it in JSON files for better user-friendliness? It will be slower than in-memory caching anyways... (灬╹ω╹灬)

• Store in JSON
• Track expiration
• Size limit
• Folder location

It is nice to have a chubby README.md, but I'm thinking it is also better to have documentation on GitHub pages...aaaa

I'm likely going to create it using Nuxt.js and Markdown files.

I think this feature would be awesome to have for making manual requests with the library that processes through the middleware plugins. So anyone can make requests to endpoints not yet supported (or will not support). So something like this, maybe:

// We are passing SummonerDto for strong-typing and JSON deserializing
SummonerDto summoner = 
    await client.Riot.GetAsync<SummonerDto>(Platform.NorthAmerica, "/lol/summoner/v4/summoners/by-name/uwuie time");

Or this:

SummonerDto summoner = 
    await client.Riot.GetAsync<SummonerDto>("na1", "/lol/summoner/v4/summoners/by-name/uwuie time");

Fluent builder:

SummonerDto summoner = await client.Riot.Request
    .WithRoute(Platform.NorthAmerica)
    .WithPath("/lol/summoner/v4/summoners/by-name/uwuie time")
    .GetAsync<SummonerDto>();

For JSON scalars:

int totalMasteryScore = await client.Riot.Request
    .WithRoute(Platform.NorthAmerica)
    .WithPath("/lol/champion-mastery/v4/scores/by-summoner/Ao5ffQ2dOV-99YKs_iB0g2EGzGD159jXIk2Z5MjvMafLwbQ")
    .GetAsync<int>();