Git Product home page Git Product logo

cinderflurry's People

Contributors

jandersen avatar randometc avatar

Stargazers

 avatar

Watchers

 avatar

cinderflurry's Issues

NSMutableDictionary *params - memory leak?

Instruments says that the Flurry lib is leaking.

I think it's the params Dictionary. e.g. here's logEvent:

void Flurry::logEvent(const string &eventName, const map<string, string> &parameters) {
    NSMutableDictionary *params = [[NSMutableDictionary alloc] init];
    for (map<string, string>::const_iterator iter = parameters.begin(); iter != parameters.end(); iter++) {
        [params setObject: string2NSString(iter->first) forKey: string2NSString(iter->second) ];
    }

    NSInvocation *invocation = [[NSInvocation alloc] init];
    [invocation setTarget: [FlurryAPI class]];
    [invocation setSelector:@selector(logEvent:withParameters:)];
    [invocation setArgument:string2NSString(eventName) atIndex:0];
    [invocation setArgument:params atIndex:1];
    [invocation performSelectorOnMainThread:@selector(invoke) withObject:Nil waitUntilDone:false];

    //[FlurryAPI logEvent:string2NSString(eventName) withParameters: params];
}

I think [NSInvocation setArgument] will do the right thing and copy the data... http://developer.apple.com/library/mac/documentation/Cocoa/Reference/Foundation/Classes/NSInvocation_Class/Reference/Reference.html#//apple_ref/occ/instm/NSInvocation/setArgument:atIndex:

... so we just need a judicious [params release] in there, but my Objective-C is rusty. Make sense?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.