bloominstituteoftechnology / cs-sprint-challenge-hash-tables Goto Github PK

README.md for ex2 shows an example of expected output:

["LAX", "SFO", "BHM", "FLG", "XNA", "CID", "SLC", "PIT", "ORD"]

which doesn't match the output expected in ex2_tests.py. The tests expect the output to end with "NONE".

Output that would actually pass tests:

["LAX", "SFO", "BHM", "FLG", "XNA", "CID", "SLC", "PIT", "ORD", "NONE"]

I had multiple students pass the unit tests for ex3 with code that just counted whether a number appeared more than once (the code did not actually confirm that it appeared in each array, or even that the count of the number of occurrences for that number matched the number of arrays).

And for ex4, its possible to pass the unit tests w/ code that just checks whether a numbers absolute value already exists in the hashtable (and if not, adds the abs value to the hash table).. So if any number appears multiple times, all positive or all negative, it would be included in the return list (which it should not, because only numbers which have the positive and the negative appear should be included).. So basically there should be a unit test that includes the same positive number appear twice to confirm that it does not get included in the return list..