cs-sprint-challenge-hash-tables's People
Forkers
jrive204 okocha76 matt-github hiterharris danpatrickoneill seabayley vincesanders nicci498 sarahxu087 easyas123l1 eralpkor baisalis adamwinzdesign juliewang417 rickahlgren heyclos claudiasofiac joshuapmallory ethanmjansen 1aaronscott kellymore phongdottech cleveroscar qb1968 asherkobin stompke ammoncs29 prudentj nolanpic premputtegowda chadarutherford konstadinosangelis thisisjorgelima vannasok aalvinlin mpaolodr rselent arashhaji krisdmonroe tylerrussin ljh-c youngw417 jhanson8 jaydenzk dazmen jtcode2408 jarrod847 nwkendall jamesluttringer2019 lou34964 daanishrasheed b-griffinn jagins alexandercsierra wilmarodz tylerchristian711 aaronjan98 jwross24 oakes680 eyvonne mefrem wvanorder maggieprice trevorjamesmartin eiancarter logansorensen kparrish193 jferrer95 igor-lambda tyler668 isabellaguo tadepew murphdirt879 jaytee-padilla marielapg allie-rae jmjles agohorel bleuxgenius ryankayne andrewslowe informagician jonalynna-cs29 proach123 jlong5795 ramonta-lee lance-smith-acc asbaden coltynw qweliant baisal89 spencerelggren mike-xie cholman davebettswebdev ashtonragan ebislab carrillo9ana aasachristian harrisharris1cs-sprint-challenge-hash-tables's Issues
Ex2 README example doesn't match tests
README.md for ex2 shows an example of expected output:
["LAX", "SFO", "BHM", "FLG", "XNA", "CID", "SLC", "PIT", "ORD"]
which doesn't match the output expected in ex2_tests.py. The tests expect the output to end with "NONE".
Output that would actually pass tests:
["LAX", "SFO", "BHM", "FLG", "XNA", "CID", "SLC", "PIT", "ORD", "NONE"]
Insufficient unit tests for ex3 and ex4
I had multiple students pass the unit tests for ex3 with code that just counted whether a number appeared more than once (the code did not actually confirm that it appeared in each array, or even that the count of the number of occurrences for that number matched the number of arrays).
And for ex4, its possible to pass the unit tests w/ code that just checks whether a numbers absolute value already exists in the hashtable (and if not, adds the abs value to the hash table).. So if any number appears multiple times, all positive or all negative, it would be included in the return list (which it should not, because only numbers which have the positive and the negative appear should be included).. So basically there should be a unit test that includes the same positive number appear twice to confirm that it does not get included in the return list..
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.