bloogrox / hasoffers-kpi Goto Github PK

take trigger get_cr (celery task) - https://github.com/bloogrox/hasoffers-kpi/blob/master/workers/trigger_handlers/tasks/min_cr_trigger.py
modify it, so it will listen to metric.loaded event.
it must receive event data
take trigger from database (Trigger model),
evaluate condition

{metric.value} {conditional operator} {threshold value}

Trigger model - is a condition

• name
• metric_key (enum: pacc, cr, ...)
• operator (lt, gt)
• active: bool

example

event.value > 0.05

here we have triggers
https://github.com/bloogrox/hasoffers-kpi/tree/master/workers/trigger_handlers/tasks
the problem is they are almost copy-paste

Estimation: 90 minutes

Action model

Action is a set of conditions and operations

fields

• conditions (one-to-many)
• operations (one-to-many)
• active (bool)

Condition model

fields:

• trigger
• trigger_status

example:
trigger="min CR"
trigger_status="PROBLEM"

what means run given operation when "min CR" trigger is in a "PROBLEM" state

Operation model

fields

• name

examples of operations:

• send email to affiliate
• send email to manager
• send email to administrator
• approve an offer for affiliate
• reject affiliate from the offer

run

flake8

and fix

Estimation: 60 minutes

implement event flow

[worker: load metric] -> <event: metric.loaded> -> [worker: run trigger check] -> <event: trigger.checked> -> [worker: detect trigger event] -> <event: trigger.problem> -> [worker: run trigger actions]

add a reason field to the model stats.models.UnapproveLog,
explain why was affiliate unapproved

https://github.com/bloogrox/hasoffers-kpi/blob/master/workers/hasoffers_calls/tasks/unapprove_affiliate_offer.py#L25

example

due to pacc: -20$

install this fork
git+https://github.com/bloogrox/celery-pubsub@import-fix

Metric worker should fire metric.loaded event

{
key:
value:
affiliate_id:
offer_id:
}

later we'll implement trigger worker who will subscribe to it

Estimate: 40 minutes

unapprove log
metric log
threshold checks log
trigger events log

trigger event is fired when trigger state is changed

trigger can have two states:

• OK
• PROBLEM

trigger state is calculated from trigger condition #8

trigger event publisher listens to trigger.checked event
is takes trigger status, and find previous trigger status from the log
if status is different, then trigger.event.ok or trigger.event.problem is emitted

Entity: Threshold

• trigger_id
• value
• entity_type
• ref_id

Entity Type (starting from highest priority)

• Affiliate
• Offer
• Category
• Global

Then take appropriate threshold and use it in triggers
https://github.com/bloogrox/hasoffers-kpi/blob/master/workers/trigger_handlers/tasks/max_cr_trigger.py#L13