blekenbleu / blekenbleu.github.io Goto Github PK

Hi, Thanks for your efforts, I've just started using your profiles to create a belt tensioner for my rig.

I've used your blek2char profile, but was experiencing the servo's going crazy sometimes in a corner, I exported a gnuplot and I could see them bouncing from min to max when surge and sway where happening at the same time. I believe I have fixed the issue and sharing what I have done.

I noticed that this commit swapped the direction of the comparison on the 2nd block of code below: 0cf75e1

I'm not sure if it also needs the top block changing as well. After making the change shown below, the servo's are acting as I would expect in corners.

// convert speed and yaw changes to left and right tension values
var leftSurgeSway;
var rightSurgeSway;
if (surge < 0) { // tension reductions during acceleration
// acceleration decreases harness tensions
var s = swaysway - surgesurge;
leftSurgeSway = Math.sqrt(Math.abs(s));
if (s < 0)
leftSurgeSway = - leftSurgeSway;
if (0 > sway) { <------ Should this also be a <
rightSurgeSway = leftSurgeSway;
leftSurgeSway = surge;
}
else rightSurgeSway = surge;
}
else {
leftSurgeSway = Math.sqrt(surgesurge + swaysway);
rightSurgeSway = surge + surge - leftSurgeSway;
if (1 > rightSurgeSway)
rightSurgeSway = 1; // reduce bogus clip warnings
if (0 < sway) {
var s = leftSurgeSway;
leftSurgeSway = rightSurgeSway;
rightSurgeSway = s;
}
}