Subdomain parameter not working in Library mode about node-zendesk HOT 2 CLOSED

Interesting...

I found that adding nconf.defaults(options.stores.defaults.store); after line https://github.com/blakmatrix/node-zendesk/blob/master/lib/client.js#L55 seems to do the trick... (https://github.com/indexzero/nconf#hierarchical-configuration)

@erikzrekz do you think this will have any ramifications if we make this change? env/argv seem to take precedence when disableGlobalState !== true we might be able to return to using nconf.get('[option key]') in lib/client.js... I must admit I'm getting a little confused about our usage of nconf as of late with the gravitation of what seems to be a phasing out of allowing env and argv in favor of a pure library.

from node-zendesk.

@blakmatrix No, I don't anticipate any ramifications from this. Seems okay.

And yeah, let's see how we can return to using nconf.get('[option key]'). I was solving for initializing multiple clients when I put together d4ca61c. But let me take a look in the upcoming days. Will report back.

from node-zendesk.