_react2.PropTypes.func is undefined about react-native-twilio-video-webrtc HOT 15 CLOSED

Ah, we failed to include prop-types as a dependency. That should be an easy fix. In the meantime does it work if you add prop-types to your package.json?

from react-native-twilio-video-webrtc.

installed npm install --save prop-types this but having same issue.

from react-native-twilio-video-webrtc.

@kapilkarda You are using version 1.0.1 ? Can you try master using git ?

from react-native-twilio-video-webrtc.

Hello @bilby91 , thanks for your response, i tried with master that error was remove now but their is new error. please check the snapshot

from react-native-twilio-video-webrtc.

Hello @bilby91 @slycoder do you have any solution for this ?

from react-native-twilio-video-webrtc.

is their any help ?

from react-native-twilio-video-webrtc.

Did you re-run react-native link after updating?

from react-native-twilio-video-webrtc.

And can you update your demo app repo? Thanks!

from react-native-twilio-video-webrtc.

You cannot import Proptypes from React anymore. install prop-types from npm.
Then replace the import to use it.
import PropsType prop-types

from react-native-twilio-video-webrtc.

Adding on the above above answer a little bit:

This library hasn't been updated since PropTypes was removed from React Native and moved into its own library.

So you'll have to npm install prop-types

And then in TwilioVideo.js change this:

import React, { Component, PropTypes } from 'react'
import {
  NativeModules,
  NativeEventEmitter,
  View,
} from 'react-native';

to this:

import React, { Component } from 'react'
import {
  NativeModules,
  NativeEventEmitter,
  View,
} from 'react-native';

import { PropTypes } from 'prop-types'

This is an ugly way of implementing this fix, but I'm not sure if this library is currently being maintained, so it'll have to work for now.

from react-native-twilio-video-webrtc.

@jmknoll I'm doing what I can with maintaining, not having a lot of time lately and not using the library at the moment. Can you work on a PR to fix this ? I'll review and merge.

Thanks!

from react-native-twilio-video-webrtc.

@jmknoll I believe the changes you are suggesting are already on master. There have been a huge number of changes landed on master since the previous NPM release, so I'd highly recommend pulling master into your project.

from react-native-twilio-video-webrtc.

@slycoder Thanks for the heads up. It looks like this issue at least is fixed in master. From the looks of it, this fixes a lot of the other open issues on here as well.

Maybe worth adding a line at the top of the docs advising people to install from github rather than npm as a temporary patch until the next release goes out?

from react-native-twilio-video-webrtc.

Either that or pushing a new version to npm. @bilby91 what do you think about pushing out a new version?

from react-native-twilio-video-webrtc.

(I'm not actually sure who has access to push to npm)

from react-native-twilio-video-webrtc.