bkayser / thrift-versioning-doc Goto Github PK

I am new to ruby (or my first day to it).
I tried with all the steps you mentioned. I am getting some SyntexError from server.rb
Find the log below. Whats the issue?

$ rackup
/xxx/thrift-versioning-doc/examples/config.ru:2:in `load': ./server.rb:21: syntax error, unexpected ':', expecting kEND (SyntaxError)
...vices::V1::AccountID.new name: name, id: id, parent: 1
^
./server.rb:21: syntax error, unexpected ':', expecting '='
...:AccountID.new name: name, id: id, parent: 1
^
./server.rb:21: syntax error, unexpected ':', expecting '='
...ew name: name, id: id, parent: 1
^
./server.rb:31: syntax error, unexpected ':', expecting kEND
...vices::V2::AccountID.new name: name, id: id, parent: 1
^
./server.rb:31: syntax error, unexpected ':', expecting '='
...:AccountID.new name: name, id: id, parent: 1
^
./server.rb:31: syntax error, unexpected ':', expecting '='
...ew name: name, id: id, parent: 1

Under the header "Backward Compatible Changes -- Good!" the below is listed:
Removing a field from a struct.

Removing a required field is not backwards compatible with clients as the new server will not set the field.

Is it backward compatible? If it isn't I think it should be included in the README.

First off – love this guide!

I see the note about adding or renaming fields in an enum. I'm wondering about changing the name of an enum. For example:

enum Status = {
  PRIVATE = 0,
  PUBLIC = 1
};

Becomes:

enum Visibility = {
  PRIVATE = 0,
  PUBLIC = 1
};

Same exact field names and values, just a enum name change. Any chance this can be added to the guide?