bitskico / bitski-js Goto Github PK

I'm back, is Bitski still having repairs?

I'm having problems sending tokens now, I'm just stuck here, I've been waiting for almost 30 minutes

Describe the bug
provider.request (tested with "personal_sign") returned promise do not resolve when user close the popup

To Reproduce

const signature = await provider.request({
	method: 'personal_sign',
	params: [account, 'hello']
});
// never reach there when user close the popup
console.log({signature})

See repo : https://github.com/bug-reproduction/bitski-request-no-resolved

Expected behavior
I expect request to always resolve after user action, else we cannot act on its rejection

SDK:

• Version 4.2.0

Describe the bug
When attemping to connect Bitski to a SKALE elastic sidechain, I receive a CORS error due to request headers that should not be sent to SKALE.

To Reproduce
Steps to reproduce the behavior:

1. Connect Bitski to SKALE

const bitski = new Bitski('<YOUR-CLIENT-ID>', '<YOUR-REDIRECT-URL>');
const network = {
  rpcUrl: '<YOUR-SKALE-ENDPOINT>',
  chainId: 1
}
const provider = bitski.getProvider({ network });
let web3 = new Web3(provider);

Expected behavior
A potential fix will be to remove the headers when sending requests to networks that contain a rpcUrl within the bitski-browser-engine at line 41.

bitski-browser-engine.ts (line 41)

Change

const defaultHeaders = {
    'X-API-KEY': this.clientId,
    'X-CLIENT-ID': this.clientId,
    'X-CLIENT-VERSION': this.sdkVersion,
};

To

const defaultHeaders = {};
if("rpcUrl" in network === false) {
    defaultHeaders = {
        'X-API-KEY': this.clientId,
        'X-CLIENT-ID': this.clientId,
        'X-CLIENT-VERSION': this.sdkVersion,
    };
}

Desktop:

• OS: Mac
• Browser Chrome
• Version 74.0.3729.169

SDK:

• Version Bitski-js 6.0 & 0.7.0-alpha.0

Additional context
I work at SKALE Labs, and am working on verifying support between SKALE and API based wallets. I really love what you are building at Bitski, and I look forward to following the progress!

https://github.com/BitskiCo/bitski-js-sdk/blob/cb84e015d313e16aaa5063c5d4b22e8a585b395d/src/providers/bitski-provider.ts#L106

Seems we're not catching errors here (a few lines below you can see it rethrows the error). Not sure what the best way to handle it would be. Could just catch and ignore which would solve the warnings, or somehow pass that error back to web3.

Describe the bug
The new setting "Prevent cross-site tracking" which enables ITP 2.0 in Safari 12 blocks third-party cookies from being accessible in iframes. Popups and the redirect flow are not affected.

To Reproduce
Steps to reproduce the behavior:

1. Go to an app that uses Bitski on a non bitski.com domain in Safari 12 with ITP2.0 enabled
2. Trigger a silent login (bitski.connect())

Expected behavior
Since the user is logged in, you would expect to receive an access token

Describe the bug
Module not found: Error: Can't resolve '@bitski/provider-engine' in '***/node_modules/bitski-provider/dist'
Module not found: Error: Can't resolve 'promise-to-callback' in '***/node_modules/bitski/dist/esm/subproviders'
Module not found: Error: Can't resolve 'cross-fetch' in '***/node_modules/bitski/dist/esm/subproviders'

To Reproduce
Steps to reproduce the behavior:

1. yarn add [email protected]
2. yarn serve or equivalent to start your app
3. make sure there is no errors
4. yarn add [email protected]
5. yarn serve or equivalent to start your app
6. See error

or to be more cautious
7. rm -r node_module && rm yarn-lock
8. yarn install
9. yarn serve or equivalent to start your app
10. See error

Expected behavior
[email protected] does not give any of these dependency errors

Desktop (please complete the following information):

• OS: [Mac Catalina 10.15.7]
• Browser [chrome]
• Version [Version 102.0.5005.115]

Additional context
This seems to be introduced in #229

I have NOT cloned the repo and installed lerna, assuming installing libraries from npm should not require users to go through such extra steps .

Disconnecting wallet on page reload
When we try to refresh the page when bitski wallet connected it gets disconnected.

To Reproduce
Steps to reproduce the behavior:

1. Connect wallet
2. refresh the page
3. wallet will disconnect

Expected behavior
Wallet shouldn't be disconnect

Desktop:

• OS: mac / windows
• Browser chrome / brave

SDK:

• Version 0.14.1

I don't know about GitHub but I want to ask if Bitski is still running? I've been having issues lately

• Can't log in, Bitski keeps asking me to enter my email, even though I've done it several times

• Can't send, an error always appears when I want to send something from Bitski