Git Product home page Git Product logo

companion-module-ptzoptics-visca's Introduction

companion-module-ptzoptics-visca

See HELP.md and LICENSE

companion-module-ptzoptics-visca's People

Contributors

cyberblaststudios avatar gartom avatar haakonnessjoen avatar hjoelr avatar jeffreydavidsz avatar josephdadams avatar jswalden avatar julusian avatar krocheck avatar mchauge avatar omeaart avatar peternewman avatar thedist avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

companion-module-ptzoptics-visca's Issues

Visca over IP Inquiry to variable

Module needs variables added to pull VISCA inquiry requests from cameras that can be displayed on buttons.

For example pulling current Iris (CAM_IrisPosInq) 81 09 04 4b ff values to show on button controlling those values.

Similar to the OBS Studio Instance.

TypeError: Cannot read property 'replace' of null

Sentry Issue: COMPANION-8M

TypeError: Cannot read property 'replace' of null
  File "app:///lib/module/ptzoptics-visca/index.js", line 1050, in instance.action
    var hexData = opt.custom.replace(/\s+/g, '');
  File "app:///lib/action.js", line 439, in null.<anonymous>
    instance.action(action, extras);
  File "app:///lib/instance.js", line 75, in EventEmitter.<anonymous>
    cb(self.active[id]);
  File "app:///lib/action.js", line 431, in EventEmitter.<anonymous>
    self.system.emit('instance_get', action.instance, function(instance) {
  File "app:///lib/action.js", line 411, in EventEmitter.<anonymous>
    self.system.emit('action_run', a, { deviceid: deviceid, page: page, bank: bank });
...
(5 additional frame(s) were not displayed)

Preset Recall Speed Issue

The Command Packet for preset recall speed is incorrect for the 20x-SDI.

It needs to be 81010601pFF. p: speed grade, the values are (0x01~0x18)

Migrating to V3

Hello. What's the status of this module?

I have some PTZOptics clone cameras and I wanted to try out some features of Companion V3 Beta. However, I noticed that this module isn't currently bundled, presumably because of errors (though I'm not sure how to see what those errors are).

So I decided to check out the sony-visca module and it turns out it is already compatible with V3, and under active development. Unfortunately, that module doesn't support TCP connections, which this module does (and which I need for my cameras).

So I submitted a PR to add TCP functionality. There was also a conversation under another issue.

My PR adds the option of using the TCP protocol and after a lot of testing this weekend I can confirm it works well and does everything (and more) that I need it to do.

After some careful consideration the maintainer(s) have decided to not accept my PR because it could begin to diverge that module away from being specific to Sony cameras. And whilst the idea of a creating generic VISCA module that works for all VISCA cameras seems attractive, it appears it's not without its downsides too.

So I guess this module will need updating to work for V3. And there are also quite a few useful features that are implemented in the Sony module that aren't in this one.

There are also several other VISCA modules that are in need of similar modernisation if they are to survive beyond v2.

Is anyone already working on a V3 upgrade for this module?

I'm happy to help out, and also would love to port some of the Sony module features if it would make sense to do so (don't know how we would decide), and reduce waste/duplicated effort where at all possible.

AVKans PTZ control

I have the camera AV-E20-NDI from AVKans. They tell me it is PTZoptics visca compatible. Using there software it will control but only with UDP 1259. If I put port 1259 in the PTZoptics connection it fails to connect with no entry in the log file of companion. Is there a way to force the PTZoptics to use UDP and not TCP

Unable to recall resets

I'm running into an issue where I'm unable to recall any camera presets through the companion action. I can control other camera features and can even save presets through the companion action. The only thing that isn't working is the ability to recall a preset that I've saved.

I've confirmed that the presets are stored in the camera through the web interface of the camera and everything works there.

Any ideas?

zoom not working as expected

I am very happy with all the functionalities but i am missing one thing...
The pan & tilt function has the possibility to adjust the speed of panning & tilting.
I don't see a function to set the speed of the zoom. Is it not there or do i not see it?
It would be awesome to have control over the zoomspeed in the same way as it can control pan & tilt.

Power On/Off

Unable to add custom command as it isn't working. Command for Power On is 8x 01 04 00 02 FF. Command for Power Off is 8x 01 04 00 03 FF.

focus mode and exposure mode not working

i use companion for 4 ptz-optics cameras.
pan, tilt, zoom, focus, presets and so on work perfectly, BUT focus mode (auto focus or manual focus) and exposure mode (full auto, manual, iris priority, shutter priority, and bright mode) doesnt work.

i would expect when in manuel mode i can adjust settings, end then when i push auto it should find optimal settings (like find focus or find right exposure) more or less right away, but nothing happens

BUG : Module going non responsive, requires restart of module. Memory leak?

Hi,

Not sure if Håkon Nessjøen still maintains the module but I'll post here in case anyone else has this issue.

Setup:
Windows 10 21H1
Streamdeck XL running latest firmware 5.2.1
Companion 2.1.4 Stable
2x PTZOptics class cameras 30x and 20x using VISCA
OBS

Issue:
Companion buttons that are configured to trigger camera presets become unresponsive after a varible period of time.

Trigger:
It appears that if the cameras are turned on after the PC running Companion, that the module, whilst constantly listening for the camera to respond, is using up some memory and not releasing it back to the module. That once the resources for a specific module reach a certain level, the module stops responding.

Tests:
We've seen this happen individually with both cameras. We started both cameras then the PC and the module didn't hang. Started Camera 1 and not Camera 2, then the PC, then Camera 2. The module of the Camera 2 hung around 45 mins later. Ditto when starting Camera 2 first and not Camera 1.

The cameras are fine. We can control them with other third party devices over VISCA whilst the Companion module has hung. This is not ideal as the whole purpose of the Streamdeck was having these preset buttons working on it.

Temporary Workaround:
Going into the Companion Connections screen then disabling / re-enabling the hung PTZOptics VISCA module. Companion buttons using the module then come back on line. The workaround isn't a solution given you're in the middle of a live performance and having to leave the video mixer to restart the Companion module.

Additional info.
We upgraded the system to Companion 2.2 which didn't solve the issue. Given the latest v.1.1.6 module release date of 5th April 2021, it would be included in Companion 2.1.3 / 2.1.4 and 2.2

Severity 1.
If there is a memory leak in the module, we don't want to be on tenterhooks not knowing if the module is going to hang esp during a long live service.

Thanks

PTZOptics (and probably all other VISCA cameras) lens speed control

companion-module-ptzoptics-visca currently supports "standard" lens speed, which makes it very hard to precisely set zoom and focus.
image

My request is to implement the variable commands instead:
image

and a mechanism similar to pan/tilt to set the speed
image

But as long as I'm here I'll ask that speed for pan, tilt, zoom, and focus should be options on those controls rather than just a separate setting.
image

Call to camera controls using variables rather than absolutes

Is this a feature relevant to companion itself, and not a module?

  • I believe this to be a feature for companion, not a module

Is there an existing issue for this?

  • I have searched the existing issues

Describe the feature

It would be helpful if Companion could make calls to PTZOptics using a variable and calculation for Camera number and Preset Number. Thus I could recall a preset with ( + 1) for Camera ( + 1). Believe this is a Companion issue for making the call rather tag a PTZOptic request, hence posted here. This would make coding of saving and loading preset configs a lot easier.

Usecases

Different camera presets for different types of events; different camera presets for different users with their favourite shots.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.