bitbagcommerce / syliusmercanetbnpparibasplugin Goto Github PK

.

Hi,

Would it be possible to add support for PHP 8?

Attempted to call function "shaCompose" from namespace "BitBag\MercanetBnpParibasPlugin\Legacy"

public function shaCompose(array $parameters)
    {
        // compose SHA string
        $shaString = '';
        foreach ($parameters as $key => $value) {
            if ($key != 'keyVersion') {
                if (is_array($value)) {
                    shaCompose($value);
                } else {
                    $shaString .= $value;
                }
            }
        }
        $shaString = str_replace("[", "", $shaString);
        $shaString = str_replace("]", "", $shaString);
        $shaString = str_replace("\",\"", "", $shaString);
        $shaString = str_replace("\"", "", $shaString);
        return $shaString;
    }

missing the $this-> before the shaCompose call;

This issue does not allow multiple payment with the instalment data.

Hi,
I'm using SyliusMercanetBnpParibasPlugin 2.2.2 with Sylius 1.4.7.
When making an order, if I cancel my payment on Mercanet site, I get the following error when going back to sylius.

Unknown method getAuthorisationId

The error seems come from bitbag/mercanet-bnp-paribas-plugin/src/Action/CaptureAction.php, at line 93.

$model['authorisationId'] = $this->mercanetBnpParibasBridge->getAuthorisationId();

To remove the error, I have to replace this line with the following:

if ($model['status'] == PaymentInterface::STATE_COMPLETED) {
    $model['authorisationId'] = $this->mercanetBnpParibasBridge->getAuthorisationId();
}

In sylius back-office, cancelled and validated orders seem to be correctly saved.

Can you reproduce the bug? Is it a valid fix?
Thanks for your time.

When i chose the BNP Paribas mercanet solution for payment, it throws this error :

Call to a member function setSecretKey() on string in vendor/bitbag/mercanet-bnp-paribas-plugin/src/MercanetBnpParibasGatewayFactory.php (line 54)

I think that the service defined in $config['payum.http_client'] is not fetched and it's the string '@bitbag.mercanet_bnp_paribas.bridge.mercanet_bnp_paribas_bridge' in the array.