birdstakes / quatch Goto Github PK

Some things that should be done:

• Explain what qvms are and why this library exists
• Add more usage examples with explanations
• Better installation instructions. For example pip install git+https://... or even python -m pip install git+https://...

In particular premature EOF and bad vm_magic should be handled, but the rest of the header should probably be validated too.

The data section is meant to contain 4 byte values that will be byte swapped at load time. On big-endian architectures, the current approach of only using STORE4 to initialize added data would cause everything to be byte swapped, including data that would normally go in the lit section and that should not be byte swapped, causing things like strings to be jumbled.

One possible solution would be to split add_data into add_data, add_lit, and add_bss and have those functions keep track of which kind of data is stored where. Then at write time STORE1 and STORE4 could be used for lit and data values, respectively.

CONST + CALL pair locations are cached at load time to be used in replace_calls. If an instruction referenced by the cache is modified, the cache should be updated.

Only the original call sites that existed at load time are cached so that new code can call the original unhooked functions without having to worry about a later replace_calls messing things up. Maybe there should also be a way to update the cache to include new call sites too, or an option to have replace_calls skip the cache.