bilelmoussaoui / nautilus-folder-icons Goto Github PK

View Code? Open in Web Editor NEW

99.0 99.0 11.0 171 KB

Change your nautilus directories icons easily!

License: GNU General Public License v3.0

Meson 7.36% Python 92.64%

extension nautilus nautilus-extension nemo nemo-extension

nautilus-folder-icons's People

Contributors

Stargazers

Watchers

Forkers

hrko samkraju vistaus fred-barclay alma4rebi samgundel forksbot bkdwt kdvcodes mjkim0727 awumii

nautilus-folder-icons's Issues

Error compiling in archlinux

makusensei@maku-linux  ~  yaourt -S nautilus-folder-icons

==> Descargando PKGBUILD para nautilus-folder-icons desde AUR...
x .SRCINFO
x .gitignore
x PKGBUILD
3ED_0 commented on 2017-06-15 08:52			 
https://pastebin.com/sZaZqPJk
// LANG and LC_ALL are set to pl_PL.utf8

bil-elmoussaoui commented on 2017-06-15 15:31			 
@3ED_0 please open an issue on github. This is not a compilation error

nautilus-folder-icons 1.2-1  (2017-06-15 02:16)
(Paquete sin soporte: ¡podría ser peligroso!)
==> ¿Quiere editar PKGBUILD? [S/n] ("A" para anular)
==> ------------------------------------------------
==> n

==> dependencias de nautilus-folder-icons:
 - gtk3 (ya instalado)
 - python2-nautilus (ya instalado)
 - nautilus (ya instalado)
 - gettext (ya instalado) [makedepend]
 - python (ya instalado) [makedepend]
 - gobject-introspection (paquete encontrado)
 - gnome-common (paquete encontrado) [makedepend]
 - meson (paquete encontrado) [makedepend]
 - ninja (paquete encontrado) [makedepend]


==> Continuar compilando nautilus-folder-icons? [S/n]
==> -------------------------------------------------
==> s

==> Compilando e instalando el paquete
==> Instalar o compilar las dependencias que faltan para nautilus-folder-icons:
[sudo] password for makusensei: 
resolviendo dependencias…
buscando conflictos entre paquetes…

Paquetes (18) autoconf-archive-1:2017.03.21-1  docbook-xml-4.5-6  docbook-xsl-1.79.1-2  glib2-docs-2.52.2+9+g3245eba16-1  gtk-doc-1.25+33+g567353f-1  intltool-0.51.0-2
              itstool-2.0.2+5+g676f3f7-2  perl-xml-parser-2.44-4  python-beaker-1.8.1-2  python-mako-1.0.6-2  python-markupsafe-1.0-1  source-highlight-3.1.8-12
              yelp-tools-3.18.0+1+g193c2bd-1  yelp-xsl-3.20.1-2  gnome-common-3.18.0-2  gobject-introspection-1.52.1-1  meson-0.41.0-1  ninja-1.7.2-1

Tamaño total de la instalación:  59,88 MiB

:: ¿Continuar con la instalación? [S/n] s
(18/18) comprobando las claves del depósito                                                            [############################################################] 100%
(18/18) verificando la integridad de los paquetes                                                      [############################################################] 100%
(18/18) cargando los archivos de los paquetes                                                          [############################################################] 100%
(18/18) comprobando conflictos entre archivos                                                          [############################################################] 100%
(18/18) comprobando el espacio disponible en el disco                                                  [############################################################] 100%
:: Procesando los cambios de los paquetes...
( 1/18) instalando autoconf-archive                                                                    [############################################################] 100%
Dependencias opcionales para autoconf-archive
    automake: macros for use with it [instalado]
( 2/18) instalando perl-xml-parser                                                                     [############################################################] 100%
( 3/18) instalando intltool                                                                            [############################################################] 100%
( 4/18) instalando yelp-xsl                                                                            [############################################################] 100%
( 5/18) instalando itstool                                                                             [############################################################] 100%
( 6/18) instalando yelp-tools                                                                          [############################################################] 100%
( 7/18) instalando docbook-xml                                                                         [############################################################] 100%
( 8/18) instalando docbook-xsl                                                                         [############################################################] 100%
( 9/18) instalando source-highlight                                                                    [############################################################] 100%
(10/18) instalando glib2-docs                                                                          [############################################################] 100%
(11/18) instalando gtk-doc                                                                             [############################################################] 100%
Dependencias opcionales para gtk-doc
    dblatex: PDF support
(12/18) instalando gnome-common                                                                        [############################################################] 100%
(13/18) instalando python-markupsafe                                                                   [############################################################] 100%
(14/18) instalando python-beaker                                                                       [############################################################] 100%
(15/18) instalando python-mako                                                                         [############################################################] 100%
(16/18) instalando gobject-introspection                                                               [############################################################] 100%
(17/18) instalando ninja                                                                               [############################################################] 100%
(18/18) instalando meson                                                                               [############################################################] 100%
:: Ejecutando los «hooks» de posinstalación...
(1/2) Arming ConditionNeedsUpdate...
(2/2) Updating the info directory file...
==> Creando el paquete: nautilus-folder-icons 1.2-1 (jue jun 15 18:06:31 -03 2017)
==> Comprobando dependencias mientras se ejecuta…
==> Comprobando dependencias mientras se compila…
==> Recibiendo las fuentes…
  -> Descargando v1.2.tar.gz…
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   143    0   143    0     0    203      0 --:--:-- --:--:-- --:--:--   203
100 26918    0 26918    0     0  14890      0 --:--:--  0:00:01 --:--:-- 38564
==> Validando los archivos source con sha256sums…
    v1.2.tar.gz ... Aprobado
==> Extrayendo las fuentes…
  -> Extrayendo v1.2.tar.gz con bsdtar
==> Iniciando build()…
The Meson build system
Version: 0.41.0
Source dir: /tmp/yaourt-tmp-makusensei/aur-nautilus-folder-icons/src/nautilus-folder-icons-1.2
Build dir: /tmp/yaourt-tmp-makusensei/aur-nautilus-folder-icons/src/nautilus-folder-icons-1.2/builddir
Build type: native build
Project name: nautilus-folder-icons
Build machine cpu family: x86_64
Build machine cpu: x86_64
Build targets in project: 4
==> Entrando en entorno fakeroot…
==> Iniciando package()…
ninja: Entering directory `builddir'
[1/2] Generating nautilus-folder-icons.metainfo.xml_merge with a custom command.
FAILED: data/nautilus-folder-icons.metainfo.xml 
/usr/bin/meson --internal msgfmthelper ../data/nautilus-folder-icons.metainfo.xml.in data/nautilus-folder-icons.metainfo.xml xml ../data/../po
msgfmt: no se pueden ubicar las reglas ITS para ../data/nautilus-folder-icons.metainfo.xml.in
ninja: build stopped: subcommand failed.
==> ERROR: Se produjo un fallo en package().
    Cancelando…
==> ERROR: Makepkg no ha podido compilar nautilus-folder-icons.
==> ¿Reiniciar la compilación de nautilus-folder-icons? [s/N]
==> ---------------------------------------------------------
==>

Just a minor thing, the dialog box where you pick your icon says cancel instead of close, which makes it seem that clicking it will NOT set any icons selected. It would make more sense to rename that button to close, since that's what it does.

Function does not take positional arguments

Currently meson has issues with building GNOME projects, as documented here: mesonbuild/meson#9441

Because of that issue, meson won't build the project, regardless of whether trying to install from the AUR or manually from git.

To be precise the error message is as follows:

data/meson.build:2:5: ERROR: Function does not take positional arguments.

Cannot discover La Capitaine Folder colors

as you can see from the image..

that was used to work before, so i guess is some change on La Capitaine icon set
https://github.com/keeferrourke/la-capitaine-icon-theme

DnD and icons caching

We should add DnD to the flowbox and store those images somewhere :)

Remove symlinked icons

A lot of themes has few icons linked to others. Which means we show a lot more icons that we are expected to do.

Build is not working on Fedora 30

The last step of the Installation did'nt work on my System (Fedora Workstation 30, Gnome Spin). Here is error output:

$ sudo ninja -C builddir install
ninja: Entering directory `builddir'
[1/2] Generating com.github.bilelmoussaoui.nautilus-folder-icons.metainfo.xml_data_merge with a custom command.
FAILED: data/com.github.bilelmoussaoui.nautilus-folder-icons.metainfo.xml 
/usr/bin/meson --internal msgfmthelper ../data/com.github.bilelmoussaoui.nautilus-folder-icons.metainfo.xml.in data/com.github.bilelmoussaoui.nautilus-folder-icons.metainfo.xml xml /home/jan/nautilus-folder-icons/po
msgfmt: cannot locate ITS rules for ../data/com.github.bilelmoussaoui.nautilus-folder-icons.metainfo.xml.in
ninja: build stopped: subcommand failed.

Not working on Fedora

For installing it in fedora it is also necessary to install pygobject3 and python3-gobject.

Anyway, after installing it the icon selector menu works well but when I select the icon the folder doesn't change.

Search on type

I think that we should implement a search on type behaviour to make it easier to apply icons

Make the icon loading async

Duplicating first letter

Hi, I have noticed that when I search the first letter will be duplicated.

nautilus-folder-icons-bug-letter.mp4

Cannot manually apply images

I can see the menu, but I can't click 'Apply' after selecting an image.

Wrong Python 3 package on README (Arch Linux)

As far as I'm concerned, the package for python3-nautilus on Arch Linux systems is actually called python-nautilus (package info here). Usually in Arch, only python2 packages have the version written onto them.

Port to Gtk4

How to reset all folders to default?

Hello, I would like to know if there's an option to reset all my folders to their factory defaults.

Thanks!

Allow python3 as a dependency

nautilus-python 1.2 now works with Python3.

Distros like Ubuntu do not even carry python2 by default anymore.

Add 'Apply' button to dialog

Hej,
first of all, this is a really nice plugin!
However, using it for the first time I was too stupid to understand that the icon needs to be set by double clicking. I expected an 'Apply' button to appear on the top right of the dialog, as it is the standard way of GTK dialogs to work.
Thus I wanted to ask, what your opinion on adding such a button is (a blue one, like used for renaming in nautilus). It would not need to replace the current way the plugin work, rather give another option (for people like me that otherwise just assume sth is broken…).

Also, a bit off-topic, do I suppose correctly, that this plugin works by listing all files in /usr/share/icons/Adwaita/512x512/places that start with 'folder'? Just curious, cause there currently is some initiative at nautilus going on to rework the properties dialog (https://gitlab.gnome.org/GNOME/nautilus/-/issues/1207 and https://gitlab.gnome.org/GNOME/nautilus/-/issues/1326) and I suppose this plugin relies on the built-in support of setting images as folder previews.

Cheers!

Not working with nautilus-git

With both nautilus-folder-icons-git and nautilus-ext-git-git AUR packages installed, the Folder Icon submenu does not appear in Nautilus.

Traceback (most recent call last):
  File "/usr/share/nautilus-python/extensions/folder-icons.py", line 39, in <module>
    from utils import change_folder_icon, restore_default_icon, uriparse
ImportError: cannot import name 'change_folder_icon' from 'utils' (/usr/share/nautilus-git/src/utils.py)

Error in install helper script -compiling- fedora29

code-

azrulFTW@localhost:~|⇒  cd nautilus-folder-icons
azrulFTW@localhost:~/nautilus-folder-icons|master 
⇒  meson builddir --prefix=/usr -Dfile_manager=nautilus       
Directory already configured.

Just run your build command (e.g. ninja) and Meson will regenerate as necessary.
If ninja fails, run "ninja reconfigure" or "meson --reconfigure"
to force Meson to regenerate.

If build failures persist, manually wipe your build directory to clear any
stored system data.

To change option values, run "meson configure" instead.
azrulFTW@localhost:~/nautilus-folder-icons|master 
⇒  sudo ninja -C builddir install
[sudo] password for azrulFTW: 
ninja: Entering directory `builddir'
[0/1] Installing files.
ERROR: 
Error in install helper script:

ERROR: Unknown internal command install.
FAILED: meson-install 
/usr/bin/python3 /usr/bin/meson --internal install /home/azrulFTW/nautilus-folder-icons/builddir/meson-private/install.dat
ninja: build stopped: subcommand failed.
azrulFTW@localhost:~/nautilus-folder-icons|master 
⇒

FAILED: data/nautilus-folder-icons.metainfo.xml

Hello!

After runing sudo ninja -C builddir install I got

ninja: Entering directory `builddir'
[1/2] Generating nautilus-folder-icons.metainfo.xml_merge with a custom command.
FAILED: data/nautilus-folder-icons.metainfo.xml
/usr/bin/meson --internal msgfmthelper ../data/nautilus-folder-icons.metainfo.xml.in data/nautilus-folder-icons.metainfo.xml xml ../data/../po
msgfmt: cannot locate ITS rules for ../data/nautilus-folder-icons.metainfo.xml.in
ninja: build stopped: subcommand failed.
do you know how to fix it?

another thing you should state this app depend on python 3 (for those who uses python 2)

awesome project BTW! :-)

Please replace yaourt for yay

Hello @bilelmoussaoui !

The yaourt is discontinued and deprecated, and considered unsafe according to Arch Linux official wiki. I suggest you replace for yay in the file README.

Install failing

meson builddir --prefix=/usr -Dfile_manager=nautilus

The Meson build system
Version: 0.49.1
Source dir: /home/me/Git/Apps/nautilus-folder-icons
Build dir: /home/me/Git/Apps/nautilus-folder-icons/builddir
Build type: native build
Project name: com.github.bilelmoussaoui.nautilus-folder-icons
Project version: 3.0.1
Build machine cpu family: x86_64
Build machine cpu: x86_64
Message: File Manager: Nautilus
Program appstream-util found: YES (/usr/bin/appstream-util)
Program python3 found: YES (/usr/bin/python3)
Configuring folder-icons.py using configuration
Build targets in project: 4
Found ninja-1.9.0 at /usr/bin/ninja

sudo ninja -C builddir install

[1/2] Generating com.github.bilelmoussaoui.nautilus-folder-icons.metainfo.xml_data_merge with a custom command.
FAILED: data/com.github.bilelmoussaoui.nautilus-folder-icons.metainfo.xml 
/usr/bin/meson --internal msgfmthelper ../data/com.github.bilelmoussaoui.nautilus-folder-icons.metainfo.xml.in data/com.github.bilelmoussaoui.nautilus-folder-icons.metainfo.xml xml /home/me/Git/Apps/nautilus-folder-icons/po
msgfmt: cannot locate ITS rules for ../data/com.github.bilelmoussaoui.nautilus-folder-icons.metainfo.xml.in
**ninja: build stopped: subcommand failed.**

Fedora, nemo

Hello. Running:
$ meson builddir --prefix=/usr -Dfile_manager=[nautilus|nemo]

results in an error:

bash: nemo]: command not found...
Similar command is: 'nemo'
Exception ignored in: <_io.TextIOWrapper name='<stdout>' mode='w' encoding='UTF-8'>
BrokenPipeError: [Errno 32] Broken pipe

it didn't change after installing nemo either.