bigmstone / stoneflow Goto Github PK

Currently only Enterprise 0 Type 1 is supported, while code exists to handle Type 2 it is unused. Should be enhanced to handle other types, potentially the full spec.

Project has 0% coverage. Change that.

Currently only supports type 1 of the following list:

enum header_protocol {
   ETHERNET-ISO88023    = 1,
   ISO88024-TOKENBUS    = 2,
   ISO88025-TOKENRING   = 3,
   FDDI                 = 4,
   FRAME-RELAY          = 5,
   X25                  = 6,
   PPP                  = 7,
   SMDS                 = 8,
   AAL5                 = 9,
   AAL5-IP              = 10, /* e.g. Cisco AAL5 mux */
   IPv4                 = 11,
   IPv6                 = 12,
   MPLS                 = 13,
   POS                  = 14  /* RFC 1662, 2615 */
}

And the support for type 1 uses static locations inside a packet so certain assumptions are made about frame/packet header length. This can, and should, be modified to take into account more options from the list, as well as allow for dynamic parsing of those frames depending on header length variables.

The existing code makes extensive use of byte array mapping to structs. There should be a helper method that can map a struct to a byte array to dramatically simplify entire code base and byte array parsing in general.