bigfish8 / esbuild-plugin-vue-next Goto Github PK

Hi,
I just noticed that the types for a commonjs require import are wrong:

const pluginVue = require("esbuild-plugin-vue-next");

/** @type {import('esbuild').BuildOptions} */
const BuildOptions = {
    plugins: [pluginVue()], // will cause a type error (ts2349: This expression is not callable.)
    // is defined at runtime.
}

const pluginVue = require("esbuild-plugin-vue-next").default;

/** @type {import('esbuild').BuildOptions} */
const BuildOptions = {
    plugins: [pluginVue()], // correct type but will fail at runtime
    // (with "TypeError: This expression is not callable.")
}

esModuleInterop is set to true.

TS Handbook

...other than package.json and README.md. Please fix it.

Is there any way to keep CSS from SFCs in JS instead of emitting a CSS file ?

Hi!
Since esBuild v.0.14.44 alwaysStrict implemented in tsconfig.json, "Uncaught ReferenceError: cssModules is not defined" appears in browser console if Vue component uses css modules.

I've checked the code and looks like it's necessary to replace none strict styleImportCode += '\nscript.__cssModules = cssModules = {}' with strict styleImportCode += '\nconst cssModules = script.__cssModules = {}' in the entry.ts.
I've tried to make a PR, but I don't have permissions to commit.

Hope this fix will be released.
Thanks!