examples should use enums instead of plain numbers too

• correctly mark option properties as optional
• make sure "receiver" is somehow described as the allowed string/object mixture

Node Version:12.16.1

Node BACstack Version: 0.0.1-beta.22

Hey together,

I am running the bacstack with a Siemens DXR2 Room Automation Device and I can greatly read all my data.
But I can not write data. With the bacstack V0.0.1-beta.14 I always got the result "undefined" and I couldn't figure out what is the problem.
Now I receive "Error: BacnetError - Class:5 - Code:67" which is probably because of better error handling. Based on the handbook it is a "reject unrecognized Service" but no clue what to do with this message or where to search.

Also already had a look in here:
fh1ch/node-bacstack-browser#2
But no help for me yet.

Anybody has Ideas on this?

Greets
Tom

Node Version: 12.20.0

Node BACstack Version: 0.2.4

• [ x ] Bug Report

Current Behaviour (Bug Report)

I sent time synchronization with current date, but a day of last month is sent.
Current date is April 13, 2021.

sample code:

const bacnet = require('node-bacnet');
const client = new bacnet();

client.timeSync(MY_DEVICE_IP, new Date());
// MY_DEVICE_IP is actually a valid IP

Expected Behaviour (Bug Report)

I expected timeSynchronization with "Date: April 13, 2021," is sent, but timeSynchronization with "Date: March 13, 2021," is sent

Suspicious code

In JavaScript, the getMonth() method returns the month from 0 to 11.
If library sends it as is, it means last month's data in the BACnet protocol.
So it need call getMonth() + 1 to create buffer in encodeBacnetDate.

code to be fixed:

• increase coverage
• get the coverage file out of the docker container after run to get a ful overview about test coverage

Node Version: v14.17.0

Node BACstack Version: 1.0.0

• [X ] Bug Report
• Feature Request
• Question

Note: Make sure you have read the FAQs
before logging this issue.

Feature Request / Question

Current Behaviour (Bug Report)

const bacnetClient = new Bacnet({
port: 47809, // Use BAC1 as communication port
interface: '192.168.222.11', // Listen on a specific interface
broadcastAddress: '192.168.222.255', // Use the subnet broadcast address
apduTimeout: 60000 // Wait twice as long for response
});

currently discovering in port 47808,but in options there is 47809.

So the bug in transport.js Line 100.
this._server.send(buffer, 0, offset, port || DEFAULT_BACNET_PORT , address);

variable "port" is undefined.

Expected Behaviour (Bug Report)

Steps to reproduce Issue (Bug Report)

Node Version: LTS 12

Node BACstack Version: next

• Bug Report
• Feature Request
• Question

Note: Make sure you have read the FAQs
before logging this issue.

Feature Request / Question

We want to start a next try to create a RC.1 of the lib

@Apollon77 here we are - see Projects ..

1. bacnet - acknowledgeAlarm integration
   should return a timeout error if no device is available:

   Uncaught AssertionError: expected 'BacnetError - Class:5 - Code:67' to deeply equal 'ERR_TIMEOUT'

   • expected - actual

   -BacnetError - Class:5 - Code:67
   +ERR_TIMEOUT

   at /Volumes/Dev/GitHub/node-bacstack/test/integration/acknowledge-alarm.spec.js:12:32
   at /Volumes/Dev/GitHub/node-bacstack/lib/client.js:510:1529
   at _invokeStore. (lib/client.js:42:491)
   at Client._invokeCallback (lib/client.js:37:222)
   at Client._processError (lib/client.js:55:640)
   at Client._handlePdu (lib/client.js:116:1807)
   at Client._handleNpdu (lib/client.js:126:1001)
   at Client._receiveData (lib/client.js:143:240)
   at Socket. (lib/transport.js:3:633)
   at UDP.onMessage [as onmessage] (dgram.js:924:8)

Since I am new to BACnet, I need an example showing how to create a BACnet device and read and write data.

Please, start your testing and do some documentation in the code to fill up the jsdocs!

• Bug Report
• Feature Request
• Question
• Testing

https://sourceforge.net/projects/yetanotherbacnetexplorer/

Node Version: X.Y.Z

Node BACstack Version: X.Y.Z

• Bug Report
• [ x ] Feature Request
• [ x ] Question

Note: Make sure you have read the FAQs
before logging this issue.

Feature Request / Question

Hello all, my questio is quite simple, i wanty to read a property (present value for ex) so, the propertyID: 85
To test, i have downloaded this: http://bacnet.sourceforge.net/
and i run this command to query a property:
./bacrp --mac 192.168.1.12 1012 2 13 present-value
or
./bacrp --mac 192.168.1.12 1012 2 13 85

192.168.1.12
is ip of the device i want to query

1012
is the DEVICE instance

2
is the object-type (like analog, etc...)

13
os the OBJECT instance

property
85, for present value according to bacnet protocol.

According to the node-bacstack doc, to read a property, i need to:
const bacnet = require('node-bacnet');
const client = new bacnet();

client.readProperty('192.168.1.43', {type: 8, instance: 44301}, 28, (err, value) => {
console.log('value: ', value);
});

But, i cant put the OBJECT instance somewhere, so... what can i do ? I am quite stuck and i feel i am doing something wrong.. but i can see where

Node Version: 10.15.0

Node BACstack Version: 0.2.4

• Question

Note: Make sure you have read the FAQs
before logging this issue.

Feature Request / Question

I am trying to use node-bacstack with devices behind a MS/TP router. It is unclear to me how to use node-bacstack to accomplish this. The NET and ADR is not obvious or clear to me. I am trying to discover the devices behind device 156 and read/write their properties. I'm new to MS/TP.

Below is the WHOIS return from /examples/read-device.js

Device 156 is the MS/TP router that has child devices/properties. The readproperties function included in the /examples/read-devices.js retuned this JSON for device 156

A bacnet explorer returned this for device 156

Here is code. Mostly unchanged from the example.

read-device.zip

Please, start your testing and do some documentation in the code to fill up the jsdocs!

there are many number tags, which should be removed with enum tags

Node Version: 16.3.0

Node BACstack Version: 0.2.4

• Bug Report
• Feature Request
• Question

Note: Make sure you have read the FAQs
before logging this issue.

Feature Request / Question

I'm trying to communicate with a "virtual" device that contains a 4-byte MAC address as seen in the attached Wireshark capture. I can see the devices perfectly fine in YABE, but I cannot discover these devices during a whoIs and haven't been successful with readProperty either.

Please update to iconv-lite >= 0.6.0 in order to fix issues with Electron. Project will build fine but fail when running during imports with "webpack_require(...) is not a function". See ashtuchkin/iconv-lite#204 for more info.

I have successfully tested manually updating the dependency to 0.6.2.

At least:

• docs
• GitHub testing maybe :-)

• sowd@296db14
• NateZimmer/node-bacstack@master...antecursor:master
• fh1ch/node-bacstack@master...NateZimmer:master
• fh1ch/node-bacstack@master...bastiaanv:master
• NateZimmer/node-bacstack@master...nkofl:master

Please, start your testing and do some example documentation in the code to fill up the jsdocs!

some updates to do for this lib:

• README
• CONTRIBUTION
• License
• NPM package information
• gh-pages

Node Version: v12.19.0
Node BACstack Version: [email protected]

• [x ] Bug Report

Expected Behaviour (Bug Report)

• using the readPropertyMultiple command with the properties: [{id: 8}] results in Error: ERR_TIMEOUT, although it should support 8 for all properties

• tried increasing the adpuTimeout: 9000 but still got the same result Error: ERR_TIMEOUT

• the code does work if called with singular properties like properties: [{id: 77},{id: 28},{id: 85},{id: 111}]

• in the last working version from the original library node-bacstack the results are as expected ie: with properties: [{id: 8}] we get the correct value object.

• my sample code

//setup the BACnet comms
const bacnet = require('node-bacnet');
const client = new bacnet({
  port: 47808,                          // Use BAC0 as communication port
  interface: '192.168.222.84',          // Listen on a specific interface
  broadcastAddress: '192.168.222.255',  // Use the subnet broadcast address
  adpuTimeout: 6000                     // Wait twice as long for response
});


// get what we want to read/write
const requestArray = [
  {objectId: {type: 8, instance: 1010220}, properties: [{id: 8}]}    //this results in ERR_TIMEOUT
  //{objectId: {type: 8, instance: 1010220}, properties: [{id: 77},{id: 28},{id: 85},{id: 111}]} //this works
];

// now send the request
client.readPropertyMultiple('192.168.222.222', requestArray, (err, object) => {
  console.log('Returned obj. = ', JSON.stringify(object,null,2));
  console.log('ERRORS if any or NULL :: ', err);
  // IMP close the open listening socket
  client.close();
});

Watch the contributor introduction video and read the CONTRIBUTION.MD

Start your contribution via gitpod!

When running a program using this library (subscribing to COVs, reading and writing properties, etc), what is the local device ID? Is there a way to set it to something specific?

Node Version: 14.2

Node BACstack Version: 0.2.4

• Bug Report
• Feature Request
• Question

Note: Make sure you have read the FAQs
before logging this issue.

Feature Request / Question

I am running a Bacnet-device on a foreign network via a VPN-tunnel. In other Bacnet-software I have to configure a BBMD that is running on the foreign bacnet-device. How can I configure the BBMD in node-bacstack?

In client.js I have found line 505:

sender: { // Address of the host we are directly connected to. String, IP:port. address: remoteAddress, // If the host is a BBMD passing messages along to another node, this // is the address of the distant BACnet node. String, IP:port. // Typically we won't have network connectivity to this address, but // we have to include it in replies so the host we are connect to knows // where to forward the messages. forwardedFrom: null, },

Let's say the device I want to connect to and on which the BBMD is running has the IP "192.168.151.51".
My machine has the IP "192.168.67.253".
Both networks are connected via a VPN-Router.
What lines do I have to change so that I can establish a connection? Do you have an example?

PS: I am sure that the connection between the bacnet-device and my machine is working, because I tested it with BACeye software.

There are some issues from codacy to work on

Node Version: 20.2.0

Node BACstack Version: 0.2.4

• Bug Report
• Feature Request
• [ x] Question

Note: Make sure you have read the FAQs
before logging this issue.

Feature Request / Question

I'm getting Protocol_Object_Types_Supported (BACnetObjectTypesSupported) using readPropertyMultiple, the returned values I get are { value: [ 0, 1, 0, 0, 0, 0, 0, 1 ], bitsUsed: 60} when I drill down to them. However this does not cover all possible values for each as per ASHRAE 135-2020, in this there are 63 possible values.
When I monitor the value coming in over wireshark using YABE to check its represented as "protocol-object-types-supported: (Bit String) (FFFFFFFFTFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFTFFF)" with the T's representing Device and Network which is what I expect to see.
Do I need to do something with the returning value to have it match up?
Please ignore my ignorance if I'm missing something obvious.

Current Behaviour (Bug Report)

Expected Behaviour (Bug Report)

Steps to reproduce Issue (Bug Report)

Node Version: 12

Node BACstack Version: 0.1.1-beta.1

• Bug Report
• Feature Request
• Question

Note: Make sure you have read the FAQs
before logging this issue.

Current Behaviour (Bug Report)

Not sending a read to correct BACnet device

Expected Behaviour (Bug Report)

Send bacnet read to correct device not broadcast on 255.255.255.255

Steps to reproduce Issue (Bug Report)

// issue is that the destination is 255.255.255.255
// my host is 192.168.0.22
// target device is  192.168.0.201

const bacnet = require('./index');
const options = {
    deviceId: 1234,
    apduTimeout: 6000,

    };
const client = new bacnet({options, port: 47808, interface: '192.168.0.22', broadcastAddress: '255.255.255.255'});

// tried with and without the broadcastAddress
// const client = new bacnet({options, port: 47808, interface: '192.168.0.22'});


// Read Device Object
const requestArray = [{
  objectId: {type: 1, instance: 1},
  properties: [{id: 85}]
}];
client.readPropertyMultiple('192.168.0.201', requestArray, (err, value) => {
  console.log('value: ', JSON.stringify(value));
});