bezenson / react-native-unicorn-modals Goto Github PK
View Code? Open in Web Editor NEWCustom modals with Imperative API 🦄
Home Page: https://inferusvv.github.io/react-native-unicorn-modals/
License: MIT License
react-native-unicorn-modals's People
Contributors
Stargazers
Watchers
react-native-unicorn-modals's Issues
goog color
Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch [email protected] for the project I'm working on.
Here is the diff that solved my problem:
diff --git a/node_modules/react-native-unicorn-modals/src/themes/default-dark.ts b/node_modules/react-native-unicorn-modals/src/themes/default-dark.ts
index 4b8df4a..6a5f3c0 100644
--- a/node_modules/react-native-unicorn-modals/src/themes/default-dark.ts
+++ b/node_modules/react-native-unicorn-modals/src/themes/default-dark.ts
@@ -8,7 +8,7 @@ const defaultThemeDark: DefaultTheme = {
},
cardBackgroundColor: '#111',
lineColor: '#222',
- overlayBackgroundColor: 'rgba(0, 0, 0, 0.8)',
+ overlayBackgroundColor: '#0008',
textColor: '#ddd',
titleTextColor: '#fff',
};
diff --git a/node_modules/react-native-unicorn-modals/src/themes/default-light.ts b/node_modules/react-native-unicorn-modals/src/themes/default-light.ts
index 4c5f21e..7aff425 100644
--- a/node_modules/react-native-unicorn-modals/src/themes/default-light.ts
+++ b/node_modules/react-native-unicorn-modals/src/themes/default-light.ts
@@ -8,7 +8,7 @@ const defaultThemeLight: DefaultTheme = {
},
cardBackgroundColor: '#eee',
lineColor: '#ddd',
- overlayBackgroundColor: 'rgba(0, 0, 0, 0.8)',
+ overlayBackgroundColor: '#0008',
textColor: '#333',
titleTextColor: '#000',
};This issue body was partially generated by patch-package.
New features required use custom modal
add animationType to modal.show options
add modal.hide() to close modal in custom modal content view
Reanimated 3 update?
Hi @inferusvv , as I can see, the lib depends on Reanimated 2, which may not have compatibility with newer React Native versions. Are there plans to update it?
Configure cancelable: false, you can still click on the blank to close
cancelable: false Invalid
model.show( 'customModal', { title, description: message, ok: { text: 'done', onPress: onPress }, }, { cancellable: false }, );
Menu item `onPress` handlers not invoked
Hi there! First of all, bravo for the library 😁 Definitely the best of the kind I've found so far both in terms of appearance and API design.
There's a small bug in v0.5.0: in the code to open a menu:
modal.show(
'menu',
{
items: [
{ text: 'Default variant', onPress: () => {} },
{ text: 'Cancel variant', variant: 'cancel', onPress: () => {} },
{ text: 'Destructive variant', variant: 'destructive', onPress: () => {} },
],
},
);
None of these onPress callbacks get called. I looked into the source code and was able to fix it by changing a line in Menu.tsx:
<MenuItem key={item.text} onPress={createActionCallback()} theme={theme} variant={item.variant}>
to
<MenuItem key={item.text} onPress={createActionCallback(item.onPress)} theme={theme} variant={item.variant}>
Just posting it here so you guys can fix it upstream. Thanks for the work! 👍
Provide a guide, how to show modal outside React components (e.g. inside redux middleware)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.