bevacqua / local-storage Goto Github PK

The local storage is for the domain of the site. However, we have many sites under the domain separated by different sub-folders.

I am wondering if the library can support namespace in the API.

Thanks so much!

Hi,

the set function, as it is currently implemented, simply gulps down all exceptions:

function set (key, value) {
  try {
    ls.setItem(key, JSON.stringify(value));
    return true;
  } catch (e) {
    return false;
  }
}

• the function should either not catch exceptions (breaking change)
• or at least log exceptions to the console.

Actively suppressing exceptions decreases visibility into the fact that errors are happening at all and makes debugging harder.

Cheer,

I am a maintainer of a project which must have support for IE11 browser.
I'm wondering what is your browser support list since this project has been flagged as not ES5 safe.

Checking ES5 support for node_modules on my project with are-you-es5 shows:

> npx are-you-es5 check . -rv

...
✅ js-cookie is ES5
❌ local-storage is not ES5
✅ lz-string is ES5
...

I'm using version 2.0.0.

Sorry for not understanding better how to post, but had a working project that just did these two lines:

import ls from 'local-storage';
const user = ls.get('userInfo');

When I upgraded to 2.0, I started getting TypeScrpt error complaining about get.

The error is as follows:

Property 'get' does not exist on type '<T>(key: string, value?: T | undefined) => void'.

If this issue makes no sense, feel free to close. I really don't understand why I'd get an error like that.

Hello, so i included the module and use it like:

<script src="node_modules/local-storage/dist/local-storage.js"></script>
<script>ls.set('foo','bar'); console.log(ls.get('foo'));</script>


But nothing happens instead of an error which is: Uncaught ReferenceError: ls is not defined;
I installed it like that npm install local-storage --save
So how can i use it into my own javascript?

I notice that in the function https://github.com/bevacqua/local-storage/blob/master/tracking.js#L20 you reference e.key, e.newValue, and e.oldValue — but these properties are not provided by IE8. So I was just wondering: has this module been tested in IE8; is it intended to work there?

(I was hoping that was one of the browser-specific quirks that was smoothed out ...)

Unfortunately it doesn't work with requirejs.

We have a public site which saves a returned authorization token to localStorage using a javascript plugin. Then we redirect the user to an "app" subdomain (a nodejs site using your local-storage node module). Is there a syntax for this module that, on app.mysite.com, we can access the local storage for mysite.com to retrieve the authorization token? In basic javascript, I think it is something like

localStorage['mysite.com']

(otherwise, not specifying the index would default to localStorage for app.mysite.com).

Hi,

I recently had an issue where the localstorage system was corrupted, and so the ls.get() function returned an error:

Reproduce with this local storage content::

|-----|-----------|
| foo | undefined |
|-----|-----------|

ls.get('foo') // -> Throws an error because undefined is not a valid JSON.

Did this ever happened to one of you? How did you manage the thing?

For the time being, I use a try/catch and delete the key of the localstorage if such a thing happens.

I guess the library was build for a specific purpose to sync states between tabs.

If its meant for more common use,
it would be nice to support localstorage listener for same tab as well
( not considering which tab localStorage value was thrown).

In the README, it's specified that, upon .set, the function will return whether the operation fails. However, it does not state what kind of object will be returned, i.e. a string, booleon or actual Error object.

I guess this is an issue with the documentation and if this can't be updated easily, then I'll go in to the source code and find out. If I do, I'll do a pull request for the docs.

Thanks for the great library!

Some browsers that support localStorage (i.e. Safari) use a zero-quota policy for private browsing. Usually a surrounding try/catch block makes the fix.

I have a need where no matter what, I would want the value to be stored, either in localStorage or in the local module.

For cases like the quota limit exceed or any weird error triggered by local storage, I would want the local module store to be used.

Right now there's no way to do that. What do you think about the feature? I can implement it. I did it in my own small module but then thought well maybe this particular simple module I saw should just work like that.

Breaks in nuxt-vite

package.json

{
  "dependencies": {
    "local-storage": "^2.0.0",
    "nuxt": "^2.15.4",
  },
  "devDependencies": {
    "nuxt-vite": "^0.0.36",
  }
}

localstorage.get() does not always return a value

I want to implement a feature for this site - falling back on the cookie (by setting a flag by the client, to avoid compatibility) for persistent storage, and caching the localStorage objects instead of always returning JSON.parse in ls.get.

In addition, I want to add event-listener support and encryption support.

Will these features be welcomed?

Hey there, is any possibility of updating the dist/local-storage.js file to be the main file in the package.json and also transpiling it down completely to es5?

I'm working on a project that needs to support older browsers and I'm getting issues with it.

browser compatibility issue happens when doing both the following
import ls from 'local-storage';
import ls from 'local-storage/dist/local-storage';

Would be nice to have a TTL feature, where setting a key would have a timeout and invalidate if the next get is later than the define TTL value.