beryu / customizableactionsheet Goto Github PK

https://github.com/beryu/CustomizableActionSheet/blob/1.0.7/CustomizableActionSheet/CustomizableActionSheet.swift#L36

NG

convenience init(type: CustomizableActionSheetItemType, height: CGFloat)

OK

public convenience init(type: CustomizableActionSheetItemType, height: CGFloat)

Open the action sheet in say, the portrait mode and rotate the device, the action sheet will not adapt to the new orientation and therefore cannot be seen on the screen (since the dimensions of the action sheet are made based on the earlier orientation).

Is there any plan to add support for rotation? Thanks.

Hi,

The CustomizableActionSheet.podspec includes the following:
s.xcconfig = { 'SWIFT_VERSION' => '3.0' }

This overwrites target projects SWIFT version (which for newer projects are 3.1) and causes this CocoaPods error:

[!] The My-Project [Debug] target overrides the SWIFT_VERSION build setting defined in `Pods/Target Support Files/Pods-My-Project/Pods-My-Project.debug.xcconfig'. This can lead to problems with the CocoaPods installation

I think best practice is not to include the SWIFT_VERSION in your pod spec - see reference here

Thanks for the awesome library! I'm having build errors with Swift3 and Xcode8 while using either the swift3 branch or master branch.

I'm using:

pod 'CustomizableActionSheet', :git => 'https://github.com/beryu/CustomizableActionSheet', :branch => 'swift3'

And have a number of build errors. I noticed #8 is open but neither branches seem to work for my project.

Any suggestions?

Hello,
when i create a CustomizableActionSheet with buttons, in a UITableViewController, the last button is below in the UITableViewController but not visible, is it possible to display it with the others in the visible part of my UITableViewController ?

I studied the example and also use the code for tabbar controller but when the actionsheet, it is invisible.

when I comment out the items.append(sampleView), I can see a CANCEL button.

It seem that something is wrong with my sampleview xib but i can figure it out.

HELP!

Im trying to used this control in iPad with Orientation. But layout is not resize im using auto layout.

Is it possible to enable scroll? When I add too many actions some of them go offscreen.

The action sheet would cut off from the bottom if it is used in a scrollview and if the scrollable content goes beyond the UIScreen.

This is due to this line in the code in the showInView method-

public func showInView(_ targetView: UIView, items: [CustomizableActionSheetItem], closeBlock: (() -> Void)? = nil) {
   // Save instance to reaction until closing this sheet
   CustomizableActionSheet.actionSheets.append(self)

let screenBounds = UIScreen.main.bounds
.....

The screenBounds should take targetView.bounds instead of UIScreen.main.bounds which resolves the issue.

  public func showInView(_ targetView: UIView, items: [CustomizableActionSheetItem], closeBlock: (() -> Void)? = nil) {
    // Save instance to reaction until closing this sheet
    CustomizableActionSheet.actionSheets.append(self)

    let screenBounds = targetView.bounds

iPhoneX has the home button inside the screen.
ActionSheet should be shown in a safe area.

Hi,
For iOS and macOS projets it's will be great to make your component Carthage compatible

Take a look at these articles:

• Ruthlessly Simple Dependency Management with Carthage
• Carthage Tutorial: Getting Started
• Making Carthage-compatible Frameworks with Swift
• Swift Cross Platform Framework (section Configure targets for Carthage) 👍

On your README.md add on top and add section for the installation with Carthage.

Hi, awesome project, but the action sheet goes under tabbar.