This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update dependency marked to v14

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

• Extension Name: marked-footnote
• Extension Version: 1.2.0
• Project Version:
• Device: [e.g Desktop] Any
• OS@version (or Browser): Any
• Node And NPM Version: Any

Description

Parsing markdown with footnotes output is non-idempotent, see reproduction for example.

To Reproduce (⚠️ read below)

Expected Behavior

	const str = `Here's a simple footnote,[^1] thanks.

[^1]: This is the first footnote.`;
	let rendered = marked.parse(str);
	console.log(`rendered:`, rendered);
	// Output:
<p>Here&#39;s a simple footnote,<sup><a id=\"footnote-ref-1\" href=\"#footnote-1\" data-footnote-ref aria-describedby=\"footnote-label\">[1]</a></sup> thanks.</p>
<section class=\"footnotes\" data-footnotes>
<h2 id=\"footnote-label\" class=\"sr-only\">Footnotes</h2>
<ol>
<li id=\"footnote-1\">
<p>This is the first footnote. <a href=\"#footnote-ref-1\" data-footnote-backref aria-label=\"Back to reference 1\">↩</a></p>
</li>
</ol>
</section>


	rendered = marked.parse(str);
	console.log(`rendered:`, rendered);
	// Output:
	<p>Here&#39;s a simple footnote,<sup><a id=\"footnote-ref-1\" href=\"#footnote-1\" data-footnote-ref aria-describedby=\"footnote-label\">[2]</a></sup> thanks.</p>
<section class=\"footnotes\" data-footnotes>
<h2 id=\"footnote-label\" class=\"sr-only\">Footnotes</h2>
<ol>
<li id=\"footnote-1\">
<p>This is the first footnote. <a href=\"#footnote-ref-1\" data-footnote-backref aria-label=\"Back to reference 1\">↩</a></p>
</li>
</ol>
</section>

The second time the same string is parsed, the superscript is now [2], instead of [1], even though the other reference IDs correctly have it as [1].

Actual Behavior

Superscript is [2]

Additional Information

• Extension Name: marked-footnote
• Extension Version: v1.2.1
• Project Version:
• Device: [e.g Desktop] all of devices
• OS@version (or Browser):
• Node And NPM Version:

Description

I found a TypeError occurs when parsing a Markdown document with footnotes after parsing a Markdown document without footnotes using the same Marked object.

Error: making content2 raises error.
description: TypeError: Cannot read properties of undefined (reading 'filter')
Please report this to https://github.com/markedjs/marked.
    at Object.tokenizer (https://cdn.jsdelivr.net/npm/[email protected]:7:1092)
    at https://cdn.jsdelivr.net/npm/[email protected]:7:22564
    at Array.some (<anonymous>)
    at ne.inlineTokens (https://cdn.jsdelivr.net/npm/[email protected]:7:22548)
    at ne.lex (https://cdn.jsdelivr.net/npm/[email protected]:7:19159)
    at lex (https://cdn.jsdelivr.net/npm/[email protected]:7:18986)
    at oe.parse (https://cdn.jsdelivr.net/npm/[email protected]:7:33689)
    ...

The error does not occur in version 1.2.0.

To Reproduce (⚠️ read below)

Parse a Markdown document with footnotes after parsing a Markdown document without footnotes using the same Marked object.

https://replit.com/@krymtkts/marked-footnote-repro2#index.html

Expected Behavior

No errors occurs.

Actual Behavior

An error occurs.

Additional Information

import { Marked } from 'marked'
import { markedHighlight } from 'marked-highlight' // Code highlighting
import markedFootnote from 'marked-footnote' // Footnotes
import hljs from 'highlight.js'
import type { SynchronousOptions } from 'marked-highlight' // Code highlighting options

const optionHighlight: SynchronousOptions = {
  langPrefix: 'hljs language-',
  highlight(code, lang) {
    const language = hljs.getLanguage(lang) ? lang : 'plaintext'
    return hljs.highlight(code, { language }).value
  },
}

const marked = new Marked()

marked.use(
  markedFootnote(),
  markedHighlight(optionHighlight),
)

console.log("has content====>", marked.parse(`
# heading1
\`\`\`javascript
const highlight = "code";
\`\`\`
`))

console.log("no cotent ====>", marked.parse(`
\`\`\`javascript
const highlight = "code";
\`\`\`
`))


/*
You update the plugins very timely. I discovered an issue while using it.
1. When there is no content before a block of code, marked parsing causes the code highlighting plugin highlight.js to fail.
2. When there is content before a block of code, marked parsing works fine and the code highlighting plugin highlight.js works normally.
3. When there is no content before inline code, comment out line 18 markedFootnote plugin, marked parsing works fine, and the code highlighting plugin highlight.js works normally.

Why does the markedFootnote plugin affect the highlight.js plugin? Could you please take a look for me? Thank you.
I've also tried to replace the order of the plugins in the use method but still couldn't solve the problem.


When there is content before a code block, correct parsing result
has content====> <h1>heading1</h1>
<pre><code class="hljs language-javascript"><span class="hljs-keyword">const</span> highlight = <span class="hljs-string">&quot;code&quot;</span>;
</code></pre>

When there is no content before a code block, incorrect parsing result.
no cotent ====> <pre><code class="hljs language-javascript">const highlight = &quot;code&quot;;
</code></pre>

When the markedFootnote plugin is commented out, all results are parsed correctly.

When there is content before a code block, correct parsing result
has content====> <h1>heading1</h1>
<pre><code class="hljs language-javascript"><span class="hljs-keyword">const</span> highlight = <span class="hljs-string">&quot;code&quot;</span>;
</code></pre>

When there is no content before a code block, correct parsing result
cotent ====> <pre><code class="hljs language-javascript"><span class="hljs-keyword">const</span> highlight = <span class="hljs-string">&quot;code&quot;</span>;
</code></pre>
*/

bug description

version

• marked:11.0.1
• marked-footnote:1.2.0
• marked-highlight:2.0.9
• highlight.js: 11.9.0

You update the plugins very timely. I discovered an issue while using it.

1. When there is no content before a block of code, marked parsing causes the code highlighting plugin highlight.js to fail.
2. When there is content before a block of code, marked parsing works fine and the code highlighting plugin highlight.js works normally.
3. When there is no content before inline code, comment out line 18 markedFootnote plugin, marked parsing works fine, and the code highlighting plugin highlight.js works normally.
4. The above TypeScript code can directly reproduce the bug.

Why does the markedFootnote plugin affect the highlight.js plugin? Could you please take a look for me? Thank you.
I've also tried to replace the order of the plugins in the use method but still couldn't solve the problem.

• When there is content before a code block, correct parsing result

<h1>heading1</h1>
<pre><code class="hljs language-javascript"><span class="hljs-keyword">const</span> highlight = <span class="hljs-string">&quot;code&quot;</span>;
</code></pre>

• When there is no content before a code block, incorrect parsing result.

<pre><code class="hljs language-javascript">const highlight = &quot;code&quot;;
</code></pre>

When the markedFootnote plugin is commented out, all results are parsed correctly.

• When there is content before a code block, correct parsing result

<h1>heading1</h1>
<pre><code class="hljs language-javascript"><span class="hljs-keyword">const</span> highlight = <span class="hljs-string">&quot;code&quot;</span>;
</code></pre>

• When there is no content before a code block, correct parsing result

<pre><code class="hljs language-javascript"><span class="hljs-keyword">const</span> highlight = <span class="hljs-string">&quot;code&quot;</span>;
</code></pre>

Here's a simple footnote,¹ and here's a longer one.²

github markdown Source code

Content parsed by github

Content parsed by your plugin

bug

Extension Name: marked-footnote
Extension Version: v1.1.3

Seeing your plugin is excellent, I've identified the following two issues.

• Please consider the above footnotes. On GitHub, the superscript in the main text for footnote markers should not display the content of the footnote but rather the sequential number of the footnote in the entire document.

• The writing of footnotes should not be constrained by their position before or after the main text. It should be decoupled to avoid the need to constantly check if the footnote order is correct.

I would greatly appreciate it if you could address these two points. Thank you very much.

• Extension Name: marked-directive
• Extension Version: 1.0.4

Use case

Need to be able to use in a browser without npm. Not everyone is using Node and npm to build small use case apps.

Proposal

Please make a build that supports ems browser module import.

• Extension Name: marked-footnote
• Extension Version: v1.1.2
• Project Version:
• Device: [e.g Desktop] all of devices
• OS@version (or Browser): Windows 11 Home 23H2 22631.2715
• Node And NPM Version:

Description

The Markdown link seems to be preventing the footnotes generation.

Specifically, [ causes a bug.

To Reproduce (⚠️ read below)

https://replit.com/@krymtkts/marked-footnote-repro#index.html

<!doctype html>
<html lang="en">
  <body class="markdown-body">
    <div id="content"></div>

    <script src="https://cdn.jsdelivr.net/npm/marked/marked.min.js"></script>
    <script src="https://cdn.jsdelivr.net/npm/marked-footnote/dist/index.umd.min.js"></script>
    <script>
      const md = `# Example

[^1]: works fine.

[^2]: not work with [link](https://github.com/bent10/marked-extensions/tree/main/packages/footnote).

it works fine[^1]. not work with link[^2].
`

      document.getElementById("content").innerHTML = new marked.Marked()
        .use(markedFootnote())
        .parse(md)
    </script>
  </body>
</html>

Expected Behavior

Footnotes are not generated.

Actual Behavior

Footnotes are generated.

Additional Information

• Extension Name: marked-alert
• Extension Version: 1.2.1

Use case

https://github.com/orgs/community/discussions/16925

Proposal

GitHub seems to have added support for rendering [!TIP] and [!CAUTION].
It would be greatly appreciated if marked-alert could follow suit.