benjamin-klamerek / fantasy-realm-scoring Goto Github PK

Hi, I really like the work you are did and wanted to help at least a little, although I'm not really familiar with GitHub (yet).
Below I've added the translated file for the german version and I already have included a translation for the Jester promo card, which seems to be not in there yet.
I hope this helps.
Also, GitHub won't allow me to upload a .xml file directly, so a .zip must do for now.

strings.zip

The Phoenix that comes with the deluxe edition has been re-worded so it cannot be blanked by cards other than floods. The current Phoenix appears to be missing this property.

It would take out a lot of guesswork if card lists would show bullet numbers. You'd know at a glance if all cards have been scanned

Sorry for not digging or doing a good check on this, so delete this if covered.
It seems the evaluation of the collector is prior to all effects, or doesn't account for book of changes or mirage.
Island (clearing wildfire)
Great flood
Fountain
Wildfire
Book of changes (making wildfire a flood)
Mirage (choosing great flood)
Collector (bonus of 40, showing only 4 floods)
Hmmm... Or maybe it's from the mirage selecting a card already present?
Thanks!

Unfortunately, I only have the German version of the game, so my description will relate to the card names in German language.
When having the building card "Verlies" (probably something like "dungeon" in english) the bonus for also having the magician "Hexenmeister" (might be "Warlock Lord") was not calculated. The other bonuses in this case (another building and a flood I believe) were summed up correctly.
Don't hesitate to ask for more specifics if you need any
Greetings and congratulations to a nice developed app!

Hi, I would like to add Ukrainian language to the app.

Hi! I love your app, great work :D Thank you!

We are currently in quarantine and playing a lot. My girlfriend just had a 325 Points-combination and I was wondering, how "special" that is (aka. how often this happens). As we are probably going to play a lot it would be nice, to create our own "database" of games (and be able to see our improvements, and get a better understanding for the game).

There could be a "new game" - button in the player-overview, which stores the current game and resets (or deletes) the current cards/scores for every player.

Btw.: Feel free to delete/ignore this issue/question/enhancement :) Have a great (rest of the) weekend!

For all the Undead cards that count cards in the discard area, it would be nice if it was possible to scan that, too.

Feature request to add a button on the page with selecting cards that change sorting by card number/base power (from 0 (Joker cards at the top) to 40 (Fire card at the bottom of the list))

Hey there,

I read the official documentation. They describe a scenario in the Q&A section where the following Cards are in the hand:

• Wildfire
• Blizzard
• Great Flood

According to the documentation the remaining active (not blanked) cards are: Blizzard and Wildfire, resulting in a total score of 65 (Blizzard=30 - 5 (from Wildfire), Wildfire=40).
The app however shows that both Great Flood and Wildfire are blanked, resulting in a total score of 30.

The last update from the App I'm using is from 06.01.2022.

Thanks for looking into this!

Cheers 😄

Scan can generate a crash on some phones :

FATAL EXCEPTION: main
Process: com.klamerek.fantasyrealms, PID: 29872
java.lang.IllegalArgumentException: x + width must be <= bitmap.width()
at android.graphics.Bitmap.createBitmap(Bitmap.java:796)
at android.graphics.Bitmap.createBitmap(Bitmap.java:762)
at com.google.mlkit.vision.common.internal.ImageConvertUtils.zza(com.google.mlkit:vision-common@@16.5.0:1)
at com.google.mlkit.vision.common.internal.ImageConvertUtils.convertJpegToUpRightBitmap(com.google.mlkit:vision-common@@16.5.0:10)
at com.google.mlkit.vision.common.InputImage.fromMediaImage(com.google.mlkit:vision-common@@16.5.0:10)
at com.klamerek.fantasyrealms.screen.ScanActivity$MyImageCapturedCallback.onCaptureSuccess(ScanActivity.kt:91)
at androidx.camera.core.ImageCapture$ImageCaptureRequest.lambda$dispatchImage$0$ImageCapture$ImageCaptureRequest(ImageCapture.java:2395)
at androidx.camera.core.ImageCapture$ImageCaptureRequest$$ExternalSyntheticLambda1.run(Unknown Source:4)
at android.os.Handler.handleCallback(Handler.java:794)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:176)
at android.app.ActivityThread.main(ActivityThread.java:6662)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:547)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:873)

Seems linked to image format.

One example : Redmi 6A Android 8.1 (SDK 27) OpenGL ES ARM_V7

It seams that if you switch app and/or close the smartphone, Android may clean in-memory data (losing actual players and hands).

To improve usage, it could be good idea to improve the "persistence".
Warning : data must be cleaned when app is closed. We don't want a "hard" persist solution.