bengoblue05 / udacityalumni Goto Github PK

View Code? Open in Web Editor NEW

56.0 56.0 30.0 8.01 MB

Udacity Alumni Android App

Java 100.00%

udacityalumni's People

Contributors

Stargazers

Watchers

udacityalumni's Issues

Animation on User Click

https://github.com/BenGoBlue05/UdacityAlumni/blob/master/Todos/prof-pic-click.md

https://github.com/BenGoBlue05/UdacityAlumni/blob/master/app/src/main/java/com/google/developer/udacityalumni/fragment/ArticleFragment.java

FIX MEMORY LEAK - add post photos activity

ToDo: Add Share functionality to the detail/article pages

See ToDo in ArticleDetailActivity

Steps to reproduce

Open the app, select an article from the home screen and press the "Share" button on the toolbar.

Expected behaviour

I expect the share menu to appear so I can share a link to the article on the current page.

Actual behaviour

Nothing happens; a long press shows a Toast message.

Implement WebView

https://github.com/BenGoBlue05/UdacityAlumni/blob/master/app/src/main/java/com/google/developer/udacityalumni/activity/MainActivity.java

Under TODO's

Tapping on bookmark open the details activity

Steps to reproduce

Tap on the list item to go to detail view
Come back to list view.
Tap on bookmark.

Expected behavior

The list item should be bookmarked

Actual behavior

The list item gets bookmarked and the detail view is also shown

Code Sample

Problem probably in onLoadFinished() of MainActivity (https://github.com/BenGoBlue05/UdacityAlumni/blob/master/app/src/main/java/com/google/developer/udacityalumni/activity/MainActivity.java)

This should not be there in onLoadFinished():


startActivity(new Intent(this, ArticleDetailActivity.class)
                    .putExtra(getString(R.string.article_list_key), ids)
                    .putExtra(getString(R.string.article_bookmarks_key), isBookmarked)
                    .putExtra(getString(R.string.tag_key), tags));

Steps to reproduce

1)In the LoginActivity.java when i make the following changes-
a) Remove this line - findViewById(R.id.sign_in_button).setOnClickListener(this);
b)And use @OnClick annotation on sign_in_button because we are using butterknife library why doesn't the button respond to the click?

Expected behavior

Button click should be noticed

Actual behavior

Button does not respond. There is no crash as such. It is just a doubt

Code Sample

I changed the LoginActivity.java file to this -

package com.google.developer.udacityalumni.activity;

import android.content.Intent;
import android.os.Bundle;
import android.support.annotation.NonNull;
import android.support.v4.content.ContextCompat;
import android.util.Log;
import android.view.View;
import android.widget.Toast;

import com.google.android.gms.auth.api.Auth;
import com.google.android.gms.auth.api.signin.GoogleSignInAccount;
import com.google.android.gms.auth.api.signin.GoogleSignInOptions;
import com.google.android.gms.auth.api.signin.GoogleSignInResult;
import com.google.android.gms.common.ConnectionResult;
import com.google.android.gms.common.api.GoogleApiClient;
import com.google.android.gms.tasks.OnCompleteListener;
import com.google.android.gms.tasks.Task;
import com.google.developer.udacityalumni.R;
import com.google.developer.udacityalumni.model.User;
import com.google.firebase.auth.AuthCredential;
import com.google.firebase.auth.AuthResult;
import com.google.firebase.auth.FirebaseAuth;
import com.google.firebase.auth.FirebaseUser;
import com.google.firebase.auth.GoogleAuthProvider;
import com.google.firebase.database.DatabaseReference;
import com.google.firebase.database.FirebaseDatabase;

import butterknife.OnClick;

/**
 * A login screen that offers login via email/password.
 */
public class LoginActivity extends BaseActivity implements GoogleApiClient.OnConnectionFailedListener {

    private static final String LOG_TAG = LoginActivity.class.getSimpleName();

    private static final int RC_SIGN_IN = 9001;
    private GoogleApiClient mGoogleApiClient;
    private FirebaseAuth mAuth;
    private DatabaseReference mDatabase;
    private FirebaseAuth.AuthStateListener mAuthListener;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_login);
        getWindow().setStatusBarColor(ContextCompat.getColor(this, R.color.colorPrimaryDark));
        mAuth = FirebaseAuth.getInstance();
        mDatabase = FirebaseDatabase.getInstance().getReference();
        GoogleSignInOptions gso = new GoogleSignInOptions.Builder(GoogleSignInOptions.DEFAULT_SIGN_IN)
                .requestIdToken(getString(R.string.default_web_client_id))
                .requestEmail()
                .build();

        mGoogleApiClient = new GoogleApiClient.Builder(this)
                .enableAutoManage(this, this /* OnConnectionFailedListener */)
                .addApi(Auth.GOOGLE_SIGN_IN_API, gso)
                .build();

        mAuthListener = new FirebaseAuth.AuthStateListener() {
            @Override
            public void onAuthStateChanged(@NonNull FirebaseAuth firebaseAuth) {
                FirebaseUser user = firebaseAuth.getCurrentUser();
                if (user != null) bindUserValues(user);
            }
        };
    }

    private void bindUserValues(@NonNull FirebaseUser user) {
        DatabaseReference ref = mDatabase.child("users").child(user.getUid());
        String displayName = user.getDisplayName();
        String email = user.getEmail();
        String photoUrl = user.getPhotoUrl() != null ? user.getPhotoUrl().toString() : null;
        User usr = new User(displayName, email, photoUrl);
        ref.setValue(usr);
    }

    @OnClick(R.id.sign_in_button)
    public void signInButtonClicked(){
        Log.i("TAG", "signInButtonClicked: ");
        signIn();
    }

    private void signIn() {
        Intent signInIntent = Auth.GoogleSignInApi.getSignInIntent(mGoogleApiClient);
        startActivityForResult(signInIntent, RC_SIGN_IN);
    }

    @Override
    public void onActivityResult(int requestCode, int resultCode, Intent data) {
        super.onActivityResult(requestCode, resultCode, data);

        if (requestCode == RC_SIGN_IN) {
            GoogleSignInResult result = Auth.GoogleSignInApi.getSignInResultFromIntent(data);
            if (result.isSuccess()) {
                GoogleSignInAccount account = result.getSignInAccount();
                firebaseAuthWithGoogle(account);
            } else {
                Log.e(LOG_TAG, "Google Sign In failed.");
            }
        }
    }


    private void firebaseAuthWithGoogle(GoogleSignInAccount acct) {
        Log.d(LOG_TAG, "firebaseAuthWithGoogle:" + acct.getId());
        showProgressDialog();
        AuthCredential credential = GoogleAuthProvider.getCredential(acct.getIdToken(), null);
        mAuth.signInWithCredential(credential)
                .addOnCompleteListener(this, new OnCompleteListener<AuthResult>() {
                    @Override
                    public void onComplete(@NonNull Task<AuthResult> task) {
                        Log.i(LOG_TAG, "signIn:onComplete:" + task.isSuccessful());
                        hideProgressDialog();
                        if (!task.isSuccessful()) {
                            Log.i(LOG_TAG, "signInWithCredential", task.getException());
                            Toast.makeText(LoginActivity.this, "Authentication failed.",
                                    Toast.LENGTH_SHORT).show();
                        }
                        startActivity(new Intent(LoginActivity.this, MainActivity.class));
                    }
                });
    }


    @Override
    public void onConnectionFailed(@NonNull ConnectionResult connectionResult) {
        // An unresolvable error has occurred and Google APIs (including Sign-In) will not
        // be available.
        Log.d(LOG_TAG, "onConnectionFailed:" + connectionResult);
        Toast.makeText(this, "Google Play Services error.", Toast.LENGTH_SHORT).show();
    }

    @Override
    public void onStart() {
        super.onStart();
        mAuth.addAuthStateListener(mAuthListener);
    }

    @Override
    public void onStop() {
        super.onStop();
        if (mAuthListener != null) {
            mAuth.removeAuthStateListener(mAuthListener);
        }
    }
}

Add Firebase Storage to Posts

Create Firebase DB for Capstone Section

Convert rest to graphql request

Empty tag list in json causes App crash

Steps to reproduce

when article have empty tags list, It causes App Crash

365/com.google.developer.udacityalumni E/AndroidRuntime: FATAL EXCEPTION: IntentService[AlumIntentService]
                                                                                  Process: com.google.developer.udacityalumni, PID: 1239
                                                                                  java.lang.IllegalArgumentException: n <= 0: 0
                                                                                      at java.util.Random.nextInt(Random.java:182)
                                                                                      at com.google.developer.udacityalumni.service.AlumIntentService.addArticles(AlumIntentService.java:54)
                                                                                      at com.google.developer.udacityalumni.service.AlumIntentService.onHandleIntent(AlumIntentService.java:108)
                                                                                      at android.app.IntentService$ServiceHandler.handleMessage(IntentService.java:66)
                                                                                      at android.os.Handler.dispatchMessage(Handler.java:102)
                                                                                      at android.os.Looper.loop(Looper.java:148)
                                                                                      at android.os.HandlerThread.run(HandlerThread.java:61)

check last article item in json response

Expected behavior

AlumIntentService should check for empty tag list in json response before using it.

Transitions

Remove JSONObject Matching in AlumIntentService with Gson

Steps to reproduce

Right now in AlumIntentService we are casting the JSONObject and JSONArray.

Expected behavior

Json String Casting can be done many ways, but Gson is the best one for now.

Actual behavior

it will be easy for any buddy to just call a method of from Utils to serialize the Json String to Java Object.

Replace Webview for Custom Tabs

Add Comments to Posts

Basic DI setup

It would be nice if the project has a DI setup in place. Not only it will help in development and following best practices but can also be a starting point for developers and students new to the term.

Regarding minSDKVersion

Should be minSDKVersion be as high as 21? I believe it should be 16 or 17 so that the app runs on more than 95% of the devices. @BenGoBlue05

Add Apps Tab w/BottomNav to Main

add_animation_on_recycler_view

Steps to reproduce

What are steps we can follow to reproduce this issue?

Expected behavior

What did you expected to happen?

Actual behavior

What did happened instead?
e.g. the stack trace of a crash

Code Sample

Provide a code sample or test case that highlights the issue.
If relevant, include your model definitions.
For larger code samples, links to external gists / repositories are preferred.

Add Notifications for Spotlight Articles

UI Testing (RecyclerView)

https://github.com/BenGoBlue05/UdacityAlumni/blob/master/app/src/androidTest/java/com/google/developer/udacityalumni/ArticleRvTest.java

https://github.com/BenGoBlue05/UdacityAlumni/blob/master/app/src/androidTest/java/com/google/developer/udacityalumni/MainActivityNavViewTest.java

Add Fab above bottom nav on apps tab

App crashes on first load with IllegalArgumentException

Steps to reproduce

Open the application. Shortly after loading the home page, the application will crash with the following LogCat message:

java.lang.IllegalArgumentException: n <= 0: 0
    at java.util.Random.nextInt(Random.java:182)
    at com.google.developer.udacityalumni.service.AlumIntentService.addArticles(AlumIntentService.java:55)
    at com.google.developer.udacityalumni.service.AlumIntentService.onHandleIntent(AlumIntentService.java:109)
    at android.app.IntentService$ServiceHandler.handleMessage(IntentService.java:66)
    at android.os.Handler.dispatchMessage(Handler.java:111)
    at android.os.Looper.loop(Looper.java:207)
    at android.os.HandlerThread.run(HandlerThread.java:61)

Other Information

The problem appears to be caused on this line in AlumIntentService:

JSONArray tags = article.getJSONArray(KEY_TAGS);
int ind = new Random().nextInt(tags.length());

If tags has a length of zero, then the application crashes as the nextInt() method in Random cannot accept zero as an argument.

Checking the JSON file at http://udacity-alumni-api.herokuapp.com/api/v1/articles shows what's likely causing the problem (note the empty tags array):

    {
      "id": 11,
      "title": "my title",
      "featured": false,
      "spotlighted": true,
      "content": "yo this is my story\n",
      "feature_image": "",
      "status": "draft",
      "slug": "my-title",
      "user": {
        "id": 15,
        "email": "[email protected]",
        "created_at": "2017-01-25T09:33:40.858Z",
        "updated_at": "2017-01-25T09:43:34.337Z",
        "name": "noah hall",
        "avatar": null,
        "role": "user",
        "bio": "",
        "public": true
      },
      "created_at": "2017-01-25T10:41:15.683Z",
      "updated_at": "2017-01-25T10:41:15.709Z",
      "tags": [
        
      ]
    }

Match exit animation to entry animation when opening Custom Tabs Browser

Steps to reproduce

Open the side navigation menu and select either My Classroom, Catlog or Success Stores to open the Chrome Custom Tabs browser. The browser will animate in by sliding from the right side of the screen to the left. Then exit by pressing back, and a different animation is used that is part-translation and part-fade.

It would be better to match the exit animation so it is a true reversal of the entry animation.

add timestamp to posts

add_share_article_button_click

Steps to reproduce

What are steps we can follow to reproduce this issue?

Expected behavior

What did you expected to happen?

Actual behavior

What did happened instead?
e.g. the stack trace of a crash

Code Sample

Provide a code sample or test case that highlights the issue.
If relevant, include your model definitions.
For larger code samples, links to external gists / repositories are preferred.

MVP architecture Implementation

Proposal for implementing the MVP architecture by Google or Ribot

We can follow any if them, I can take responsibility for this.

I am suggesting the MVP architecture then It will become easy to write the unit test and Integration test and without any architecture, It's very hard to write the test cases.

What do you think @BenGoBlue05 @PPartisan @chashmeetsingh

bengoblue05 / udacityalumni Goto Github PK

udacityalumni's People

Contributors

Stargazers

Watchers

Forkers

udacityalumni's Issues

Steps to reproduce

Expected behaviour

Actual behaviour

Steps to reproduce

Expected behavior

Actual behavior

Code Sample

Steps to reproduce

Expected behavior

Actual behavior

Code Sample

Steps to reproduce

Expected behavior

Steps to reproduce

Expected behavior

Actual behavior

Steps to reproduce

Expected behavior

Actual behavior

Code Sample

Steps to reproduce

Other Information

Steps to reproduce

Steps to reproduce

Expected behavior

Actual behavior

Code Sample

Proposal for implementing the MVP architecture by Google or Ribot

Recommend Projects

Recommend Topics

Recommend Org