beneggett / sportradar-api Goto Github PK

I stumbled upon this gem while attempting to make a fun little app that uses the SportRadar API. This seems like a very convenient way to call the API through Rails.

However, the MLB portion isn't really documented, and I'm sorta shooting in the dark as far as how to call different things.

I would love to update your documentation so that users of the gem can put it to good use, but I need something to start with. I called the gem with Sportradar::Api::Baseball::Mlb.new(event_id: "4ae1fd7c-c7f8-4c51-92b6-94af55a66b24").fetch, and got something, so I know I'm close. I only really need to call the full League Schedule and the Play-By-Play, and would be happy to add the docs as I go along. Any information you can give me would speed things up drastically.

Other than that, it looks like this gem will save me a great deal of time. Thanks!

Hi @beneggett
Very much enjoying your gem, thankyou!

I am just wondering about the sport_event_context in the current Soccer Extended API
Currently I am not able to access the round data from the match because it's tucked away in the sport_event_context.
So I was wondering if I were to provide you with a PR to do something like ..

.. you would accept it or would you only accept it if was more explicit eg,

.. or can I already access the round details and I just don't see how?
I know I can if I eg,

match = Sportradar::Api::Soccer::Match.new({ 'id' => 'sr:sport_event:36886649' })
match.get_summary 

but if I'm retrieving matches via eg,

season = Sportradar::Api::Soccer::Season.new({ 'id' => 'sr:season:99573'})
season.get_schedule
season.matches.each do |match|

the match instance does not seem to have anything round related?
I can see tournament_round but that is not applicable here (perhaps old API field).
Obviously I could just fork your gem, but I'd rather contribute if it's an option.

Any feedback appreciated.

Thanks.

Please update gem soccer lib to v3

Hey there, my team and I are going to be implementing golf with either this gem or sports_data_api, which is the gem we have used in the past. However it seems like this gem is being actively worked on. I forked it the other day to start to work on it, but ran into a few stumbling blocks which raises some concerns for us.

First, it seems like there were some api keys committed in the VCR cassettes.
Second, api keys are missing from the .env.sample file so as someone who is new to the project I had a hard time trying to figure out what I needed in my .env file. It would be very helpful to keep this file updated for new contributors.
Third, some of the tests don't actually seem to match the name of the test (see: live_images_test.rb#L21). I am just concerned that there are lot of cassettes that don't seem valid yet they are used in tests. Can someone explain the thought process here?
Lastly, I am a little concerned with all the puts statements committed around the codebase and I don't necessarily think that this is a good practice.

Let me know if you have any questions about my concerns. I would love to contribute, I just need to be sure that you all are open to my contributions.

Thanks!