benconstable / laravel-localize-middleware Goto Github PK

Hi, to the Author & all Users,

I've tried it and it doesn't work, and the "dynamic prefix" {$locale} seems to be not ever captured.

BenConstable\Localize\Determiners\Parameter

public function determineLocale(Request $request)
    {
        return $request->input($this->requestParam, $this->fallback);
    }

1. The $locale is not captured within the $request->input array.
2. In fact it was captured in the $request->segments() array.
3. But it's not under the name ($locale), instead it's just simply $segment[1] (EDIT: corrected index) if I put it there.

This package has its strength over Waavi/Translate, it's more organized, has "stacked" drivers, and it doesn't have the "string/model translation" that I don't need for now. But its weakness is that all the "default locale redirection" & "route integrity checks" are being left out, making it way less robust in handling most common routing cases.

I'll planning to either fork it or issue PR to enhance it. If the Author is still active here maybe we can chat. I don't have much free time to spare besides work, but just happen that I need it so why not share it too? (only if I'm confident that my stuff works in the end though...)

Thanks.

Is it possible to update composer to include Laravel 6.0?

The header determiner partially supports Accept-Language, but does not fully support RFC2616 14.4 (i.e language ranges and prefixes).

It'd be great to have a standalone determiner for Accept-Language that fully supports the RFC.

In addition to the other methods would be cool to have another way to set the locale.

Via Accept-Language header maybe?

It would be nice if we could set a precedence in determiners. Eg. first check for a cookie and if not exists then check for a parameter, then for a session key and finally for a header attribute.