ben-aaron188 / netanos Goto Github PK

I don't understand the rationale for two branches. Having the package.json in master would be useful for people wanting to find it (I had to search a bit to figure it out, especially as the URL on npm goes to a blob which isn't there). These two branches are also out of sync.

Related to openjournals/joss-reviews#283 (comment).

In the README, you suggest using $scriptDir as a variable for where the stanford NER parser was downloaded. However, I found it easier to just cd into that directory, and run this:

java -mx1000m -cp "./stanford-ner.jar:./lib/*" edu.stanford.nlp.ie.NERServer  -loadClassifier ./classifiers/english.muc.7class.distsim.crf.ser.gz -port 8080 -outputFormat inlineXML

I think using . is a bit cleaner and easier. Just an idea, this isn't a mandatory change for openjournals/joss-reviews#293.

Currently, I don't know if I can contribute to this code at all. Are you interested in long term maintenance?

A Code of Conduct would also be good.

Related to openjournals/joss-reviews#283 (comment).

These should be relatively easy to set up, as the API is not complicated. Adding one for each of the main methods would be fantastic, and then making them runnable through an npm script.

Related to openjournals/joss-reviews#283 (comment).

I am trying to setup netanos on my local machine but after putting the below command as mentioned in the documentation

java -mx1000m -cp "./stanford-ner.jar:lib/*" edu.stanford.nlp.ie.NERServer  -loadClassifier classifiers/english.muc.7class.distsim.crf.ser.gz -port 8080 -outputFormat inlineXML

I am getting this error

Could not find or load main class edu.stanford.nlp.ie.NERServer

I am using windows 10 and have java version "1.8.0_301" installed.

Can anyone help me in resolving this issue?

In https://github.com/ben-aaron188/netanos/blob/master/paper/paper.md, you have some references. Each should have a DOI to point to, as well. If there aren't any, state that here and close this.

Related to openjournals/joss-reviews#293.

Instead of specifying in the README which modules the user needs to download, run this command:

npm install --save ner
npm install --save promise

And commit the changed package.json file. This way, in the future, the user can just run npm i.

Related to openjournals/joss-reviews#293.