keyboard navigation is broken since #54

https://github.com/bem/bem-react-components/blob/master/blocks/Modal/Modal.js#L14

modal never get attrs : { role : 'dialog' }

let's use:
https://github.com/theprotein/benzyne

It's more nature to have "link" semantic prior to "button" representation.

I suppose bug occurred here: #28

Hi guys,

For some reason, if I define the mix prop on Modal block it doesn't extend the actual block:

export default decl({
  block: 'MyModal',

  render () {
    return (
      <Modal mix={{block: this.block}}>
        Modal content
      </Modal>
    )
  }
})

Could you please have a look into this issue?

Cheers,
E

https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html

• _mode
  • _check
  • _radio
  • _radio-check
• _focused
• _disabled
• -Button
• -Control
• -Menu
• aria
• keyboard navigation
  • item select by arrows
  • fuzzy search?

Implement https://github.com/storybooks/storybook with blackjack and ...

• react version: 16.2.0
• react-dom version: 16.2.0
• bem-react-components version: master

Description:

When popup is rendered, the value of this._domNode is null. An error occurs here.

Uncaught TypeError: Cannot read property 'offsetWidth' of null (Popup_target.js:105)

This is most likely due to the fact that the render method in Portal-Popup returns null. Removing the method should solve the problem. Alternatively, you can use ReactDom.createPortal for react 16.

• position
• nested
• zIndex groups
• check visibility of anchor
• requestHide -> onHide, requestShow -> onShow

https://github.com/bem-tools/bem-tools-create

/cc @vithar @tadatuta

Seems like npm run build broken. At first, it failed with

ERROR in ./~/bem-react-core/index.js
Module build failed: ReferenceError: Unknown plugin "transform-object-assign" specified in "/Users/dndushkin/open-source/bem-react-components/node_modules/bem-react-core/.babelrc" at 1, attempted to resolve relative to "/Users/dndushkin/open-source/bem-react-components/node_modules/bem-react-core"

After $ npm i babel-plugin-transform-object-assign.

$ npm run build
ERROR in ./~/bem-react-core/dist/index.js
Module build failed: ReferenceError: [BABEL] /Users/dndushkin/open-source/bem-react-components/node_modules/bem-react-core/dist/index.js: Unknown option: /Users/dndushkin/open-source/bem-react-components/node_modules/react/react.js.Children. Check out http://babeljs.io/docs/usage/options/ for more information about options.

A common cause of this error is the presence of a configuration options object without the corresponding preset name. Example:

Invalid:
  `{ presets: [{option: value}] }`
Valid:
  `{ presets: [['presetName', {option: value}]] }`

Is it bem-loader issue?

one of possible solutions:

bem/bem-react#140

getScrollParents
_calcAnchorVisible

• _mode
  • _check
  • _radio
  • _radio-check
• _focused
• _disabled
• Item
  • _type_link
  • _focused
  • _disabled
• Group
• aria

• Readme.[ru,en].md
• Contributind.[ru,en].md
• License.txt cp

And live reload ;)

Missing html files when run npm run build, 'cos file-loader regex not include backslash.

• link
• button
• input
• textarea
• checkbox
• checkbox-group
• radio
• radio-group
• menu
• popup
• dropdown
• select
• icon
• image
• modal
• spin
• progressbar
• attach
• z-index-group
• interfaces
  • stylable
  • focusable
  • hoverable
  • ? pressable

For fast testing

popup.onClick -> go up to each parent and set flag as in bem-components
then check this flag inside doc.click as in bc

Hi guys,

Recently stumble upon the problem where I was trying to test my own blocks that imports the bem-react-components and in order to make it work make sure you got the following configuration:

.babelrc

{
  "presets": [
    "es2015",
    "react-app"
  ],
  "env": {
    "test": {
      "plugins": [
        [
          "bem-import",
          {
            "techs": [
              "js"
            ]
          }
        ]
      ]
    }
  }
}

.bemrc

{
  "root": true,
  "levels": {
    "src/components": {
      "scheme": "nested",
      "default": true
    },
    "node_modules/bem-react-components/blocks": {
      "scheme": "nested",
      "default": true
    }
  }
}

package.json

{
  ...
  "devDependencies": {
    ...
    "babel-plugin-bem-import": "1.4.2",
    "babel-preset-es2015": "6.24.1",
    ...
  },
  "jest": {
    "verbose": true,
    "transformIgnorePatterns": [
      "node_modules/(?!bem-react-components)"
    ]
  },
  "scripts": {
    "test": "jest"
  }
}

The main thing here is to compile bem-react-components that are located in node_modules. Hope that will help someone!

Cheers,
E

We need to precompile code before publish ;)

Rewrite Bem import from import Bem from .... to import { Bem } from ....