The mqlite from beluki

mqlite's People

Contributors

Stargazers

Watchers

mqlite's Issues

Suggestion for refactoring

Apologies if I sound a bit blocky and bot-like in my comment, it's like 12:33AM where I am. See MQLite.py:425, a conditional is not needed as you have already stated all of the possible conditions in the __init__ function. Also in line 438, not wanting to sound like a pendant it is generally not recommended to put spaces after equals sign in function arguments. For WrapConstraintAnd you may implement it as the following which would be more intuitive:

class WrapConstraintAnd(object):
    def __init__(self, *conds):
        self.conds = conds

    def match(self, data):
        return all(k(data) for k in self.conds)

The long block of conditionals at line 529 may also be refactored into a dict:

class Compiler(object):
    # code here
    compilers = {bool: MatchEqual, dict: compile_dict, ...}

Also for caching classes like Pattern I usually implement the caching like the following:

class Pattern(object):
    def __init__(self, data):
        self._compiler = Compiler()
        self._data = data
        self._compiled = None

    def compile(self):
        pattern = self._compiled = self._compiler.compile(self._data)
        return pattern

    def match(self, data):
        return self._compiled.match(data) if self._compiled else self.compile().match(data)

Recommend Projects