Git Product home page Git Product logo

Comments (2)

akbertram avatar akbertram commented on August 16, 2024 1

This is great, Per!

from renjin.

perNyfelt avatar perNyfelt commented on August 16, 2024

I made an initial attempt here: https://github.com/perNyfelt/renjin/tree/java11

I did NOT do any modularization but tried to stay as close to the current implementation as possible. As a result, not many files needed to change.

Good things: it compiles and all tests pass.

Maybe problematic things:

  1. The Classloader after java 8 is no longer a URLClassloader and the module system makes this non-trivial to adress. To work around that I did:
  • In the gcc-bridge i introduced a dependency on the classgraph project to build a custom URLClassloader with all classpath elements to get Soot to work.
  • In the ForkedTestControllerTest I just changed getCurrentClassPath to do System.getProperty("java.class.path")
  • In test.local.file.R in the test.jar.resource function i changed the test for res:java/util/Map.class to res:org/renjin/sexp/AtomicVector.class. The reason is that res:java/util/Map.class resolves to jrt:///java.base/java/util/Map.class which the FileSystemManager cannot make sense of. There is a way to handle this in later versions of vfs2 but upgrading vf2 looked like a LOT of work. I am not sure of the use case for locating a jar for java internal classes (e.g. java.util.Map) - there really isn't one in the jigsaw world, however if this case is important, it is probably possible to do some magic with the help of ClassGraph.

So at least there is a buildable branch based on java 11. Comments and/or suggestions would be most welcome!

from renjin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.