bdecentgmbh / moodle-enrol_credit Goto Github PK

i set the default value as 5 , so that any new user get credit of 5 , but when i test it for new user , it appear in the user profile 5 credit as expected, but on a test course that i made a 5 credit require it show that the test user balance is zero , again from site admin when edit the user profile , and the log in with test user it works !

Stefan, potential bug. Moodle 3.8.6, latest plugin version. Phenomenon: Student has 100 credits, course price is 50 credits. Student purchases course, then balance is -50 credits (negative 50) and indeed he is not able to purchase any other courses, getting the message that credit balance is insufficient, so in fact -50 is recorded in the data base. Any ideas?

In the archive in Moodle DB README file is named README.txt which is fine but in your repo it is README.php
I think you should rename it to .txt or .md ;)

Ideally your repository name should be : moodle-{plugintype}_{pluginname}(https://docs.moodle.org/dev/Plugin_contribution_checklist#Code_repository_name)
Moreover source code should be at the repository root this way you could use Github releases (https://moodle.org/mod/forum/discuss.php?d=283910)

Hello,
Your plugins are perfect.
but I think it's not compatible with Moodle APP, Right?

I must use Web UI to purchase courses or use the "moodle-availability_credit" plugin.

Some of the tests run by the Moodle.org plugins db can be run via travis-ci on each commit in your github repo. Enabling Travis integration helps you to make sure future changes to your plugin will continue to follow the guidelines.

More information on this is here:
https://moodle.org/mod/forum/discuss.php?d=323384

but the short version:
grab this file:
https://github.com/moodlerooms/moodle-plugin-ci/blob/master/.travis.dist.yml
rename it as .travis.yml and put in the root of your github directory.
Go to:
https://travis-ci.org/profile/stefanscholz
Flick the switch for this repo.

then on every commit you make to github it will fire off a request to travis to run the tests in .travis.yml and will give you traffic lights beside each commit and generate a report.

something else you might want to change:
in .travis.yml the default file has this line:

env:
global:

MOODLE_BRANCH=MOODLE_35_STABLE
you might want to add other branches to that list - so you might want to change it something like:

env:
global:

MOODLE_BRANCH=MOODLE_34_STABLE
MOODLE_BRANCH=MOODLE_35_STABLE
MOODLE_BRANCH=MOODLE_36_STABLE

I'm running onto an issue when trying to do bulk enrol edition.

Exception - Class 'enrol_credit\context_course' not found

More information about this error
Debug info:
Error code: generalexceptionmessage
Stack trace:

    line 134 of /enrol/credit/classes/editselectedusers_operation.php: Error thrown
    line 199 of /user/action_redir.php: call to enrol_credit\editselectedusers_operation->process()

Hint :
context_course::instance => \context_course::instance ;)
I think same error will appear when reaching cache::make line 143