bdadam / optimizedwebfontloading Goto Github PK

Great code, playing with it now in WordPress. After setting it up I noticed error like the following in the Chrome dev tools console

Resource interpreted as Font but transferred with MIME type application/x-font-woff2

Looking through the JS I noticed this

var localStoragePrefix = 'x-font-' + fontName;

Isn't the official MIME type for this without the x- part? Changing this made the errors go away.

I am using this script on Sass Guidelines so I was wondering if you would consider releasing it to npm so that I can handle this as an actual dependency? Right now I had to copy your script in my assets folder, which is far from ideal.

If you accept to do so, it would be best to remove the supportsWoff2 function from your code and use woff2-feature-test from Filament Group (which you do already) as an actual dependency.

I am well willing to assist you in that if you feel the need.

Cheers.

First of all, thanks for your research and the script - using it on some sites and it works great so far.

On a recent project I did a lot of testing and especially on low bandwdith FOUT is quite annoying (at least for me). That's why I only apply the font if the user already has been on the page and the font is stored in localStorage.

I basically changed

loSto[localStorageCssKey] = styleElement.textContent = request.responseText;

to

loSto[localStorageCssKey] = request.responseText;

So maybe it's a good idea to add an option to apply the fonts only on second page load?

What do you think?