bchiang7 / halcyon-vscode Goto Github PK

Currently, the selected text in the terminal field has an opaque color:

I'm not sure what color we should use, but the property is called: terminal.selectionBackground

Thank you for contributing this great theme! It has the perfect amount of contrast. Great work.

Current Behavior

When the file explorer is the active side bar view, there is a ~2px difference between the topmost list group and the editor with tabs

Possible Solution

Setting the editorGroupHeader.tabsBorder key to #191E27 (the background of the side bar) seems to align the two areas

Hey, love this theme! You've done a fantastic job with everything but one thing that continues to annoy me is how I can't seem to change the linting underline shape. With most themes, the underlines are squiggly and as such I have associated squiggly lines with linting errors. However, halcyon has a squiggly line underlined by two other lines which reduces my ability to recognize errors. I know this is a personal preference but I was wondering if you could tell me how to disable those lines and only keep the squiggly? I haven't been able to figure it out.

The latest vscode version added inlay hints support (eg. parameter names now show when calling a function).
I've experimented and it seems that setting the text color to pure black and increasing the background alpha channel increases readability.
These are quick fixes through the dev tools CSS editor.
Before:

After setting text to black:

After also increasing the background alpha from 0.6 to 1:

You can enable inlay hints through this setting:

I really like the code block highlighting in JavaScript, Golang, and other files but it seems to be missing from HTML files.

In case I'm using the wrong terminology, I'm referring to this ...

HTML files have a very subtle highlighting but I really like this bold color. Is there any way this can be added to the theme?

Current:

Updated:

Fix I'm using:

{
          "scope": "entity.name.import.go",
          "settings": {
            "foreground": "#bae67e",
          }
}

There's a slight bug with self-closing tags in .vue files:

With Fix:

Textmate override I'm using:

I'm struggling with the selection of the green background color for code diffs on VS Code. The red backgound actually works great! The green however created a low contrast situation. When taken out of context like the following image, it doesn't look so bad but when it;s surrounded by the dark blue/indigo, it's rough on the eyes.

It seems like your version of the ayu mirage theme is not suffering from the same incomplete syntax coloring as vsccode-ayu (see ayu-theme/vscode-ayu#34). Have you improved it somehow?

The start free gitkraken trial button looks broken by default

Default state:

On hover state:

Github dark default theme:

when focusing in code blocks, it's line is not light enough, making it difficult to identify different indents / divs

I have no idea how to change the Customize and Learn section on the right side because I don't know how VSCode derives colors from the theme to skin and style UI components. But I know that light grey on bright yellow is hard to read.

I can look into it in a week or so to see if I can fix it. Wanted to drop this here in case I forgot.

Amazing theme, btw.

Hi!

I don't know if anyone else encountered this before, but I installed the theme on my windows machine today. Colors and almost all visuals looks pleasing, as expected. However I noticed that while I am using decorators on my classes, they automatically get formatted as an italic style. Example below:

http://puu.sh/zAnnR/e098ce6d0b.png

I tried a few things such as "editor.colorDecorators": false and a bunch of other stuff. Is there a way for me to disable this (possibly?) feature?

Thank you in advance!

Over the weekend, a dark artifact has begun showing on the document's background. This applies to new and existing documents and in split view.

When I open a menu and it appears over the Explorer/Search/etc. sidebar, the colors match too closely and it's difficult to see where one end and the other begins.

I think Ayu Mirage Bordered has a very slight border on the menus. Maybe something like that will help.

BTW, if this is the aesthetic that you prefer, then feel free to close this issue. Thanks again!

Currently, when using one of the supported language(e.g Javascript), there's a nice mix of colors. However, when using Go, the color blue is noticeably absent. I recommend changing the color of error value blue:

Code:

{
          "scope": [
            "storage.type.error.go"
          ],
          "settings": {
            "foreground": "#5ccfe6",
          }
}

For reference, here's what Go looks like without the change:

Environment: Windows 10, VSCode 1.19.1.
Halcyon version: 0.0.1

Problem: when typing xxxx -x (some program with parameter) in the terminal in VSCode, the -x syntax has the same color as the background, thus "disappears." See the attached picture.

The selected item in the code completion menu has the same backround as the rest of the items
v0.1.4

Example code:

import { GeneralOption, ICompany } from 'src/types';
import { RequestBase, ResponseBase } from 'src/utils';
import { api } from 'src/utils/api';

export const commonApi = api.injectEndpoints({
  endpoints: (build) => ({
    getProductCompanyList: build.query<
      ResponseBase<ICompany[]>,
      { search?: string; page?: number }
    >({
      query: ({
        search = '',
        page = -1,
      }: {
        search?: string;
        page?: number;
      }) => {
        return {
          url: `/products/companies`,
          method: 'GET',
          params: { search: search || null, page },
        };
      },
    }),
    getPaymentMethods: build.query<
      ResponseBase<GeneralOption[]>,
      RequestBase & { default?: number }
    >({
      query: (params) => {
        return {
          url: `/purchase-orders/payment-methods`,
          method: 'GET',
          params,
        };
      },
    }),
  }),
  overrideExisting: false,
});

export const { useGetProductCompanyListQuery, useGetPaymentMethodsQuery } =
  commonApi;

Screenshot:

Before:

After:

You can kind of see the text in this example but only because it's highly zoomed in.

Files/folders that are in .gitignore aren't reduced in opacity/saturation:

In the above image, dist and node_modules should be grayed out.