Discussed during release planning in April - see miro board for notes (GGRICS Roadmap Miro Board)

Given that I have published some products to be reported under the CIIP,
When logged in as an administrator, I want to be able to create a new version of the product, initially in draft and then publish it.

I want the new version of the product to be tied to the old one

TL;DR

Topics greatly improve the discoverability of repos; please add the short code from the table below to the topics of your repo so that ministries can use GitHub's search to find out what repos belong to them and other visitors can find useful content (and reuse it!).

Why Topic

In short order we'll add our 800th repo. This large number clearly demonstrates the success of using GitHub and our Open Source initiative. This huge success means its critical that we work to make our content as discoverable as possible; Through discoverability, we promote code reuse across a large decentralized organization like the Government of British Columbia as well as allow ministries to find the repos they own.

What to do

Below is a table of abbreviation a.k.a short codes for each ministry; they're the ones used in all @gov.bc.ca email addresses. Please add the short codes of the ministry or organization that "owns" this repo as a topic.

That's in, you're done!!!

How to use

Once topics are added, you can use them in GitHub's search. For example, enter something like org:bcgov topic:citz to find all the repos that belong to Citizens' Services. You can refine this search by adding key words specific to a subject you're interested in. To learn more about searching through repos check out GitHub's doc on searching.

Pro Tip 🤓

• If your org is not in the list below, or the table contains errors, please create an issue here.

• While you're doing this, add additional topics that would help someone searching for "something". These can be the language used javascript or R; something like opendata or data for data only repos; or any other key words that are useful.

• Add a meaningful description to your repo. This is hugely valuable to people looking through our repositories.

• If your application is live, add the production URL.

Ministry Short Codes

NOTE See an error or omission? Please create an issue here to get it remedied.

TL;DR

Topics greatly improve the discoverability of repos; please add the short code from the table below to the topics of your repo so that ministries can use GitHub's search to find out what repos belong to them and other visitors can find useful content (and reuse it!).

Why Topic

In short order we'll add our 800th repo. This large number clearly demonstrates the success of using GitHub and our Open Source initiative. This huge success means its critical that we work to make our content as discoverable as possible; Through discoverability, we promote code reuse across a large decentralized organization like the Government of British Columbia as well as allow ministries to find the repos they own.

What to do

Below is a table of abbreviation a.k.a short codes for each ministry; they're the ones used in all @gov.bc.ca email addresses. Please add the short codes of the ministry or organization that "owns" this repo as a topic.

That's in, you're done!!!

How to use

Once topics are added, you can use them in GitHub's search. For example, enter something like org:bcgov topic:citz to find all the repos that belong to Citizens' Services. You can refine this search by adding key words specific to a subject you're interested in. To learn more about searching through repos check out GitHub's doc on searching.

Pro Tip 🤓

• If your org is not in the list below, or the table contains errors, please create an issue here.

• While you're doing this, add additional topics that would help someone searching for "something". These can be the language used javascript or R; something like opendata or data for data only repos; or any other key words that are useful.

• Add a meaningful description to your repo. This is hugely valuable to people looking through our repositories.

• If your application is live, add the production URL.

Ministry Short Codes

NOTE See an error or omission? Please create an issue here to get it remedied.

Description:

Products cannot be deleted, they have to be drafted, published and then archived.
If a product is created by accident, and it has the same name as a currently published product, the only way to delete the draft product is to rename it, publish it and immediately archive it

Acceptance Criteria:

On the products page of the application, when adding a new product line and leaving it empty, the notification shows up 3 times

To reproduce

start a new application
go to the products page
click "add product"
click the product form field, then click away

Probability (1-5): 3

Effect (1-5): 1

The column width is not fixed, as a result when sorting / paginating through elements, the column width can change.

• This shuffles the position of elements that are expected to stay in the same place, in particular the search input boxes and the sort carets
• This reduces the visibility of the data and makes is difficult for the user to understand the change that just happened

To reproduce:

• as an admin, go to the Products and Benchmarks page
• sort by Product
• then sort by Benchmark (for example)

Expected outcome: the data is sorted in the table, the headers stay in place
Actual outcome: the headers move around with the content width

Note: this doesn't happen when the table contains all the rows (Pagination set to 100 items per page)

Comment (YT GGIRCS-2416):

unable to reproduce this (MacOS Chrome, Firefox or Safari) - could it be that it only occurs on extra-large monitors?

react-jsonschema-form's required fields validation is somehow getting bypassed - only in the form to edit an existing reporting year. The required fields are correctly specified in the JSON schema, and the required fields work as expected in the New Reporting Year dialog.

Instead of adding a form error saying each of the date fields are required (which blocks the form from being submitted), it allows you to submit, causing an error popup.

Impact on the user (affects admin only):
Minimal; the form data entered is not saved, due to the error, and it should work find it they re-opened the dialog to enter more complete information and edit again.

Probability (1-5): 2

Effect (1-5): 1

As an analyst,

When making a decision on an application, clicking on the icon of the button (the checkmark, ...), a null status for that application is registered in the database, making the application not accessible to anyone.

From https://youtrack.button.is/issue/GGIRCS-2121

...and identify slow queries (identify threshold for what slow means) or mutations, and find opportunities for optimization.

https://youtrack.button.is/issue/GGIRCS-2487

AC:

• In the excel load test report, identify and document which page hosts which query
• Create a short report that:
  • Describes very quickly the load testing methodology
  • Orders the queries by response time - slowest first
  • Confirm response time to qualify as a "slow" request is > 1s under load
• Create user stories to speed up the "slow" ones
• Identify if express server is a bottleneck (if it is the case, recommendation should be to add a HorizontalPodAutoscaler)

Stretch goal: (not included in estimate)

• Schedule a load testing presentation for the DevOps/Dev guild

Reference: back in 2019

need to make it so it's more reusable for us
make it schema-agnostic
rather than copy and pasting/find and replace
could make it into its own repo (BC Gov) as a whole
Needs refactoring
operational tests are still running on the schema defined inside the test file (are they useful?)

After #ggircs-2366 is done, schedule mtg with ICU for this task. PO also flagged that we could send info to SMEs in advance of the call to save some time.

• obtain latest spreadsheet, capture info about the work needed
• Setup meeting and include new ICU team members and GGIRCS team members new to working with metabase - example dashboard
• Record notes on what would be needed to create a dashboard according to the validation spreadsheet v1.6 - Guidance document for the spreadsheet HERE.
• Next steps: Fill in the Placeholder Epic (linked to this card) and break down into user stories to outline the work involved for this particular Metabase Dashboard.

Use the Org book to verify the Industry Reporter's company.
Copied from https://youtrack.button.is/issue/GGIRCS-566

Description

See comments in GGIRCS-1799 for relevant discussion

Following GGIRCS-1799, sessions do not expire if the user is active (send requests to the server). However, if they remain idle, or are simply viewing a page without interacting with it, they will get redirected to the login-redirect page.
This feature will display a toast message prompting them to extend their session. Clicking on the toast message would send a request to the server, automatically refreshing the session.
Reference: https://youtrack.button.is/issue/GGIRCS-1799

Acceptance Criteria

1. Given that I am logged in
   When I have not been active for 28 mins
   Then I should get a modal prompting me to extend my session

2. Given that I am seeing the modal
   When I click the 'remain active' button
   Then my session is extended for another 30 minutes

3. Given that I am seeing the modal
   When I click the 'logout' button
   Then my session ends immediately

Development Checklist

• follow above wireframe
• have as a full overlay

We decided to go ahead and ship the direct link to register for now without support for post-registration redirects, due to some difficulties that would add precious time to debug before impending use by the public (pull request). Those difficulties were:

• Return trip to /login after registering returns a 403 (however the user is still created, and subsequently clicking "Login" automatically logs them in).
• The login service improperly decodes the redirectTo query param. Not sure why or how relevant.

Probability (1-5):

Effect (1-5):

See discussion on GGIRCS-1767

The merge queue is the bottle neck (perhaps related to rebasing?).
We need to identify solutions and implement them this summer. Some of them are mergify or code... something. https://www.producthunt.com/alternatives/mergify

• a bot merges anything with the tag so it removes the manual element.

Adding a new image here destined for the wiki as the recommended workaround.

AC
Not using react bootstrap
Potential constraints (developers to elaborate)
Reach out to BC Design System team about contributing (what's the process?)

Reference links
https://github.com/button-inc/service-development-toolkit

Includes:

Deprecating outdated database records
Updating user documentation (including explanatory videos or GIFs)

https://youtrack.button.is/issue/GGIRCS-2337

No Project Lifecycle Badge found in your readme!

Hello! I scanned your readme and could not find a project lifecycle badge. A project lifecycle badge will provide contributors to your project as well as other stakeholders (platform services, executive) insight into the lifecycle of your repository.

What is a Project Lifecycle Badge?

It is a simple image that neatly describes your project's stage in its lifecycle. More information can be found in the project lifecycle badges documentation.

What do I need to do?

I suggest you make a PR into your README.md and add a project lifecycle badge near the top where it is easy for your users to pick it up :). Once it is merged feel free to close this issue. I will not open up a new one :)

After deleting yarn.lock & reinstalling the packages, yarn build fails.
It appears to be an issue with the styled-jsx package & css function syntax

Minor at this point

https://youtrack.button.is/issue/GGIRCS-1741

We are transitioning from YouTrack to ZenHub.
As a team member, I want to access a tracker that is in line with org best practices and guidelines

This function https://github.com/bcgov/cas-metascript/blob/master/test/get_broken_questions.js leverages the metabase api to check for any questions that are broken.
Explore a way to integrate this as an alert somewhere to let us know if any changes we make to metabase (or the underlying data in the database) have broken any questions along the way.

AC:

• a repeatable way to get a list of all the metabase questions that result in an error
• could be a manual check before deploying to prod (eg part of QA process) for first iteration
  • copy questions from prod into test
• (Stretch goal) - more automated way

This isn't so much a bug but an cognition issue but didn't know how else to categorize the type) The NAICS code interface used when adding an allowable products, uses a mix of terminology of 'required' and 'mandatory'. Suggest that we replace the former with the latter.

Probability (1-5): 5

Effect (1-5): 1

• have a searchable document or set of docs that contain all YT issues AND their comments. Comments pulled in may need to involve an API.

as discovered in #241 the xo process is ignoring the .storybook folder

Reporter: a reporter
Description:

I get an error saying my user name and email is already registered, I tried to login but of course I don’t know my password. I was able to reset my password but when I click on the link in my email it brings me to a page that says “you are already logged in” but when I go back to the CIIP main page it asks to login, but I still don’t know my password….

Additional information:
Discussion in GGIRCS-1801

As a reporter/analyst/admin, I want to have consistency across reporting years when product data (name, benchmark) change. See Miro board, 'NAICS - Products maintainability scratchpad'.

The set of features needed to prevent and manage the effects of deleting or archiving a NAICS code, product, or NAICS-product association.

• With the current implementation, when a NAICS code, a product or a NAICS-product association gets deleted/archived, it will result in errors/warnings displayed in previous years’ applications that use these deleted/archived items, even though that was valid at the time.

Figure out a permanent solution to dealing with enum types that are not recognized properly by metabase.
Issue on metabase github: metabase/metabase#7092
A comment in the github issue suggests a possible workaround, which we can try.

I am thinking that maybe setting the database search path in the metabase connection (if possible) might fix the issue

Probability (1-5): 2

Effect (1-5): 3

Context: ICU are looking to review the design of the CIIP website and seeking UX support to do so.

Pre-Design

• Conduct a discovery session with ICU team
• Connect with ICU's tech specialist about layout constraints
• Information architecture analysis (CIIF Webpage Redesign MiroBoard)

AC:

• reach out to our SME at ICU and determine the scope of work
• assess the website(s) in question
• make recommendations for content redesign

https://youtrack.button.is/issue/GGIRCS-1959

@hamzajaved Given the graphql schema is generated by Graphile do we need to have graphql-cli in the devDependencies?

emission form has a couple of missing entries in the ui:schema form data,
resulting in poor formatting in the displayed form (gasDescription and sourceTypeName)

To reproduce: visit any of the imported 2018 CIIP applications that contains emission data

fix here: https://github.com/bcgov/cas-ggircs-ciip-2018-extract/blob/develop/extract/json_schema/emission.json

Probability (1-5): 5

Effect (1-5): 1

To do:

• need separate accounts for Terraform (currently using Alec's)
• Setup a call with Neal Li since he has configured Dell ECS (Team Falcon) - after June 18
• Need to transfer the 3 service account secrets that Maral has (also Dylan D.)
• Maral to connect with Julian

Questions to answer:
What does our migration look like?
Which services are we moving over vs. leaving on google Cloud?

Once setup on GH, we'll go over:

• ZenHub Board: what view to use
• What each column means
• Epic Prioritization
• how to view what we are working on in the current sprint/what will likely be demoed at the sprint review.
• how ZH relates to our roadmap

Matthieu commented 22 Jun 2021 09:35
It's a minor priority, but still needed
https://youtrack.button.is/issue/GGIRCS-1746

This affects both CIIP and GGIRCS apps.
In practice, this only happens if we don't push changes of that app to prod for a month, and if the pod wasn't affected by any maintenance.
When it does happen, the app becomes inaccessible to a non-technical user.

To resolve this, instead of having the express server taking care of the SSL termination, our applications should rely on an nginx reverse proxy deployed in a sidecar pod. See the metabase deployment for an example

Probability (1-5): 2

Effect (1-5): 5

The new 'Attention required' warning on the right side of the forms has squished the forms. This has caused some vertical alignment issues with the inputs in the forms.
Inputs with longer titles that span 2 lines are not aligned with inputs with shorter titles that span only 1 line.
Screenshots attached.
Probably just needs some css or bootstrap fiddling.

Probability (1-5): 5

Effect (1-5): 1

There are Bootstrap color variants (with resulting background-color, border-color, and color styles) throughout the site that always need to be globally overridden to meet WCAG AA contrast. We should do these overrides once in the default layout, instead of haphazardly throughout the code base.

Ideally, we can then remove the inline overrides scattered everywhere.

Focus:

The issue comes mainly from Button and Badge components.
Implement overrides for the following non-accessible variants of both Button and Badge:

        .btn-primary
        .btn-success
        .btn-info
        .btn-link
        .btn-outline-warning (the regular .btn-outline is fine as-is)

I'm not sure what would be the point of implementing .btn-outline-light as it's practically invisible...
Ensure each of the related outline- variants are overridden with the same colors and pass AA contrast
Ensure all variants' :focus, :active, :hover, :disabled and .disabled states are also overridden with the accessible colors.

See discussion in GGIRCS-2405

As an admin
I want an interface that allows editing the fuel charge associated to each fuel
So when changes to the charges associated to individual fuels are applied I can easily make the change in CIIP

Background:
The fuel charges associated to each individual fuel originally went up at the same rate as the carbon tax's $/tCO2e rate. This stopped in 2020. The charges associated to each fuel are no longer linear and predictable. Having an interface where an admin can make the necessary changes on a fuel by fuel basis would be a better solution than having developers continually updating hardcoded data based on changes in the CTA.

Describe the Bug:

Required validations that would normally prevent submission, but which have been overridden with justification by the applicant, should be highlighted in red on the application review page. Currently, they are not.

Probability (1-5): 1

Effect (1-5): 3

Steps to reproduce the behaviour: submit an application with validation errors, by using the validation override. When viewing the submitted application, the errors should be visible, but they are not