bazelbuild / rules_jvm_external Goto Github PK
View Code? Open in Web Editor NEWBazel rules to resolve, fetch and export Maven artifacts
License: Apache License 2.0
rules_jvm_external's Issues
Examples in Bazel CI configuration don't seem to be building
Specifically, these tasks:
rules_jvm_external/.bazelci/presubmit.yml
Line 42 in 06c44b0
e.g. see the macos build https://buildkite.com/bazel/rules-jvm-external/builds/94#77947ca3-9c72-43f6-b3a0-e0e4ded66060
Use `coursier.bat` for Windows and `coursier` for *nix
https://github.com/coursier/coursier/releases provides a batch file for Windows. We should use that instead.
Fix Java integration tests to be compatible with OpenJDK 11
They were disabled in #127
exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //tests/integration:ArtifactExclusionsTest
-----------------------------------------------------------------------------
JUnit4 Test Runner
.E
Time: 0.009
There was 1 failure:
1) test_excludedArtifacts_notOnClassPath(com.jvm.external.ArtifactExclusionsTest)
java.lang.ClassCastException: class jdk.internal.loader.ClassLoaders$AppClassLoader cannot be cast to class java.net.URLClassLoader (jdk.internal.loader.ClassLoaders$AppClassLoader and java.net.URLClassLoader are in module java.base of loader 'bootstrap')
at com.jvm.external.ArtifactExclusionsTest.test_excludedArtifacts_notOnClassPath(ArtifactExclusionsTest.java:16)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at com.google.testing.junit.runner.internal.junit4.CancellableRequestFactory$CancellableRunner.run(CancellableRequestFactory.java:89)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
at com.google.testing.junit.runner.junit4.JUnit4Runner.run(JUnit4Runner.java:112)
at com.google.testing.junit.runner.BazelTestRunner.runTestsInSuite(BazelTestRunner.java:153)
at com.google.testing.junit.runner.BazelTestRunner.main(BazelTestRunner.java:84)
FAILURES!!!
Tests run: 1, Failures: 1
BazelTestRunner exiting with a return value of 1
JVM shutdown hooks (if any) will run now.
The JVM will exit once they complete.
-- JVM shutdown starting at 2019-04-25 09:29:31 --
Other logs: https://buildkite.com/bazel/rules-jvm-external/builds/390#b676ef53-ae08-46ce-ae22-a2d4bc336479
Use versionless name in jvm_import and don't use alias
I am using rules_scala and I have a target using alias for external dependencies.
scala_library(
name = "my_project",
srcs = glob(["src/main/**/*.scala"]),
visibility = ["//visibility:public"],
deps = [
"@maven//:com_box_box_java_sdk",
"@maven//:com_eclipsesource_minimal_json_minimal_json",
"@maven//:com_amazonaws_amazon_kinesis_connectors",
],
)
In rules_scala, there is a deps checker which will log a buildozer command to fix the deps. In my case for example, @maven//:com_amazonaws_amazon_kinesis_connectors is not used, so a command like
buildozer 'remove deps @mvn//:com_amazonaws_amazon_kinesis_connectors_1_3_0' //my_project:my_project
will be logged. However, the resolved deps name is used rather than the alias name, so buildozer fails to fix BUILD.bazel.
I investigated how deps checker works but I realized there is no easy fix in rules_scala. I am wondering why do we need alias in rules_jvm_external in first place?
Is it possible to have an option to use versionless name in jvm_import directly and don't use alias? It will solve the problem above easily.
Thanks.
maven scopes
Would it make sense to have a scope argument on the maven.artifact function for a more direct relationship to maven's scope types? The main benefit I would see is that it provides a direct mechanism to translate between Maven and Bazel without requiring people deep-diving into Bazel's dependency graph modeling upfront.
You're probably aware but the 6 scopes are:
- Compile (default).
- Provided.
- Runtime.
- Test.
- System.
- Import (not relevant to Bazel directly maybe to this tool).
Test and compile feel like they would basically be nops in terms of additional behaviour.
Runtime, Provided, and System could probably set neverlink=True but might need some more thought.
Feels roughly related to #132 ignoring the maven type.
Add support for jvm_import_external rule
This will allow adding support for others jvm language import rules like scala_import.
CC: @ittaiz
Make exposing annotation processors easy
Right now, all dependencies are downloaded into @maven workspace. This is great, until we need to include an annotation processor as a java_plugin: then we need to break out of the workspace and define our own rule --- it's no longer possible for someone to expect all third party dependencies to be in the same namespace, which opens the door for mistakes to be made in build files by people not aware that they need to include a different rule from a different workspace.
bazel-deps is similarly focused on "just downloading bits from maven" as rules_jvm_external but provides an processorClasses property, which exports the annotation processor as expected without impacting the UI exposed to people writing build files.
bazel_maven_repository solves the same problem less elegantly by allowing people to specify build file fragments.
The ideal solution would be a field on maven.artifact that allowed a list of annotation processor classes to listed (mirroring bazel-deps approach).
java_import invokes ijar, which clobbers inline functions in kotlin
Given bazelbuild/bazel#4549, the maven repository workspace shouldn't use java_import, but should use something similar to kt_jvm_import which does the same thing, but offers the compile_jar as the same as the regular jar. This will affect things like kotlin.test whose assertFailsWith<ExceptionType>() { throw ExceptionType() } inlines, and therefore needs the method bodies at compile-time.
unexpected keyword 'fail_on_missing_checksum' in call to maven_install(name = "maven", repositories = [], artifacts = [], fetch_sources = False, use_unsafe_shared_cache = False)
I met this error with WORKSPACE file:
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
RULES_JVM_EXTERNAL_TAG = "2.0.1"
RULES_JVM_EXTERNAL_SHA = "55e8d3951647ae3dffde22b4f7f8dee11b3f70f3f89424713debd7076197eaca"
http_archive(
name = "rules_jvm_external",
strip_prefix = "rules_jvm_external-%s" % RULES_JVM_EXTERNAL_TAG,
sha256 = RULES_JVM_EXTERNAL_SHA,
url = "https://github.com/bazelbuild/rules_jvm_external/archive/%s.zip" % RULES_JVM_EXTERNAL_TAG,
)
load("@rules_jvm_external//:defs.bzl", "maven_install")
maven_install(
artifacts = [
"com.github.pagehelper:pagehelper:4.1.6",
],
repositories = [
"https://jcenter.bintray.com/",
"https://repo1.maven.org/maven2",
],
fail_on_missing_checksum = False
)
And work on mac osx with bazel version:
$ bazel version
Build label: 0.25.0
Build target: bazel-out/darwin-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Wed May 1 21:47:49 2019 (1556747269)
Build timestamp: 1556747269
Build timestamp as int: 1556747269
should I upgrate bazel or rules_jvm_external? it seems the latest vesion now.
Artifact with classifier looking at wrong path
Hi,
I am trying to fetch some artifacts that have a classifier. Unfortunately, it seems as if this feature is not properly implemented.
For example:
maven.artifact(
group = "com.digitalasset",
artifact = "damlc",
version = "100.12.1",
classifier = "osx",
),
maven.artifact(
group = "com.digitalasset",
artifact = "damlc",
version = "100.12.1",
classifier = "linux",
)
Yields:
https://digitalassetsdk.bintray.com/DigitalAssetSDK/com/digitalasset/damlc/osx/damlc-osx.pom
https://digitalassetsdk.bintray.com/DigitalAssetSDK/com/digitalasset/damlc/linux/damlc-linux.pom
When according to: https://stackoverflow.com/a/47733421. It should yield:
https://digitalassetsdk.bintray.com/DigitalAssetSDK/com/digitalasset/damlc/100.12.1/damlc-100.12.1.pom
https://digitalassetsdk.bintray.com/DigitalAssetSDK/com/digitalasset/damlc/100.12.1/damlc-100.12.1-osx.jar
https://digitalassetsdk.bintray.com/DigitalAssetSDK/com/digitalasset/damlc/100.12.1/damlc-100.12.1-linux.jar
Support "orbit" package types
When using rules_jvm_external on a project pulling in an old version of Dropwizard ("io.dropwizard:dropwizard-core:0.7.1",), Bazel fails miserably because one of Dropwizard's declared dependencies in the POM being of package type orbit:
org.eclipse.jetty.orbit:javax.servlet:3.0.0.v201112011016
<groupId>org.eclipse.jetty.orbit</groupId>
<artifactId>javax.servlet</artifactId>
<version>3.0.0.v201112011016</version>
<name>Jetty Orbit :: Servlet API</name>
<description>
This artifact originates from the Orbit Project at Eclipse, it is an osgi bundle and is signed as well.
</description>
<packaging>orbit</packaging>
Fetching/resolving it with the coursier CLI works fine though. Should be an easy fix.
Generate an API reference for documentation
Add `maven_coordinates=` tag to targets
If you want to build a jar for upload that uses these rules, you need to generate a pom file. One way to do that is with this rule https://github.com/google/bazel-common/blob/f1115e0f777f08c3cdb115526c4e663005bec69b/tools/maven/pom_file.bzl
The way this rule works is it checks your dependencies for a tag in the format maven_coordinates={actual maven coordinates}. It would be useful if these rules propagated this tag (or some alternative solution to this) so that pom file generation could use the same coordinate values specified only once.
POM with binary type dependencies
The POM for DynamoDB local com.amazonaws:DynamoDBLocal:1.11.477 in https://s3-us-west-2.amazonaws.com/dynamodb-local/release includes some binary dependencies:
<dependency>
<groupId>com.almworks.sqlite4java</groupId>
<artifactId>libsqlite4java-linux-amd64</artifactId>
<version>${sqlite4java.version}</version>
<type>so</type>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>com.almworks.sqlite4java</groupId>
<artifactId>sqlite4java-win32-x64</artifactId>
<version>${sqlite4java.version}</version>
<type>dll</type>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>com.almworks.sqlite4java</groupId>
<artifactId>sqlite4java-win32-x86</artifactId>
<version>${sqlite4java.version}</version>
<type>dll</type>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>com.almworks.sqlite4java</groupId>
<artifactId>libsqlite4java-osx</artifactId>
<version>${sqlite4java.version}</version>
<type>dylib</type>
<scope>runtime</scope>
</dependency>So we get:
The artifact for com.almworks.sqlite4java:libsqlite4java-linux-amd64:so:1.0.392 was not downloaded. Perhaps its packaging type is
not one of: jar,aar,bundle,eclipse-plugin?
Are there any suggestions for handling transitive dependencies of this sort?
Scala Akka example tests are failing on Windows
PS C:\Users\jingwen\Code\rules_jvm_external\examples\scala_akka> bazel test //... --test_output=errors
INFO: Analysed 4 targets (0 packages loaded, 0 targets configured).
INFO: Found 2 targets and 2 test targets...
FAIL: //:test_test_suite_src_test_scala_hello_ConfigurationSpec.scala (see C:/users/jingwen/_bazel_jingwen/viloy4hd/execroot/__main__/bazel-out/x64_windows-fastbuild/testlogs/test_test_suite_src_test_scala_hello_ConfigurationSpec.scala/test.log)
INFO: From Testing //:test_test_suite_src_test_scala_hello_ConfigurationSpec.scala:
==================== Test output for //:test_test_suite_src_test_scala_hello_ConfigurationSpec.scala:
C:/users/jingwen/_bazel_jingwen/viloy4hd/execroot/__main__/bazel-out/x64_windows-fastbuild/bin/test_test_suite_src_test_scala_hello_ConfigurationSpec.scala: line 334: C:\users\jingwen\_bazel_jingwen\viloy4hd\execroot\__main__\bazel-out\x64_windows-fastbuild\bin\test_test_suite_src_test_scala_hello_ConfigurationSpec.scala.runfiles/local_jdk/bin/jar.exe: No such file or directory
C:/users/jingwen/_bazel_jingwen/viloy4hd/execroot/__main__/bazel-out/x64_windows-fastbuild/bin/test_test_suite_src_test_scala_hello_ConfigurationSpec.scala: line 83: printf: missing unicode digit for \u
C:/users/jingwen/_bazel_jingwen/viloy4hd/execroot/__main__/bazel-out/x64_windows-fastbuild/bin/test_test_suite_src_test_scala_hello_ConfigurationSpec.scala: ERROR: /c/users/jingwen/_bazel_jingwen/viloy4hd/execroot/__main__/bazel-out/x64_windows-fastbuild/bin/test_test_suite_src_test_scala_hello_ConfigurationSpec.scala failed because C:\users\jingwen\_bazel_jingwen�iloy4hdecroot\__main_azel-outd_windows-fastbuilin est_test_suite_src_test_scala_hello_ConfigurationSpec.scala.runfiles/local_jdk/bin/jar.exe failed
================================================================================
FAIL: //:test_test_suite_src_test_scala_hello_EndpointSpec.scala (see C:/users/jingwen/_bazel_jingwen/viloy4hd/execroot/__main__/bazel-out/x64_windows-fastbuild/testlogs/test_test_suite_src_test_scala_hello_EndpointSpec.scala/test.log)
INFO: From Testing //:test_test_suite_src_test_scala_hello_EndpointSpec.scala:
==================== Test output for //:test_test_suite_src_test_scala_hello_EndpointSpec.scala:
C:/users/jingwen/_bazel_jingwen/viloy4hd/execroot/__main__/bazel-out/x64_windows-fastbuild/bin/test_test_suite_src_test_scala_hello_EndpointSpec.scala: line 334: C:\users\jingwen\_bazel_jingwen\viloy4hd\execroot\__main__\bazel-out\x64_windows-fastbuild\bin\test_test_suite_src_test_scala_hello_EndpointSpec.scala.runfiles/local_jdk/bin/jar.exe: No such file or directory
C:/users/jingwen/_bazel_jingwen/viloy4hd/execroot/__main__/bazel-out/x64_windows-fastbuild/bin/test_test_suite_src_test_scala_hello_EndpointSpec.scala: line 83: printf: missing unicode digit for \u
C:/users/jingwen/_bazel_jingwen/viloy4hd/execroot/__main__/bazel-out/x64_windows-fastbuild/bin/test_test_suite_src_test_scala_hello_EndpointSpec.scala: ERROR: /c/users/jingwen/_bazel_jingwen/viloy4hd/execroot/__main__/bazel-out/x64_windows-fastbuild/bin/test_test_suite_src_test_scala_hello_EndpointSpec.scala failed because C:\users\jingwen\_bazel_jingwen�iloy4hdecroot\__main_azel-outd_windows-fastbuilin est_test_suite_src_test_scala_hello_EndpointSpec.scala.runfiles/local_jdk/bin/jar.exe failed
================================================================================
INFO: Elapsed time: 3.911s, Critical Path: 2.98s
INFO: 4 processes: 4 local.
INFO: Build completed, 2 tests FAILED, 3 total actions
//:test_test_suite_src_test_scala_hello_ConfigurationSpec.scala FAILED in 1.9s
C:/users/jingwen/_bazel_jingwen/viloy4hd/execroot/__main__/bazel-out/x64_windows-fastbuild/testlogs/test_test_suite_src_test_scala_hello_ConfigurationSpec.scala/test.log
//:test_test_suite_src_test_scala_hello_EndpointSpec.scala FAILED in 2.2s
C:/users/jingwen/_bazel_jingwen/viloy4hd/execroot/__main__/bazel-out/x64_windows-fastbuild/testlogs/test_test_suite_src_test_scala_hello_EndpointSpec.scala/test.log
Make bazel download files
Coursier optimistically downloads every single jar file required when starting a build. When the number of dependencies is large, this can cause a significant delay before anything starts being built, particularly since jar files are significantly larger than pom files (on the whole)
If, instead, maven_install output an http_file for each jar or source jar required, builds could start a lot sooner and we could ensure that all downloads happen through Bazel's own mechanisms.
There doesn't appear to be a command line flag to make this happen automatically, but once we have resolved all the dependencies, the URLs to download from tend to be a simple transformation of the maven coordinates.
Add support for IntelliJ plugin's IDE providers
More info: bazelbuild/intellij#681
Examples breake with Python toolchains (Bazel 0.27)
Same as #157, but for the "rules_jvm_external - examples" test.
ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/8ab3d639e2adad62d28400e780405787/external/android_test_support/tools/android/emulated_devices/generic_phone/BUILD.bazel:43:1: Couldn't build file external/android_test_support/tools/android/emulated_devices/generic_phone/android_23_x86_qemu2_images/emulator-meta-data.pb: Creating Android image for @android_test_support//tools/android/emulated_devices/generic_phone:android_23_x86_qemu2 failed (Exit 1) unified_launcher_head failed: error executing command
--
| (cd /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/8ab3d639e2adad62d28400e780405787/sandbox/linux-sandbox/324/execroot/__main__ && \
| exec env - \
| bazel-out/host/bin/external/android_test_support/tools/android/emulator/unified_launcher_head '--action=boot' '--density=240' '--memory=2048' '--cache=32' '--vm_size=256' '--generate_output_dir=bazel-out/host/bin/external/android_test_support/tools/android/emulated_devices/generic_phone/android_23_x86_qemu2_images' '--skin=480x800' '--source_properties_file=external/androidsdk/system-images/android-23/default/x86/source.properties' '--system_images=external/androidsdk/system-images/android-23/default/x86/NOTICE.txt external/androidsdk/system-images/android-23/default/x86/advancedFeatures.ini external/androidsdk/system-images/android-23/default/x86/build.prop external/androidsdk/system-images/android-23/default/x86/kernel-qemu external/androidsdk/system-images/android-23/default/x86/kernel-ranchu external/androidsdk/system-images/android-23/default/x86/package.xml external/androidsdk/system-images/android-23/default/x86/ramdisk.img external/androidsdk/system-images/android-23/default/x86/system.img external/androidsdk/system-images/android-23/default/x86/userdata.img external/androidsdk/emulator/emulator external/androidsdk/emulator/lib/advancedFeatures.ini external/androidsdk/emulator/lib/advancedFeaturesCanary.ini external/androidsdk/emulator/lib/ca-bundle.pem external/androidsdk/emulator/lib/emu-original-feature-flags.protobuf external/androidsdk/emulator/lib/emulator_controller.proto external/androidsdk/emulator/lib/hardware-properties.ini external/androidsdk/emulator/lib/pc-bios/bios-256k.bin external/androidsdk/emulator/lib/pc-bios/bios.bin external/androidsdk/emulator/lib/pc-bios/efi-e1000.rom external/androidsdk/emulator/lib/pc-bios/efi-e1000e.rom external/androidsdk/emulator/lib/pc-bios/efi-virtio.rom external/androidsdk/emulator/lib/pc-bios/keymaps/Makefile external/androidsdk/emulator/lib/pc-bios/keymaps/ar external/androidsdk/emulator/lib/pc-bios/keymaps/bepo external/androidsdk/emulator/lib/pc-bios/keymaps/common external/androidsdk/emulator/lib/pc-bios/keymaps/cz external/androidsdk/emulator/lib/pc-bios/keymaps/da external/androidsdk/emulator/lib/pc-bios/keymaps/de external/androidsdk/emulator/lib/pc-bios/keymaps/de-ch external/androidsdk/emulator/lib/pc-bios/keymaps/en-gb external/androidsdk/emulator/lib/pc-bios/keymaps/en-us external/androidsdk/emulator/lib/pc-bios/keymaps/es external/androidsdk/emulator/lib/pc-bios/keymaps/et external/androidsdk/emulator/lib/pc-bios/keymaps/fi external/androidsdk/emulator/lib/pc-bios/keymaps/fo external/androidsdk/emulator/lib/pc-bios/keymaps/fr external/androidsdk/emulator/lib/pc-bios/keymaps/fr-be external/androidsdk/emulator/lib/pc-bios/keymaps/fr-ca external/androidsdk/emulator/lib/pc-bios/keymaps/fr-ch external/androidsdk/emulator/lib/pc-bios/keymaps/hr external/androidsdk/emulator/lib/pc-bios/keymaps/hu external/androidsdk/emulator/lib/pc-bios/keymaps/is external/androidsdk/emulator/lib/pc-bios/keymaps/it external/androidsdk/emulator/lib/pc-bios/keymaps/ja external/androidsdk/emulator/lib/pc-bios/keymaps/lt external/androidsdk/emulator/lib/pc-bios/keymaps/lv external/androidsdk/emulator/lib/pc-bios/keymaps/mk external/androidsdk/emulator/lib/pc-bios/keymaps/modifiers external/androidsdk/emulator/lib/pc-bios/keymaps/nl external/androidsdk/emulator/lib/pc-bios/keymaps/nl-be external/androidsdk/emulator/lib/pc-bios/keymaps/no external/androidsdk/emulator/lib/pc-bios/keymaps/pl external/androidsdk/emulator/lib/pc-bios/keymaps/pt external/androidsdk/emulator/lib/pc-bios/keymaps/pt-br external/androidsdk/emulator/lib/pc-bios/keymaps/ru external/androidsdk/emulator/lib/pc-bios/keymaps/sl external/androidsdk/emulator/lib/pc-bios/keymaps/sv external/androidsdk/emulator/lib/pc-bios/keymaps/th external/androidsdk/emulator/lib/pc-bios/keymaps/tr external/androidsdk/emulator/lib/pc-bios/kvmvapic.bin external/androidsdk/emulator/lib/pc-bios/linuxboot.bin external/androidsdk/emulator/lib/pc-bios/linuxboot_dma.bin external/androidsdk/emulator/lib/pc-bios/multiboot.bin external/androidsdk/emulator/lib/pc-bios/vgabios-cirrus.bin external/androidsdk/emulator/lib/pc-bios/vgabios-stdvga.bin external/androidsdk/emulator/lib/pc-bios/vgabios-virtio.bin external/androidsdk/emulator/lib64/gles_mesa/libGL.so external/androidsdk/emulator/lib64/gles_mesa/libGL.so.1 external/androidsdk/emulator/lib64/gles_swiftshader/libEGL.so external/androidsdk/emulator/lib64/gles_swiftshader/libGLES_CM.so external/androidsdk/emulator/lib64/gles_swiftshader/libGLESv2.so external/androidsdk/emulator/lib64/libEGL_translator.so external/androidsdk/emulator/lib64/libGLES12Translator.so external/androidsdk/emulator/lib64/libGLES_CM_translator.so external/androidsdk/emulator/lib64/libGLES_V2_translator.so external/androidsdk/emulator/lib64/libOpenglRender.so external/androidsdk/emulator/lib64/libc++.so external/androidsdk/emulator/lib64/libc++.so.1 external/androidsdk/emulator/lib64/libemugl_common.so external/androidsdk/emulator/lib64/libtcmalloc_minimal.so.4 external/androidsdk/emulator/lib64/libunwind-x86_64.so.8 external/androidsdk/emulator/lib64/libunwind.so.8 external/androidsdk/emulator/lib64/qt/lib/libQt5CoreAndroidEmu.so.5 external/androidsdk/emulator/lib64/qt/lib/libQt5DBusAndroidEmu.so.5 external/androidsdk/emulator/lib64/qt/lib/libQt5GuiAndroidEmu.so.5 external/androidsdk/emulator/lib64/qt/lib/libQt5NetworkAndroidEmu.so.5 external/androidsdk/emulator/lib64/qt/lib/libQt5PrintSupportAndroidEmu.so.5 external/androidsdk/emulator/lib64/qt/lib/libQt5SvgAndroidEmu.so.5 external/androidsdk/emulator/lib64/qt/lib/libQt5WidgetsAndroidEmu.so.5 external/androidsdk/emulator/lib64/qt/lib/libQt5XcbQpaAndroidEmu.so.5 external/androidsdk/emulator/lib64/qt/lib/libfreetype.so.6 external/androidsdk/emulator/lib64/qt/lib/libsoftokn3.so external/androidsdk/emulator/lib64/qt/lib/libsqlite3.so external/androidsdk/emulator/lib64/qt/lib/libxkbcommon.so external/androidsdk/emulator/lib64/qt/lib/libxkbcommon.so.0 external/androidsdk/emulator/lib64/qt/lib/libxkbcommon.so.0.0.0 external/androidsdk/emulator/lib64/qt/plugins/iconengines/libqsvgicon.so external/androidsdk/emulator/lib64/qt/plugins/imageformats/libqgif.so external/androidsdk/emulator/lib64/qt/plugins/imageformats/libqicns.so external/androidsdk/emulator/lib64/qt/plugins/imageformats/libqico.so external/androidsdk/emulator/lib64/qt/plugins/imageformats/libqjpeg.so external/androidsdk/emulator/lib64/qt/plugins/imageformats/libqsvg.so external/androidsdk/emulator/lib64/qt/plugins/imageformats/libqtga.so external/androidsdk/emulator/lib64/qt/plugins/imageformats/libqtiff.so external/androidsdk/emulator/lib64/qt/plugins/imageformats/libqwbmp.so external/androidsdk/emulator/lib64/qt/plugins/imageformats/libqwebp.so external/androidsdk/emulator/lib64/qt/plugins/platforminputcontexts/libcomposeplatforminputcontextplugin.so external/androidsdk/emulator/lib64/qt/plugins/platforms/libqxcb.so external/androidsdk/emulator/lib64/vulkan/glslangValidator external/androidsdk/emulator/lib64/vulkan/libvk_swiftshader.so external/androidsdk/emulator/lib64/vulkan/libvulkan.so external/androidsdk/emulator/lib64/vulkan/libvulkan.so.1 external/androidsdk/emulator/lib64/vulkan/shaders/EacR11Snorm_2DArray.spv external/androidsdk/emulator/lib64/vulkan/shaders/EacR11Snorm_3D.spv external/androidsdk/emulator/lib64/vulkan/shaders/EacR11Unorm_2DArray.spv external/androidsdk/emulator/lib64/vulkan/shaders/EacR11Unorm_3D.spv external/androidsdk/emulator/lib64/vulkan/shaders/EacRG11Snorm_2DArray.spv external/androidsdk/emulator/lib64/vulkan/shaders/EacRG11Snorm_3D.spv external/androidsdk/emulator/lib64/vulkan/shaders/EacRG11Unorm_2DArray.spv external/androidsdk/emulator/lib64/vulkan/shaders/EacRG11Unorm_3D.spv external/androidsdk/emulator/lib64/vulkan/shaders/Etc2RGB8_2DArray.spv external/androidsdk/emulator/lib64/vulkan/shaders/Etc2RGB8_3D.spv external/androidsdk/emulator/lib64/vulkan/shaders/Etc2RGBA8_2DArray.spv external/androidsdk/emulator/lib64/vulkan/shaders/Etc2RGBA8_3D.spv external/androidsdk/emulator/lib64/vulkan/vk_swiftshader_icd.json external/androidsdk/emulator/qemu/linux-x86_64/qemu-system-i386' --flag_configured_android_tools '--adb=external/androidsdk/platform-tools/adb' '--emulator_x86=external/androidsdk/emulator/emulator' '--emulator_arm=external/androidsdk/emulator/emulator' '--adb_static=external/bazel_tools/tools/android/fail.sh' '--mksdcard=external/androidsdk/emulator/mksdcard' '--empty_snapshot_fs=bazel-out/host/bin/external/bazel_tools/tools/android/emulator/snapshots.img' '--bios_files=external/androidsdk/emulator/lib/pc-bios/bios-256k.bin,external/androidsdk/emulator/lib/pc-bios/bios.bin,external/androidsdk/emulator/lib/pc-bios/efi-e1000.rom,external/androidsdk/emulator/lib/pc-bios/efi-e1000e.rom,external/androidsdk/emulator/lib/pc-bios/efi-virtio.rom,external/androidsdk/emulator/lib/pc-bios/kvmvapic.bin,external/androidsdk/emulator/lib/pc-bios/linuxboot.bin,external/androidsdk/emulator/lib/pc-bios/linuxboot_dma.bin,external/androidsdk/emulator/lib/pc-bios/multiboot.bin,external/androidsdk/emulator/lib/pc-bios/vgabios-cirrus.bin,external/androidsdk/emulator/lib/pc-bios/vgabios-stdvga.bin,external/androidsdk/emulator/lib/pc-bios/vgabios-virtio.bin' --nocopy_system_images --single_image_file '--android_sdk_path=external/androidsdk' '--platform_apks=' '--default_properties_file=bazel-out/host/bin/external/android_test_support/tools/android/emulated_devices/generic_phone/_android_23_x86_qemu2_props.properties')
| Execution platform: @bazel_tools//platforms:host_platform
|
| Use --sandbox_debug to see verbose messages from the sandbox: unified_launcher_head failed: error executing command
| (cd /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/8ab3d639e2adad62d28400e780405787/sandbox/linux-sandbox/324/execroot/__main__ && \
| exec env - \
| bazel-out/host/bin/external/android_test_support/tools/android/emulator/unified_launcher_head '--action=boot' '--density=240' '--memory=2048' '--cache=32' '--vm_size=256' '--generate_output_dir=bazel-out/host/bin/external/android_test_support/tools/android/emulated_devices/generic_phone/android_23_x86_qemu2_images' '--skin=480x800' '--source_properties_file=external/androidsdk/system-images/android-23/default/x86/source.properties' '--system_images=external/androidsdk/system-images/android-23/default/x86/NOTICE.txt external/androidsdk/system-images/android-23/default/x86/advancedFeatures.ini external/androidsdk/system-images/android-23/default/x86/build.prop external/androidsdk/system-images/android-23/default/x86/kernel-qemu external/androidsdk/system-images/android-23/default/x86/kernel-ranchu external/androidsdk/system-images/android-23/default/x86/package.xml external/androidsdk/system-images/android-23/default/x86/ramdisk.img external/androidsdk/system-images/android-23/default/x86/system.img external/androidsdk/system-images/android-23/default/x86/userdata.img external/androidsdk/emulator/emulator external/androidsdk/emulator/lib/advancedFeatures.ini external/androidsdk/emulator/lib/advancedFeaturesCanary.ini external/androidsdk/emulator/lib/ca-bundle.pem external/androidsdk/emulator/lib/emu-original-feature-flags.protobuf external/androidsdk/emulator/lib/emulator_controller.proto external/androidsdk/emulator/lib/hardware-properties.ini external/androidsdk/emulator/lib/pc-bios/bios-256k.bin external/androidsdk/emulator/lib/pc-bios/bios.bin external/androidsdk/emulator/lib/pc-bios/efi-e1000.rom external/androidsdk/emulator/lib/pc-bios/efi-e1000e.rom external/androidsdk/emulator/lib/pc-bios/efi-virtio.rom external/androidsdk/emulator/lib/pc-bios/keymaps/Makefile external/androidsdk/emulator/lib/pc-bios/keymaps/ar external/androidsdk/emulator/lib/pc-bios/keymaps/bepo external/androidsdk/emulator/lib/pc-bios/keymaps/common external/androidsdk/emulator/lib/pc-bios/keymaps/cz external/androidsdk/emulator/lib/pc-bios/keymaps/da external/androidsdk/emulator/lib/pc-bios/keymaps/de external/androidsdk/emulator/lib/pc-bios/keymaps/de-ch external/androidsdk/emulator/lib/pc-bios/keymaps/en-gb external/androidsdk/emulator/lib/pc-bios/keymaps/en-us external/androidsdk/emulator/lib/pc-bios/keymaps/es external/androidsdk/emulator/lib/pc-bios/keymaps/et external/androidsdk/emulator/lib/pc-bios/keymaps/fi external/androidsdk/emulator/lib/pc-bios/keymaps/fo external/androidsdk/emulator/lib/pc-bios/keymaps/fr external/androidsdk/emulator/lib/pc-bios/keymaps/fr-be external/androidsdk/emulator/lib/pc-bios/keymaps/fr-ca external/androidsdk/emulator/lib/pc-bios/keymaps/fr-ch external/androidsdk/emulator/lib/pc-bios/keymaps/hr external/androidsdk/emulator/lib/pc-bios/keymaps/hu external/androidsdk/emulator/lib/pc-bios/keymaps/is external/androidsdk/emulator/lib/pc-bios/keymaps/it external/androidsdk/emulator/lib/pc-bios/keymaps/ja external/androidsdk/emulator/lib/pc-bios/keymaps/lt external/androidsdk/emulator/lib/pc-bios/keymaps/lv external/androidsdk/emulator/lib/pc-bios/keymaps/mk external/androidsdk/emulator/lib/pc-bios/keymaps/modifiers external/androidsdk/emulator/lib/pc-bios/keymaps/nl external/androidsdk/emulator/lib/pc-bios/keymaps/nl-be external/androidsdk/emulator/lib/pc-bios/keymaps/no external/androidsdk/emulator/lib/pc-bios/keymaps/pl external/androidsdk/emulator/lib/pc-bios/keymaps/pt external/androidsdk/emulator/lib/pc-bios/keymaps/pt-br external/androidsdk/emulator/lib/pc-bios/keymaps/ru external/androidsdk/emulator/lib/pc-bios/keymaps/sl external/androidsdk/emulator/lib/pc-bios/keymaps/sv external/androidsdk/emulator/lib/pc-bios/keymaps/th external/androidsdk/emulator/lib/pc-bios/keymaps/tr external/androidsdk/emulator/lib/pc-bios/kvmvapic.bin external/androidsdk/emulator/lib/pc-bios/linuxboot.bin external/androidsdk/emulator/lib/pc-bios/linuxboot_dma.bin external/androidsdk/emulator/lib/pc-bios/multiboot.bin external/androidsdk/emulator/lib/pc-bios/vgabios-cirrus.bin external/androidsdk/emulator/lib/pc-bios/vgabios-stdvga.bin external/androidsdk/emulator/lib/pc-bios/vgabios-virtio.bin external/androidsdk/emulator/lib64/gles_mesa/libGL.so external/androidsdk/emulator/lib64/gles_mesa/libGL.so.1 external/androidsdk/emulator/lib64/gles_swiftshader/libEGL.so external/androidsdk/emulator/lib64/gles_swiftshader/libGLES_CM.so external/androidsdk/emulator/lib64/gles_swiftshader/libGLESv2.so external/androidsdk/emulator/lib64/libEGL_translator.so external/androidsdk/emulator/lib64/libGLES12Translator.so external/androidsdk/emulator/lib64/libGLES_CM_translator.so external/androidsdk/emulator/lib64/libGLES_V2_translator.so external/androidsdk/emulator/lib64/libOpenglRender.so external/androidsdk/emulator/lib64/libc++.so external/androidsdk/emulator/lib64/libc++.so.1 external/androidsdk/emulator/lib64/libemugl_common.so external/androidsdk/emulator/lib64/libtcmalloc_minimal.so.4 external/androidsdk/emulator/lib64/libunwind-x86_64.so.8 external/androidsdk/emulator/lib64/libunwind.so.8 external/androidsdk/emulator/lib64/qt/lib/libQt5CoreAndroidEmu.so.5 external/androidsdk/emulator/lib64/qt/lib/libQt5DBusAndroidEmu.so.5 external/androidsdk/emulator/lib64/qt/lib/libQt5GuiAndroidEmu.so.5 external/androidsdk/emulator/lib64/qt/lib/libQt5NetworkAndroidEmu.so.5 external/androidsdk/emulator/lib64/qt/lib/libQt5PrintSupportAndroidEmu.so.5 external/androidsdk/emulator/lib64/qt/lib/libQt5SvgAndroidEmu.so.5 external/androidsdk/emulator/lib64/qt/lib/libQt5WidgetsAndroidEmu.so.5 external/androidsdk/emulator/lib64/qt/lib/libQt5XcbQpaAndroidEmu.so.5 external/androidsdk/emulator/lib64/qt/lib/libfreetype.so.6 external/androidsdk/emulator/lib64/qt/lib/libsoftokn3.so external/androidsdk/emulator/lib64/qt/lib/libsqlite3.so external/androidsdk/emulator/lib64/qt/lib/libxkbcommon.so external/androidsdk/emulator/lib64/qt/lib/libxkbcommon.so.0 external/androidsdk/emulator/lib64/qt/lib/libxkbcommon.so.0.0.0 external/androidsdk/emulator/lib64/qt/plugins/iconengines/libqsvgicon.so external/androidsdk/emulator/lib64/qt/plugins/imageformats/libqgif.so external/androidsdk/emulator/lib64/qt/plugins/imageformats/libqicns.so external/androidsdk/emulator/lib64/qt/plugins/imageformats/libqico.so external/androidsdk/emulator/lib64/qt/plugins/imageformats/libqjpeg.so external/androidsdk/emulator/lib64/qt/plugins/imageformats/libqsvg.so external/androidsdk/emulator/lib64/qt/plugins/imageformats/libqtga.so external/androidsdk/emulator/lib64/qt/plugins/imageformats/libqtiff.so external/androidsdk/emulator/lib64/qt/plugins/imageformats/libqwbmp.so external/androidsdk/emulator/lib64/qt/plugins/imageformats/libqwebp.so external/androidsdk/emulator/lib64/qt/plugins/platforminputcontexts/libcomposeplatforminputcontextplugin.so external/androidsdk/emulator/lib64/qt/plugins/platforms/libqxcb.so external/androidsdk/emulator/lib64/vulkan/glslangValidator external/androidsdk/emulator/lib64/vulkan/libvk_swiftshader.so external/androidsdk/emulator/lib64/vulkan/libvulkan.so external/androidsdk/emulator/lib64/vulkan/libvulkan.so.1 external/androidsdk/emulator/lib64/vulkan/shaders/EacR11Snorm_2DArray.spv external/androidsdk/emulator/lib64/vulkan/shaders/EacR11Snorm_3D.spv external/androidsdk/emulator/lib64/vulkan/shaders/EacR11Unorm_2DArray.spv external/androidsdk/emulator/lib64/vulkan/shaders/EacR11Unorm_3D.spv external/androidsdk/emulator/lib64/vulkan/shaders/EacRG11Snorm_2DArray.spv external/androidsdk/emulator/lib64/vulkan/shaders/EacRG11Snorm_3D.spv external/androidsdk/emulator/lib64/vulkan/shaders/EacRG11Unorm_2DArray.spv external/androidsdk/emulator/lib64/vulkan/shaders/EacRG11Unorm_3D.spv external/androidsdk/emulator/lib64/vulkan/shaders/Etc2RGB8_2DArray.spv external/androidsdk/emulator/lib64/vulkan/shaders/Etc2RGB8_3D.spv external/androidsdk/emulator/lib64/vulkan/shaders/Etc2RGBA8_2DArray.spv external/androidsdk/emulator/lib64/vulkan/shaders/Etc2RGBA8_3D.spv external/androidsdk/emulator/lib64/vulkan/vk_swiftshader_icd.json external/androidsdk/emulator/qemu/linux-x86_64/qemu-system-i386' --flag_configured_android_tools '--adb=external/androidsdk/platform-tools/adb' '--emulator_x86=external/androidsdk/emulator/emulator' '--emulator_arm=external/androidsdk/emulator/emulator' '--adb_static=external/bazel_tools/tools/android/fail.sh' '--mksdcard=external/androidsdk/emulator/mksdcard' '--empty_snapshot_fs=bazel-out/host/bin/external/bazel_tools/tools/android/emulator/snapshots.img' '--bios_files=external/androidsdk/emulator/lib/pc-bios/bios-256k.bin,external/androidsdk/emulator/lib/pc-bios/bios.bin,external/androidsdk/emulator/lib/pc-bios/efi-e1000.rom,external/androidsdk/emulator/lib/pc-bios/efi-e1000e.rom,external/androidsdk/emulator/lib/pc-bios/efi-virtio.rom,external/androidsdk/emulator/lib/pc-bios/kvmvapic.bin,external/androidsdk/emulator/lib/pc-bios/linuxboot.bin,external/androidsdk/emulator/lib/pc-bios/linuxboot_dma.bin,external/androidsdk/emulator/lib/pc-bios/multiboot.bin,external/androidsdk/emulator/lib/pc-bios/vgabios-cirrus.bin,external/androidsdk/emulator/lib/pc-bios/vgabios-stdvga.bin,external/androidsdk/emulator/lib/pc-bios/vgabios-virtio.bin' --nocopy_system_images --single_image_file '--android_sdk_path=external/androidsdk' '--platform_apks=' '--default_properties_file=bazel-out/host/bin/external/android_test_support/tools/android/emulated_devices/generic_phone/_android_23_x86_qemu2_props.properties')
| Execution platform: @bazel_tools//platforms:host_platform
|
| Use --sandbox_debug to see verbose messages from the sandbox
| File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/8ab3d639e2adad62d28400e780405787/sandbox/linux-sandbox/324/execroot/__main__/bazel-out/host/bin/external/android_test_support/tools/android/emulator/unified_launcher_head.runfiles/android_test_support/tools/android/emulator/unified_launcher.py", line 468
| print ''
| ^
| SyntaxError: Missing parentheses in call to 'print'. Did you mean print('')?
| ----------------
| Note: The failure of target @android_test_support//tools/android/emulator:unified_launcher_head (with exit code 1) may have been caused by the fact that it is running under Python 3 instead of Python 2. Examine the error to determine if that appears to be the problem. Since this target is built in the host configuration, the only way to change its version is to set --host_force_python=PY2, which affects the entire build.
|
| If this error started occurring in Bazel 0.27 and later, it may be because the Python toolchain now enforces that targets analyzed as PY2 and PY3 run under a Python 2 and Python 3 interpreter, respectively. See https://github.com/bazelbuild/bazel/issues/7899 for more information.
| ----------------
| Target //src/test:greeter_test failed to build
Regenerate Rules
Hi,
I regenerated gmaven.bzl because I needed a newer library. I'm hosting the file on my own server and I changed my URL as appropriate.
When I try to run I get the following error:
ERROR: error loading package '': Encountered error while reading extension file 'gmaven.bzl': no such package '@gmaven_rules//': Prefix gmaven_rules-20180723 was given, but not found in the archive
ERROR: error loading package '': Encountered error while reading extension file 'gmaven.bzl': no such package '@gmaven_rules//': Prefix gmaven_rules-20180723 was given, but not found in the archive
INFO:
I've double checked what the original artifact looks like when using the artifact from https://github.com/bazelbuild/gmaven_rules/archive vs mine and it looks the same.
Any thoughts?
incompatible_new_actions_api
It looks like this project is not compatible with --incompatible_new_actions_api. Can you look at this? You may need to update your dependencies.
Let me know if you need help.
Add sha1s to gmaven.bzl
This would improve security. Also I hypothesize that this will make things work better with --experimental_repository_cache flag. (not 100% sure how that works, but appears to work with other types of builds once a hash is added)
POM-only dependencies still don't work
While v2.0.1 introduced some level of support for POM-only dependencies, I'm still having issues with them.
How to reproduce:
- Use
rules_jvm_externalv2.0.1 - Try to
maven_installthe dependencyio.vavr:vavr-parent:0.10.0 - Watch the world explode
Ref: http://central.maven.org/maven2/io/vavr/vavr-parent/0.10.0/vavr-parent-0.10.0.pom
Failed build on Buildkite Windows pipeline
Error while trying to read dep-tree.json: java.io.IOException: ERROR: src/main/native/windows/processes-jni.cc(454): CreateProcessW("C:\msys64\usr\bin\cat" D:/b/wpicawde/external/maven/dep-tree.json): The system cannot find the file specified.
--
| and referenced by '//ui/espresso/IntentsBasicSample:IntentsBasicSampleTestLib'
We'll need to replace
rules_jvm_external/coursier.bzl
Line 247 in 3af48fb
Related: bazelbuild/bazel#3766 and bazelbuild/bazel#7309
Annotation processor not found
I added a java_plugin to enable support for annotation processors but it doesn't seem to work:
java_plugin(
name = "epoxy_plugin",
processor_class = "com.airbnb.epoxy.EpoxyProcessor",
deps = [
"@maven//:com_airbnb_android_epoxy",
"@maven//:com_airbnb_android_epoxy_annotations",
],
)
java_library(
name = "epoxy_lib",
exported_plugins = ["epoxy_plugin"],
)
I'm getting the following error:
warning: [kapt] Can't find annotation processor class com.airbnb.epoxy.EpoxyProcessor: com.airbnb.epoxy.EpoxyProcessor
src/main/java/com/matthewcheok/bazeltest/MainActivity.kt:19:17: error: unresolved reference: itemCustomView
itemCustomView {
^
src/main/java/com/matthewcheok/bazeltest/MainActivity.kt:20:21: error: unresolved reference: id
id("custom view $i")
^
src/main/java/com/matthewcheok/bazeltest/MainActivity.kt:21:21: error: expression 'title' of type 'CharSequence!' cannot be invoked as a function. The function 'invoke()' is not found
title("this is a green custom view item")
^
The unresolved references are likely because we're not getting the code generation expected.
The sample repo is at https://github.com/matthewcheok/bazel-epoxy-annotation-processor
Consider an optional switch to turn all `deps` into `exports`, allowing access to all transitive classes just by depending on the top level artifact
This was motivated by a conversation with @simonstewart for better developer ergonomics and gradual adoption, because this is what Maven and Gradle users are used to.
The general idea is to depend on just the top level dependency, and get all the classes in the transitive classpath for free. This was previously implemented by @davidsantiago in jin/rules_maven#9, but we removed it in jin/rules_maven#16 with the concerns stated in the first comment and @dkelmer's comment in jin/rules_maven#16 (review)
We should consider the tradeoffs between ergonomics and the growth of classpath complexity. This can be an opt-in feature with major disclaimers on its implications.
The `+` operator for dicts is deprecated and no longer supported
external/gmaven_rules/import_external.bzl", line 313, in repository_rule
{"jar_urls": attr.string_list(mandatory = True, allow_empty = False), "jar_sha256": attr.string(mandatory = True), "_packaging": attr.string(default = "jar"), "neverlink": attr.bool(), "runtime_deps": attr.string_list()} + COMMON_ATTRS
The `+` operator for dicts is deprecated and no longer supported. Please use the `update` method instead. You can temporarily enable the `+` operator by passing the flag --incompatible_disallow_dict_plus=false
Tested with commit 3f430f1.
Enable Buildkite testing for the new unit and integration tests
The current set of tests are for the legacy gmaven_rules. We should enable Buildkite for the tests in tests/unit and tests/integration.
Windows CI: invalid action: -1 on input 'C'
The Windows build is failing over while parsing Coursier's JSON output: https://buildkite.com/bazel/rules-jvm-external/builds/108#4b82ac0e-7816-4772-944e-4bf05c406e0e
Automate regeneration of gmaven.bzl
So releases are not manual. Ideally, this can be a daily cron job.
Transitive bazel dependencies have public visibility
As a reasonably new user I found it extremely surprising that a transitive dependency that was not declared in the artifacts attribute had public visibility. I would have expected that the way to make a transitive artifact public was to supply a 2-part spec in the artifacts attribute.
This would make it much easier for relative beginners to read the rules as the public targets would be explicitly declared.
Was this ever considered?
Other than that, it has been reasonably easy to get started. Thanks!
v2.0: Unable to generate a target for com.android.support:appcompat-v7:aar:28.0.0
Artifact coordinates: com.android.support:appcompat-v7:aar:28.0.0
Parsed data: {"coord": "com.android.support:appcompat-v7:aar:28.0.0", "file": "v1/https/maven.google.com/com/android/support/appcompat-v7/28.0.0/appcompat-v7-28.0.0.aar", "dependencies": ["android.arch.lifecycle:viewmodel:aar:1.1.1", "com.android.support:customview:aar:28.0.0", "com.android.support:animated-vector-drawable:aar:28.0.0", "com.android.support:print:aar:28.0.0", "com.android.support:asynclayoutinflater:aar:28.0.0", "com.android.support:support-core-utils:aar:28.0.0", "com.android.support:collections:28.0.0", "com.android.support:support-fragment:aar:28.0.0", "com.android.support:viewpager:aar:28.0.0", "com.android.support:support-vector-drawable:aar:28.0.0", "com.android.support:interpolator:aar:28.0.0", "com.android.support:versionedparcelable:aar:28.0.0", "com.android.support:support-core-ui:aar:28.0.0", "com.android.support:swiperefreshlayout:aar:28.0.0", "android.arch.lifecycle:runtime:aar:1.1.1", "com.android.support:support-annotations:28.0.0", "android.arch.core:runtime:aar:1.1.1", "com.android.support:coordinatorlayout:aar:28.0.0", "com.android.support:loader:aar:28.0.0", "android.arch.lifecycle:livedata:aar:1.1.1", "com.android.support:support-compat:aar:28.0.0", "com.android.support:localbroadcastmanager:aar:28.0.0", "com.android.support:cursoradapter:aar:28.0.0", "com.android.support:drawerlayout:aar:28.0.0", "android.arch.lifecycle:livedata-core:aar:1.1.1", "android.arch.lifecycle:common:1.1.1", "com.android.support:slidingpanelayout:aar:28.0.0", "com.android.support:documentfile:aar:28.0.0", "android.arch.core:common:1.1.1"]}
Most definitely caused by dbc4aa7
Breaks with Python toolchains (Bazel 0.27)
Bazel 0.27 flips --incompatible_use_python_toolchains, which breaks this repo. Note that this pipeline was already failing due to a different error.
This flag causes Bazel to use the version of Python requested at analysis time, rather than whatever the system python command happens to be. You likely need to add python_version = "PY2" to your Python targets, and/or enable --force_host_python=PY2 in your bazelrc (if any of these are used in the host configuration).
Support annotation processing java_plugin targets
I'm curious whether there is a plan to support the annotation processing for libraries such as Dagger and AutoValue.
The example BUILD file looks like this:
https://github.com/google/bazel-common/blob/master/third_party/java/auto/BUILD
bazel_maven_repository has this nice capability to customize the BUILD file for artifacts: https://github.com/square/bazel_maven_repository#substitution-of-build-targets
Thank you!
Consider creating @maven//foo_bar on top of @maven//:foo_bar to share convention across Bazel's external repository rules
Context: #160 (comment)
Breaks with Bazel HEAD
Source tree: b89ee49
Bazel version: built at bazelbuild/bazel@12c7942
Test log:
exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //src/test:greeter_test
-----------------------------------------------------------------------------
+ '[' -z '' ']'
+ ANDROID_TESTBRIDGE_TEST_ONLY=
+ test_label=//src/test:greeter_test
+ test_entry_point=../android_test_support/instrumentation_test_runner
+ WORKSPACE_DIR=/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/__main__
+ adb=/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/__main__/../androidsdk/platform-tools/adb
+ aapt=/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/__main__/../androidsdk/aapt_binary
+ device_script=/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/__main__/../android_test_support/tools/android/emulated_devices/generic_phone/android_23_x86_qemu2
+ data_deps=
++ join_paths /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/__main__ ,
++ local base_dir=/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/__main__
++ local sep=,
++ shift 2
++ local paths=
++ local result=
++ echo
+ data_deps=
+ device_broker_type=WRAPPED_EMULATOR
+ target_apk=src/main/greeter_app.apk
+ instrumentation_apk=src/test/greeter_test_app.apk
+ support_apks=
++ join_paths /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/__main__ ,
++ local base_dir=/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/__main__
++ local sep=,
++ shift 2
++ local paths=
++ local result=
++ echo
+ support_apks=
+ apks_to_install=src/main/greeter_app.apk,src/test/greeter_test_app.apk
+ device_script_fixtures=()
+ declare -A device_script_fixtures
+ host_service_fixture=
+ host_service_fixture_services=
+ test_suite_property_name=bazel.test_suite
++ cat
+ bazel_only_argv=--install_test_services=true
++ cat
+++ printf %s,
+++ printf %s,
+ argv='--aapt=/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/__main__/../androidsdk/aapt_binary --adb=/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/__main__/../androidsdk/platform-tools/adb --device_broker_type=WRAPPED_EMULATOR --device_script=/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/__main__/../android_test_support/tools/android/emulated_devices/generic_phone/android_23_x86_qemu2 --data_deps= --test_label=//src/test:greeter_test --apks_to_install=src/main/greeter_app.apk,src/test/greeter_test_app.apk --fixture_scripts=, --hermetic_server_script= --hermetic_servers= --data_deps=, --test_filter= '
+ ../android_test_support/instrumentation_test_runner --wrapper_script_flag=--jvm_flag=-Dbazel.test_suite=com.google.android.apps.common.testing.suite.AndroidDeviceTestSuite '--wrapper_script_flag=--jvm_flag=-Dargv=--install_test_services=true --aapt=/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/__main__/../androidsdk/aapt_binary --adb=/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/__main__/../androidsdk/platform-tools/adb --device_broker_type=WRAPPED_EMULATOR --device_script=/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/__main__/../android_test_support/tools/android/emulated_devices/generic_phone/android_23_x86_qemu2 --data_deps= --test_label=//src/test:greeter_test --apks_to_install=src/main/greeter_app.apk,src/test/greeter_test_app.apk --fixture_scripts=, --hermetic_server_script= --hermetic_servers= --data_deps=, --test_filter= ' --aapt=/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/__main__/../androidsdk/aapt_binary --adb=/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/__main__/../androidsdk/platform-tools/adb --device_broker_type=WRAPPED_EMULATOR --device_script=/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/__main__/../android_test_support/tools/android/emulated_devices/generic_phone/android_23_x86_qemu2 --data_deps= --test_label=//src/test:greeter_test --apks_to_install=src/main/greeter_app.apk,src/test/greeter_test_app.apk --fixture_scripts=, --hermetic_server_script= --hermetic_servers= --data_deps=, --test_filter=
JUnit4 Test Runner
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1 (file:/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/external/android_test_support/opensource/entry_point_deploy.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)
WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.$ReflectUtils$1
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
Jun 07, 2019 2:04:40 AM com.google.android.apps.common.testing.broker.WrappedEmulatedDeviceBroker runEmulatorLaunchScript
INFO: Running emulator launch script: [/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/__main__/../android_test_support/tools/android/emulated_devices/generic_phone/android_23_x86_qemu2, --action=start, --adb_server_port=36811, --adb_port=34026, --emulator_port=52995, --logcat_path=/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/testlogs/src/test/greeter_test/test.outputs/device_logcat/logcat16102378533488436489.txt, --apks=/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/__main__/src/main/greeter_app.apk /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/__main__/src/test/greeter_test_app.apk /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/_tmp/4e4d30a0f396a30869334dc9e8417b33/12405704071759822584/services/test_services.apk /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/_tmp/4e4d30a0f396a30869334dc9e8417b33/12405704071759822584/runner/android_test_orchestrator/stubapp/stubapp.apk, --system_apks=, --subprocess_log_dir=/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/testlogs/src/test/greeter_test/test.outputs/broker_logs/exec-1, --nolaunch_in_seperate_session, --start_vnc_on_port=0, --initial_locale=en-US, --initial_ime=com.android.inputmethod.latin/.LatinIME, --kvm_device=/dev/kvm, --grant_runtime_permissions=true, --logcat_filter='*:I', --enable_display, --nopreverify_apks, --noenable_console_auth, --enable_gps, --export_launch_metadata_path=/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/_tmp/4e4d30a0f396a30869334dc9e8417b33/emulator_meta14600193498143695207.pb, --net_type=fastnet, --long_press_timeout=5000]
Jun 07, 2019 2:04:54 AM com.google.android.apps.common.testing.suite.AndroidDeviceTestSuite$Builder build
WARNING: AndroidDeviceTestSuite Native suite creation failed!
.E
Time: 0.005
There was 1 failure:
1) initializationError(com.google.android.apps.common.testing.suite.AndroidDeviceTestSuite)
java.lang.IllegalStateException: Bad exit code: 1. Command: [/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/__main__/../android_test_support/tools/android/emulated_devices/generic_phone/android_23_x86_qemu2, --action=start, --adb_server_port=36811, --adb_port=34026, --emulator_port=52995, --logcat_path=/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/testlogs/src/test/greeter_test/test.outputs/device_logcat/logcat16102378533488436489.txt, --apks=/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/__main__/src/main/greeter_app.apk /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/__main__/src/test/greeter_test_app.apk /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/_tmp/4e4d30a0f396a30869334dc9e8417b33/12405704071759822584/services/test_services.apk /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/_tmp/4e4d30a0f396a30869334dc9e8417b33/12405704071759822584/runner/android_test_orchestrator/stubapp/stubapp.apk, --system_apks=, --subprocess_log_dir=/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/testlogs/src/test/greeter_test/test.outputs/broker_logs/exec-1, --nolaunch_in_seperate_session, --start_vnc_on_port=0, --initial_locale=en-US, --initial_ime=com.android.inputmethod.latin/.LatinIME, --kvm_device=/dev/kvm, --grant_runtime_permissions=true, --logcat_filter='*:I', --enable_display, --nopreverify_apks, --noenable_console_auth, --enable_gps, --export_launch_metadata_path=/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/_tmp/4e4d30a0f396a30869334dc9e8417b33/emulator_meta14600193498143695207.pb, --net_type=fastnet, --long_press_timeout=5000].
=====Error begin:
...
I0607 02:04:41.200695 140516606297920 emulated_device.py:568] Copying system image to /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/_tmp/4e4d30a0f396a30869334dc9e8417b33/launcher_tmp12753000802223826896/tmpjFG2ZAandroid-emulator-launch/images/session/system.img
I0607 02:04:41.654309 140516606297920 emulated_device.py:3465] Running debugfs commands: ['unlink /vendor/lib/egl']
debugfs 1.44.1 (24-Mar-2018)
I0607 02:04:44.097393 140516606297920 emulated_device.py:717] Making sdcard on the fly due to a nonstandard size
I0607 02:04:44.734656 140516606297920 emulated_device.py:288] Emulator type: 2
I0607 02:04:44.765813 140516606297920 emulated_device.py:1790] Executing: ['/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/androidsdk/emulator/emulator', '-ports', '52995,34026', '-skin', u'480x800', '-timezone', 'America/Los_Angeles', '-cache', 'cache.img', '-memory', '2048', '-sdcard', 'sdcard.img', '-ramdisk', 'ramdisk.img', '-partition-size', '2047', '-no-snapshot-save', '-verbose', '-unix-pipe', 'sockets/qemu.mgmt', '-unix-pipe', 'sockets/device-forward-server', '-unix-pipe', 'sockets/tar-pull-server', '-unix-pipe', 'sockets/exec-server', '-unix-pipe', 'sockets/tar-push-server', '-unix-pipe', 'sockets/h2o', '-writable-system', '-show-kernel', '-engine', 'qemu2', '-kernel', 'kernel-ranchu', '-system', 'system.img', '-feature', 'AllowSnapshotMigration', '-feature', '-GLDMA', '-feature', '-OnDemandSnapshotLoad', '-data', 'userdata-qemu.img', '-gpu', 'swiftshader_indirect', '-no-audio', '-no-boot-anim', '-selinux', u'disabled', '-scale', '1.0', '-fixed-scale', '-netdelay', 'none', '-netspeed', 'full', '-avd', 'mobile_ninjas.adb.34026', '-qemu', u'-enable-kvm', '-L', '/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/_tmp/4e4d30a0f396a30869334dc9e8417b33/launcher_tmp12753000802223826896/tmpjFG2ZAandroid-emulator-launch/bios', '-append', 'enable_test_harness=1']
I0607 02:04:44.768162 140516606297920 emulated_device.py:1824] Launching emulator in: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/_tmp/4e4d30a0f396a30869334dc9e8417b33/launcher_tmp12753000802223826896/tmpjFG2ZAandroid-emulator-launch/images/session
I0607 02:04:44.768557 140516606297920 emulated_device.py:1830] Write emulator log to /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/testlogs/src/test/greeter_test/test.outputs/emulator_cO4CC9.log
I0607 02:04:44.769979 140516606297920 emulated_device.py:2401] system: False pm: False adb: False sdcard: False boot_complete: False launcher: False pipes: False current step attempts: 0 total attempts: 0
I0607 02:04:44.770735 140516606297920 emulated_device.py:3937] Checking if adb is listening.
I0607 02:04:45.772977 140516606297920 emulated_device.py:2401] system: False pm: False adb: False sdcard: False boot_complete: False launcher: False pipes: False current step attempts: 1 total attempts: 1
I0607 02:04:45.773252 140516606297920 emulated_device.py:3937] Checking if adb is listening.
I0607 02:04:46.774940 140516606297920 emulated_device.py:2401] system: False pm: False adb: False sdcard: False boot_complete: False launcher: False pipes: False current step attempts: 2 total attempts: 2
I0607 02:04:46.775212 140516606297920 emulated_device.py:3937] Checking if adb is listening.
I0607 02:04:47.776967 140516606297920 emulated_device.py:2401] system: False pm: False adb: False sdcard: False boot_complete: False launcher: False pipes: False current step attempts: 3 total attempts: 3
I0607 02:04:47.777350 140516606297920 emulated_device.py:3937] Checking if adb is listening.
I0607 02:04:48.779114 140516606297920 emulated_device.py:2401] system: False pm: False adb: False sdcard: False boot_complete: False launcher: False pipes: False current step attempts: 4 total attempts: 4
I0607 02:04:48.779392 140516606297920 emulated_device.py:3937] Checking if adb is listening.
I0607 02:04:49.781044 140516606297920 emulated_device.py:2401] system: False pm: False adb: False sdcard: False boot_complete: False launcher: False pipes: False current step attempts: 5 total attempts: 5
I0607 02:04:49.781318 140516606297920 emulated_device.py:3937] Checking if adb is listening.
I0607 02:04:50.782953 140516606297920 emulated_device.py:2401] system: False pm: False adb: False sdcard: False boot_complete: False launcher: False pipes: False current step attempts: 6 total attempts: 6
I0607 02:04:50.783231 140516606297920 emulated_device.py:3937] Checking if adb is listening.
I0607 02:04:51.784893 140516606297920 emulated_device.py:2401] system: False pm: False adb: False sdcard: False boot_complete: False launcher: False pipes: False current step attempts: 7 total attempts: 7
I0607 02:04:51.785182 140516606297920 emulated_device.py:3937] Checking if adb is listening.
I0607 02:04:52.786803 140516606297920 emulated_device.py:2401] system: False pm: False adb: False sdcard: False boot_complete: False launcher: False pipes: False current step attempts: 8 total attempts: 8
I0607 02:04:52.787070 140516606297920 emulated_device.py:3937] Checking if adb is listening.
I0607 02:04:53.788687 140516606297920 emulated_device.py:2401] system: False pm: False adb: False sdcard: False boot_complete: False launcher: False pipes: False current step attempts: 9 total attempts: 9
I0607 02:04:53.789071 140516606297920 emulated_device.py:3937] Checking if adb is listening.
I0607 02:04:54.790812 140516606297920 emulated_device.py:2401] system: False pm: False adb: False sdcard: False boot_complete: False launcher: False pipes: False current step attempts: 10 total attempts: 10
E0607 02:04:54.791110 140516606297920 emulated_device.py:3904] Emulator failed to launch: [Errno 10] No child processes
I0607 02:04:54.791465 140516606297920 emulated_device.py:3883] Emulator log below ==================================================
emulator: Android emulator version 29.0.9.0 (build_id 5537588) (CL:N/A)
emulator: Found AVD name 'mobile_ninjas.adb.34026'
emulator: Found AVD target architecture: x86
emulator: argv[0]: '/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/androidsdk/emulator/emulator'; program directory: '/opt/android-sdk-linux/emulator'
emulator: Found directory: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/_tmp/4e4d30a0f396a30869334dc9e8417b33/launcher_tmp12753000802223826896/tmpjFG2ZAandroid-emulator-launch/images/session
emulator: emuDirName: '/opt/android-sdk-linux/emulator'
emulator: Found directory: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/_tmp/4e4d30a0f396a30869334dc9e8417b33/launcher_tmp12753000802223826896/tmpjFG2ZAandroid-emulator-launch/images/session
emulator: Probing for /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/_tmp/4e4d30a0f396a30869334dc9e8417b33/launcher_tmp12753000802223826896/tmpjFG2ZAandroid-emulator-launch/images/session/kernel-ranchu-64: file missing
emulator: try dir /opt/android-sdk-linux/emulator
emulator: Trying emulator path '/opt/android-sdk-linux/emulator/qemu/linux-x86_64/qemu-system-i386'
emulator: Found target-specific 64-bit emulator binary: /opt/android-sdk-linux/emulator/qemu/linux-x86_64/qemu-system-i386
emulator: Adding library search path: '/opt/android-sdk-linux/emulator/lib64'
emulator: Adding library search path: '/opt/android-sdk-linux/emulator/lib64/gles_swiftshader'
emulator: Adding library search path: '/opt/android-sdk-linux/emulator/lib64/gles_angle'
emulator: Adding library search path: '/opt/android-sdk-linux/emulator/lib64/gles_angle9'
emulator: Adding library search path: '/opt/android-sdk-linux/emulator/lib64/gles_angle11'
emulator: Adding library search path: '/opt/android-sdk-linux/emulator/lib64/libstdc++'
emulator: Adding library search path for Qt: '/opt/android-sdk-linux/emulator/lib64/qt/lib'
emulator: Setting Qt plugin search path: QT_QPA_PLATFORM_PLUGIN_PATH=/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/__main__/../androidsdk/emulator/lib64/qt/plugins
emulator: Setting Qt to use software OpenGL: QT_OPENGL=software
emulator: Overriding pre-existing bad Qt high dpi settings...
emulator: Running :/opt/android-sdk-linux/emulator/qemu/linux-x86_64/qemu-system-i386
emulator: qemu backend: argv[00] = "/opt/android-sdk-linux/emulator/qemu/linux-x86_64/qemu-system-i386"
emulator: qemu backend: argv[01] = "-ports"
emulator: qemu backend: argv[02] = "52995,34026"
emulator: qemu backend: argv[03] = "-skin"
emulator: qemu backend: argv[04] = "480x800"
emulator: qemu backend: argv[05] = "-timezone"
emulator: qemu backend: argv[06] = "America/Los_Angeles"
emulator: qemu backend: argv[07] = "-cache"
emulator: qemu backend: argv[08] = "cache.img"
emulator: qemu backend: argv[09] = "-memory"
emulator: qemu backend: argv[10] = "2048"
emulator: qemu backend: argv[11] = "-sdcard"
emulator: qemu backend: argv[12] = "sdcard.img"
emulator: qemu backend: argv[13] = "-ramdisk"
emulator: qemu backend: argv[14] = "ramdisk.img"
emulator: qemu backend: argv[15] = "-partition-size"
emulator: qemu backend: argv[16] = "2047"
emulator: qemu backend: argv[17] = "-no-snapshot-save"
emulator: qemu backend: argv[18] = "-verbose"
emulator: qemu backend: argv[19] = "-unix-pipe"
emulator: qemu backend: argv[20] = "sockets/qemu.mgmt"
emulator: qemu backend: argv[21] = "-unix-pipe"
emulator: qemu backend: argv[22] = "sockets/device-forward-server"
emulator: qemu backend: argv[23] = "-unix-pipe"
emulator: qemu backend: argv[24] = "sockets/tar-pulemulator: autoconfig: -skindir (null)
emulator: Target arch = 'x86'
emulator: Auto-config: -qemu -cpu qemu32
emulator: Auto-detect: Kernel image requires new device naming scheme.
emulator: Auto-detect: Kernel does not support YAFFS2 partitions.
emulator: Using initial system image: system.img
emulator: No vendor image
emulator: autoconfig: -initdata (null)
emulator: WARNING: SELinux 'disabled' is no longer supported starting with API level 23, switching to 'permissive'
emulator: Physical RAM size: 2048MB
emulator: VM heap size 256MB is above maximum supported 192MB, setting it to that value
emulator: WARNING: System image is writable
emulator: Found 1 DNS servers: 169.254.169.254
emulator: [FeatureControl] Feature 'AllowSnapshotMigration' (13) state set to enabled
emulator: [FeatureControl] Feature 'GLDMA' (30) state set to disabled
emulator: [FeatureControl] Feature 'OnDemandSnapshotLoad' (21) state set to disabled
emulator: found magic skin width=480 height=800 bpp=16
emulator: ERROR: no init encryptionkey.img
emulator: ERROR: Encryption is requested but failed to create encrypt partition.
WARNING: engine selection is no longer supported, always using RACNHU.
WARNING: unexpected system image feature string, emulator might not function correctly, please try updating the emulator.
Unexpected feature list: AllowSnapshotMigration CarPropertyTable FastSnapshotV1 ForceANGLE ForceSwiftshader GLPipeChecksum GenericSnapshotsUI HAXM HVF HYPERV IgnoreHostOpenGLErrors KVM LocationUiV2 OnDemandSnapshotLoad QuickbootFileBacked ScreenRecording SnapshotAdb VideoPlayback VirtualScene Vulkan WindowsHypervisorPlatform WindowsOnDemandSnapshotLoad
I0607 02:04:54.791615 140516606297920 emulated_device.py:3884] Emulator log end ==================================================
I0607 02:04:54.791757 140516606297920 emulated_device.py:3897] cannot show log watchdog.out: file does not exist
I0607 02:04:54.791841 140516606297920 emulated_device.py:3897] cannot show log watchdog.err: file does not exist
Traceback (most recent call last):
File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/android_test_support/tools/android/emulator/unified_launcher.py", line 1129, in <module>
app.run(main)
File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/absl_py/absl/app.py", line 262, in run
_run_main(main, argv)
File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/absl_py/absl/app.py", line 227, in _run_main
sys.exit(main(argv))
File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/android_test_support/tools/android/emulator/unified_launcher.py", line 1099, in main
EntryPoint(reporter)
File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/android_test_support/tools/android/emulator/unified_launcher.py", line 935, in EntryPoint
mini_boot, FLAGS.sim_access_rules_file, FLAGS.phone_number)
File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/android_test_support/tools/android/emulator/unified_launcher.py", line 663, in _Run
snapshot_file=FLAGS.snapshot_file)
File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/android_test_support/tools/android/emulator/unified_launcher.py", line 523, in _RestartDevice
snapshot_file=snapshot_file)
File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/android_test_support/tools/android/emulator/emulated_device.py", line 1267, in StartDevice
loading_from_snapshot=loading_from_snapshot)
File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/android_test_support/tools/android/emulator/emulated_device.py", line 1838, in _StartEmulator
self._PollEmulatorStatus(timer, loading_from_snapshot=loading_from_snapshot)
File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/android_test_support/tools/android/emulator/emulated_device.py", line 2402, in _PollEmulatorStatus
self._EnsureEmuRunning()
File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f8cc5f5872dffc8c386385f64cf41a98/sandbox/linux-sandbox/339/execroot/__main__/bazel-out/k8-fastbuild/bin/src/test/greeter_test.runfiles/android_test_support/tools/android/emulator/emulated_device.py", line 3906, in _EnsureEmuRunning
raise Exception('Emulator has died')
Exception: Emulator has died
=====Error end
at com.google.common.base.Preconditions.checkState(Preconditions.java:853)
at com.google.android.apps.common.testing.broker.WrappedEmulatedDeviceBroker.runEmulatorLaunchScript(WrappedEmulatedDeviceBroker.java:555)
at com.google.android.apps.common.testing.broker.WrappedEmulatedDeviceBroker.leaseDevice(WrappedEmulatedDeviceBroker.java:264)
at com.google.android.apps.common.testing.suite.AndroidDeviceTestSuite$Builder.makeNativeTestSuite(AndroidDeviceTestSuite.java:140)
at com.google.android.apps.common.testing.suite.AndroidDeviceTestSuite$Builder.build(AndroidDeviceTestSuite.java:103)
at com.google.android.apps.common.testing.suite.AndroidDeviceTestSuite.suite(AndroidDeviceTestSuite.java:64)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.junit.internal.runners.SuiteMethod.testFromSuiteMethod(SuiteMethod.java:35)
at org.junit.internal.runners.SuiteMethod.<init>(SuiteMethod.java:24)
at org.junit.internal.builders.SuiteMethodBuilder.runnerForClass(SuiteMethodBuilder.java:11)
at org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:59)
at org.junit.internal.builders.AllDefaultPossibilitiesBuilder.runnerForClass(AllDefaultPossibilitiesBuilder.java:26)
at org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:59)
at org.junit.internal.requests.ClassRequest.getRunner(ClassRequest.java:33)
at com.google.testing.junit.runner.internal.junit4.MemoizingRequest.createRunner(MemoizingRequest.java:48)
at com.google.testing.junit.runner.internal.junit4.MemoizingRequest.getRunner(MemoizingRequest.java:34)
at com.google.testing.junit.runner.junit4.JUnit4TestModelBuilder.get(JUnit4TestModelBuilder.java:49)
at com.google.testing.junit.runner.junit4.JUnit4TestModelBuilder.get(JUnit4TestModelBuilder.java:27)
at com.google.testing.junit.runner.util.MemoizingSupplier.get(MemoizingSupplier.java:42)
at com.google.testing.junit.runner.junit4.JUnit4Runner.run(JUnit4Runner.java:92)
at com.google.testing.junit.runner.BazelTestRunner.runTestsInSuite(BazelTestRunner.java:144)
at com.google.testing.junit.runner.BazelTestRunner.main(BazelTestRunner.java:82)
FAILURES!!!
Tests run: 1, Failures: 1
BazelTestRunner exiting with a return value of 1
JVM shutdown hooks (if any) will run now.
The JVM will exit once they complete.
-- JVM shutdown starting at 2019-06-07 02:04:54 --
Initialize transfer to github.com/bazelbuild
- Add LICENSE file (Apache 2.0)
- Add license headers to files
- Add CONTRIBUTING file, noting CLA policy
- Add AUTHORS file
- Update README with support policy
Implement global exclusion for artifacts
Related: coursier/coursier#1122
Currently, we support artifact exclusions using the maven.artifact(exclusions = [...]) helper. This feeds the group:artifact coordinates into a --local-exclude-file for Coursier CLI.
The problem with this is that if artifact A excludes B from its transitive dependencies, and C also depends on B but doesn't exclude it, B will still be fetched into the transitive dependencies on A. This can be confusing and will lead to complex maven_install declarations since every artifact that transitively depends on B will need to exclude it.
Coursier CLI supports another flag called --exclude, which is basically a global exclude. I propose to add another top level exclusions attribute to maven_install, that simply feeds this collection of group:artifact into the CLI --exclude option.
The alternative is to take the per-artifact exclusions and feed them into --exclude, but this breaks the API affinity between maven_install and Coursier CLI, and can be even more confusing down the road.
More discussion from Bazel Slack: https://bazelbuild.slack.com/archives/CDCE4DFAP/p1555009607029700
cc @dkelmer
Special handling needed for pom-only dependencies
I was really excited to try this out (v1.2) and went with a single library I'm familiar with that brings in a whole big tree of dependencies.
maven_install(
artifacts = [
"nz.ac.waikato.cms.weka:weka-stable:3.8.1",
],
repositories = [
"https://repo1.maven.org/maven2",
],
)When I ran bazel query @maven//:all (thanks @jin), it blew up with the following, because com.github.fommil.netlib:all (transitive dep) is a pom-only dependency and exists solely to aggregate other dependencies:
The artifact for com.github.fommil.netlib:all:pom:1.1.2 was not downloaded. Perhaps its packaging type is
not one of: jar,aar,bundle,eclipse-plugin?
User defined artifacts get overridden by transitive dependencies
If a user explicitly references a dependency, we should use that version and not ones brought through transitive dependencies. Basically, prioritize user defined dependencies over anything else. For example:
maven_install(
artifacts = [
"com.google.cloud:google-cloud-storage:1.66.0",
"com.google.guava:guava:27.1-jre",
]
)
Should result in a dependency tree that contains com.google.guava:guava:27.1-jre, and not the one brought by com.google.cloud:google-cloud-storage:1.66.0.
Support artifact checksum pinning
From Bazel slack: https://bazelbuild.slack.com/archives/CE6AZNQP7/p1556024364000500
Coursier supports it: coursier/coursier#625
Optionally add artifacts from jcenter or mavencentral for missing dependencies
I just switched a project over to this, but there are some artifacts that don't have all their dependencies if imported this way as they're not present in google's maven repo.
Would you accept a patch to optionally include those dependencies by bringing them in from one of the public maven repos?
Remove dependency on Maven binary
Consider using another fetching mechanism to download AARs. With Skylark maven_aar, downloads are failing randomly on the CI: bazelbuild/bazel#4979 (comment)
Since we know the exact repository where the files are downloaded from, possible candidates are:
http_file- a variant of
java_import_externalforaar_import
On top of not having maven as a dependency, these two rules use the more robust HttpDownloader underneath, which also supports multiple URLs for fallback.
macOS, Windows CI: Ongoing concurrent download for https://oss.sonatype.org/...
https://buildkite.com/bazel/rules-jvm-external/builds/109#82cb6eb7-5f52-4bd0-af58-9d69bf8dd0f1
ERROR: /Users/buildkite/builds/buildkite-imacpro-7/bazel/rules-jvm-external/tests/integration/BUILD:3:1: no such package '@other_maven//': Unable to run coursier: Error while downloading https://oss.sonatype.org/content/repositories/releases/io/get-coursier/coursier-cli_2.12/1.1.0-M9/coursier-cli_2.12-1.1.0-M9-standalone.jar: Ongoing concurrent download for https://oss.sonatype.org/content/repositories/releases/io/get-coursier/coursier-cli_2.12/1.1.0-M9/coursier-cli_2.12-1.1.0-M9-standalone.jar, ignoring it
Support private repository requiring authentication with Authorization http header in a more secure manner
The current support for HTTP basic authentication relies on username:password@ URL schema.
There are few flaws with this approach:
- Not ever repository server supports the
username:password@URL scheme. Some admins disable it intentionally for security reasons. - The
username:password@URL scheme requires persisting username and passwords in clear text in Bazel files, which are committed to SCM. This is almost impossible to deploy in any corporate environment.- Credentials should be supplied using an external configuration file and/or other form of parameters (eg., secure store, environment variables, etc.).
- User need to be able to provide their own credentials at build time.
Bonus points:
- Allow to provide URL overrides at build time, eg. use a local proxy/mirror instead of what is configured in the Bazel files.
- Repository credentials are read from
~/.m2/settings.xml - Repository mirror urls are read from
~/.m2/settings.xml
Unable to fetch org.pantsbuild:jarjar:1.6.6
Repro:
maven_install(
name = "other_maven",
artifacts = [
"org.pantsbuild:jarjar:1.6.6",
],
fetch_sources = True,
repositories = [
"https://repo1.maven.org/maven2",
],
)$ bazel query @other_maven//:all
ERROR: no such package '@other_maven//': Traceback (most recent call last):
File "/usr/local/google/home/jingwen/.cache/bazel/_bazel_jingwen/8484bc4fff18ee4a905b69a9ddb0e143/external/rules_jvm_external/coursier.bzl", line 380
generate_imports(repository_ctx = repository_ctx, d..., ...)
File "/usr/local/google/home/jingwen/.cache/bazel/_bazel_jingwen/8484bc4fff18ee4a905b69a9ddb0e143/external/rules_jvm_external/coursier.bzl", line 228, in generate_imports
fail((((("The artifact for " + artifa...)))
The artifact for org.eclipse.sisu:org.eclipse.sisu.inject:0.3.2 was not downloaded. Perhaps the packaging type is not one of: jar, aar, bundle?
Parsed artifact data:{"coord": "org.eclipse.sisu:org.eclipse.sisu.inject:0.3.2", "file": None, "dependencies": []}
ERROR: no such package '@other_maven//': Traceback (most recent call last):
File "/usr/local/google/home/jingwen/.cache/bazel/_bazel_jingwen/8484bc4fff18ee4a905b69a9ddb0e143/external/rules_jvm_external/coursier.bzl", line 380
generate_imports(repository_ctx = repository_ctx, d..., ...)
File "/usr/local/google/home/jingwen/.cache/bazel/_bazel_jingwen/8484bc4fff18ee4a905b69a9ddb0e143/external/rules_jvm_external/coursier.bzl", line 228, in generate_imports
fail((((("The artifact for " + artifa...)))
The artifact for org.eclipse.sisu:org.eclipse.sisu.inject:0.3.2 was not downloaded. Perhaps the packaging type is not one of: jar, aar, bundle?
Parsed artifact data:{"coord": "org.eclipse.sisu:org.eclipse.sisu.inject:0.3.2", "file": None, "dependencies": []}
Loading: 0 packages loaded
Fetching @other_maven; Generating BUILD targets.. 16s
The issue is that org.eclipse.sisu:org.eclipse.sisu.inject:0.3.2 type is eclipse-plugin as seen by Coursier, so it wasn't resolved/fetched, even though it has a jar:
https://mvnrepository.com/artifact/org.eclipse.sisu/org.eclipse.sisu.inject/0.3.2
http://central.maven.org/maven2/org/eclipse/sisu/org.eclipse.sisu.inject/0.3.2/
Adding eclipse-plugin to the --artifact-type flag alongside jar,aar,bundle fixes this:
rules_jvm_external/coursier.bzl
Line 329 in fc5bd21
The generated target is a java_import:
$ bazel query --output=build @other_maven//:org_eclipse_sisu_org_eclipse_sisu_inject_0_3_2
# /usr/local/google/home/jingwen/.cache/bazel/_bazel_jingwen/8484bc4fff18ee4a905b69a9ddb0e143/external/other_maven/BUILD:165:1
java_import(
name = "org_eclipse_sisu_org_eclipse_sisu_inject_0_3_2",
tags = ["maven_coordinates=org.eclipse.sisu:org.eclipse.sisu.inject:0.3.2"],
jars = ["@other_maven//:v1/https/repo1.maven.org/maven2/org/eclipse/sisu/org.eclipse.sisu.inject/0.3.2/org.eclipse.sisu.inject-0.3.2.jar"],
srcjar = "@other_maven//:v1/https/repo1.maven.org/maven2/org/eclipse/sisu/org.eclipse.sisu.inject/0.3.2/org.eclipse.sisu.inject-0.3.2-sources.jar",
deps = [],
)
Failed to resolve deps for com.google.firebase:firebase-firestore
Steps to reproduce:
- Modify the simple example inside this rules_jvm_external repo and try using the firebase-firestore.
- Edit WORKSPACE file, add "com.google.firebase:firebase-firestore:18.1.0" to the artifact list.
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
android_sdk_repository(name = "androidsdk")
local_repository(
name = "rules_jvm_external",
path = "../../",
)
load("@rules_jvm_external//:defs.bzl", "maven_install")
maven_install(
artifacts = [
"junit:junit:4.12",
"android.arch.lifecycle:common:1.1.1",
"android.arch.lifecycle:viewmodel:1.1.1",
"androidx.test.espresso:espresso-web:3.1.1",
"com.android.support:design:27.0.2",
"com.google.firebase:firebase-firestore:18.1.0",
],
repositories = [
"https://maven.google.com",
"https://repo1.maven.org/maven2",
],
)
- Edit BUILD file to add the artifact("com.google.firebase:firebase-firestore") line.
load("@rules_jvm_external//:defs.bzl", "artifact")
android_library(
name = "my_lib",
exports = [
artifact("android.arch.lifecycle:common"),
artifact("android.arch.lifecycle:viewmodel"),
artifact("androidx.test.espresso:espresso-web"),
artifact("junit:junit"),
artifact("com.android.support:design"),
artifact("com.google.firebase:firebase-firestore"),
],
)
android_binary(
name = "my_app",
custom_package = "com.example.bazel",
manifest = "AndroidManifest.xml",
deps = [":my_lib"],
)
- Run bazel build :my_app and see the following error:
ERROR: /Users/senpo/Sources/github/bazelbuild/rules_jvm_external/examples/simple/BUILD:3:1: no such package '@maven//': Traceback (most recent call last):
File "/private/var/tmp/_bazel_senpo/d029bda8bea034c8607a9968bc5c1c7e/external/rules_jvm_external/coursier.bzl", line 374
generate_imports(repository_ctx = repository_ctx, d..., ...)
File "/private/var/tmp/_bazel_senpo/d029bda8bea034c8607a9968bc5c1c7e/external/rules_jvm_external/coursier.bzl", line 228, in generate_imports
fail((((("The artifact for " + artifa...)))
The artifact for io.grpc:grpc-android:jar:1.16.1 was not downloaded. Perhaps the packaging type is not one of: jar, aar, bundle?
Parsed artifact data:{"coord": "io.grpc:grpc-android:jar:1.16.1", "file": None, "dependencies": ["io.opencensus:opencensus-contrib-grpc-metrics:0.12.3", "com.google.code.findbugs:jsr305:3.0.2", "io.grpc:grpc-context:1.16.1", "com.google.code.gson:gson:2.7", "io.grpc:grpc-core:1.16.1", "org.checkerframework:checker-compat-qual:2.5.2", "org.codehaus.mojo:animal-sniffer-annotations:1.17", "com.google.j2objc:j2objc-annotations:1.1", "com.google.errorprone:error_prone_annotations:2.2.0", "io.opencensus:opencensus-api:0.12.3", "com.google.guava:guava:26.0-android"]} and referenced by '//:my_lib'
Top-level repository aliases and cross-workspace dependencies
Quite a few projects in the Bazel ecosystem expect their java dependencies to be individually imported as repository rules in their own right, for example grpc-java expects to find the top-level @com_google_guava_guava//jar, which is created via the built-in rule jvm_maven_import_external (from jvm.bzl).
In my current projects, I tend to have a (generated) bunch of jvm_maven_import_external/java_import_external targets which supply both my own targets as well as third-party ones like grpc-java. That is, I don't use the grpc_java_repositories function to import those dependencies; I just ensure that I provide a compatible version in the expected place.
With rules_jvm_external the paradigm is slightly different. Resolution is now to many targets within a single repository rule, i.e. @com_google_guava_guava//jar becomes @maven//:com_google_guava_guava. This of course means that the loaded grpc-java rules can't find their dependencies when I switch to these new rules. If the grpc_java_repositories function is called, it will create a second repository rule for things which may already be available in the @maven workspace, and may cause classpath collisions downstream later.
I can see clear advantages to the new rules, particularly that different versions of the same artifact can now be resolved in different repositories (@maven//:foo_bar != @othermaven//:foo_bar). Downstream classpath collisions are clearly still possible there, so to some extent this grpc-java issue is just the natural outcome of an assumption of top-level repository safety/unity.
But, it might be useful to generate these @foo_bar top-level repository aliases for consistency with the old-style patterns. At least until there is a more obvious solution for reuse of Java deps across a full workspace including external dependency workspaces. Maybe this exists already! I'd be happy to find a solution to this problem :)
The built-in Bazel options such as shadowing and binding are only apparently functional for an entire workspace, so can't be used to generically alias individual targets in either the source or the target workspaces, i.e. it's not possible to redirect the @foo_bar//jar generated by java_import_external, nor target the @maven//:foo_bar for a single artifact.
A couple of options:
- Add a parameter to the
maven_installrule to allow generation of an additionalrepositories.bzlfile, containing a function which can be loaded to create new repository rules for some/all artifacts in the closure, mirroring the format generated byjava_import_external. - Make it easier for downstream workspaces to do the above, by exposing the generated
@maven//:dep-tree.jsonfile.
I have a hacked-up version of the first one, but it feels a bit ugly so far. Is there any plan for a migration path between java_import_external and maven_install? If not, would a PR for either option above be useful?
No resource identifier found for attribute in package
I'm trying to include an external library and use it via xml. The resource processor is unable to find identifiers in the imported package instead searching for it in the current package.
I'm installing the libraries via
maven_install(
artifacts = [
"androidx.constraintlayout:constraintlayout:1.1.3",
"androidx.annotation:annotation:1.0.2",
"androidx.appcompat:appcompat:1.0.2",
"androidx.core:core-ktx:1.0.1",
"androidx.recyclerview:recyclerview:1.0.0",
"com.google.android.material:material:1.0.0",
],
repositories = [
"https://jcenter.bintray.com/",
"https://maven.google.com",
"https://repo1.maven.org/maven2",
],
fetch_sources = True,
)
And importing them via
kt_android_library(
name = "lib",
srcs = glob(["java/**/*.kt"]),
custom_package = "com.matthewcheok.bazeltest",
deps = [
":resources",
"@maven//:androidx_constraintlayout_constraintlayout",
"@maven//:androidx_annotation_annotation",
"@maven//:androidx_appcompat_appcompat",
"@maven//:androidx_core_core",
"@maven//:androidx_core_core_ktx",
"@maven//:androidx_drawerlayout_drawerlayout",
"@maven//:androidx_lifecycle_lifecycle_common",
"@maven//:androidx_lifecycle_lifecycle_viewmodel",
"@maven//:androidx_fragment_fragment",
"@maven//:androidx_recyclerview_recyclerview",
"@maven//:com_google_android_material_material",
],
visibility = ["//visibility:public"],
)
The error is
Error at 10 : /var/folders/x1/s1jm_0bs2gn3nrs5cmbf6l7r0000gn/T/resource_validator_tmp5683318188242105018/tmp-expanded/res/layout/activity_main.xml:10: error: No resource identifier found for attribute 'cardCornerRadius' in package 'com.matthewcheok.bazeltest'
5 : android:layout_width="match_parent"
6 : android:layout_height="match_parent"
7 : android:orientation="vertical">
8 :
9 : <com.google.android.material.card.MaterialCardView
10 : android:layout_width="match_parent"
11 : android:layout_height="72dp"
12 : android:layout_margin="20dp"
13 : android:layout_marginTop="12dp"
14 : android:layout_marginBottom="12dp"
Error at 10 : /var/folders/x1/s1jm_0bs2gn3nrs5cmbf6l7r0000gn/T/resource_validator_tmp5683318188242105018/tmp-expanded/res/layout/activity_main.xml:10: error: No resource identifier found for attribute 'contentPadding' in package 'com.matthewcheok.bazeltest'
5 : android:layout_width="match_parent"
6 : android:layout_height="match_parent"
7 : android:orientation="vertical">
8 :
9 : <com.google.android.material.card.MaterialCardView
10 : android:layout_width="match_parent"
11 : android:layout_height="72dp"
12 : android:layout_margin="20dp"
13 : android:layout_marginTop="12dp"
14 : android:layout_marginBottom="12dp"
The sample repo is available at https://github.com/matthewcheok/bazel_xml_validation
Downloads aren't retried when repositories return 503
When I have a list of multiple repositories in our maven_install call, if the first URL returns a 503, it doesn't fall back to trying the second URL. Instead the build fails with this error:
ERROR: .../BUILD.bazel:5:1: no such package '@maven//': Error while fetching artifact with coursier: Error:
https://...org/jetbrains/kotlin/kotlin-stdlib-common/1.3.0/kotlin-stdlib-common-1.3.0.jar: DownloadError(Caught java.io.IOException: Server returned HTTP response code: 503 for URL: https://...org/jetbrains/kotlin/kotlin-stdlib-common/1.3.0/kotlin-stdlib-common-1.3.0.jar (Server returned HTTP response code: 503 for URL: https://...org/jetbrains/kotlin/kotlin-stdlib-common/1.3.0/kotlin-stdlib-common-1.3.0.jar) while downloading https://...org/jetbrains/kotlin/kotlin-stdlib-common/1.3.0/kotlin-stdlib-common-1.3.0.jar)
If I comment out the URL that's currently 503ing, the build passes
Update Bazel docs to reference rules_jvm_external
Pages with references to legacy Maven approaches:
- https://docs.bazel.build/versions/master/skylark/repository_rules.html#examples
- https://docs.bazel.build/versions/master/query.html#external-repos
- https://docs.bazel.build/versions/master/workspace-log.html#finding-non-hermetic-rules
- https://docs.bazel.build/versions/master/external.html#maven-repositories
- https://docs.bazel.build/versions/master/external.html#transitive-dependencies
- https://docs.bazel.build/versions/master/external.html#repository-rules
- https://docs.bazel.build/versions/master/generate-workspace.html
- https://docs.bazel.build/versions/master/migrate-maven.html
- https://docs.bazel.build/versions/master/android-instrumentation-test.html
- https://github.com/bazelbuild/migration-tooling
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.