Git Product home page Git Product logo

Comments (3)

ola-rozenfeld avatar ola-rozenfeld commented on May 27, 2024

What needs to be verified, probably already there:

  • when the execution times out, a DEADLINE_EXCEEDED status should be returned in the ExecuteResponse status field. It should never be returned as the gRPC status, because that means a different thing semantically.

Additional things:

  • the Operation error field is never used
  • on a cache miss, a PRECONDITION_FAILURE status should be returned, with appropriate MISSING type Violations for each digest, and the digests.
  • if any errors can occur before actual execution, they should be a gRPC status

from bazel-buildfarm.

th0br0 avatar th0br0 commented on May 27, 2024

when the execution times out, a DEADLINE_EXCEEDED status should be returned in the ExecuteResponse status field. It should never be returned as the gRPC status, because that means a different thing semantically.

This is already happening - on timeout, executeCommand will return DEADLINE_EXCEEDED which will be used to set the ExecuteResponse status field.

from bazel-buildfarm.

werkt avatar werkt commented on May 27, 2024

This was accomplished recently with #218, closing

from bazel-buildfarm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.