Add an optional filter to limit artifact sizes by Action about bazel-buildfarm HOT 4 OPEN

So the value to be compared against the limit is "the sum of all file sizes for the tree of inputs to an action"?

from bazel-buildfarm.

I was thinking that we would limit just on the digest's size with values read from configuration.

--- a/src/main/java/build/buildfarm/cas/cfc/CASFileCache.java
+++ b/src/main/java/build/buildfarm/cas/cfc/CASFileCache.java
@@ -790,7 +790,11 @@ public abstract class CASFileCache implements ContentAddressableStorage {
     if (digest.getSizeBytes() == 0) {
       return new CompleteWrite(0);
     }
-    if (digest.getSizeBytes() > maxEntrySizeInBytes) {
+    Set<String> allowedActions = Sets.newConcurrentHashSet();
+    allowedActions.add("JoinLayers");
+    allowedActions.add("PackageTar");
+
+    if (digest.getSizeBytes() > maxEntrySizeInBytes && !allowedActions.contains(requestMetadata.getActionMnemonic())) {
       throw new EntryLimitException(digest.getSizeBytes(), maxEntrySizeInBytes);
     }
     try {

from bazel-buildfarm.

"the digest" as a subject for comparison does not narrow the scope of the filter - we already limit by size generally, and ensure that no blobs can exist in a worker's cas above that limit.

Your suggested change limits by hard coded action mnemonics. What does that have anything to do with 'size'?

from bazel-buildfarm.

Your suggested change limits by hard coded action mnemonics. What does that have anything to do with 'size'?

Good question. From my prototype snippet above, I'm proposing allowing some actions to go above the hardcoded size based on configured list of mnemonics.

from bazel-buildfarm.